From: Nitesh Narayan Lal <nitesh@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
mst@redhat.com, linux-kernel@vger.kernel.org,
willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, osalvador@suse.de
Cc: yang.zhang.wz@gmail.com, pagupta@redhat.com,
konrad.wilk@oracle.com, riel@surriel.com, lcapitulino@redhat.com,
wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com
Subject: Re: [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting
Date: Wed, 2 Oct 2019 11:04:44 -0400 [thread overview]
Message-ID: <46593efd-4a97-cdcc-fe22-01a5400d23c9@redhat.com> (raw)
In-Reply-To: <150e09b3-42c0-567e-55b8-7be6b45fd576@intel.com>
On 10/1/19 4:51 PM, Dave Hansen wrote:
> On 10/1/19 1:49 PM, Alexander Duyck wrote:
>> So it looks like v12 still has issues. I'm pretty sure you should be using
>> spin_lock_irq(), not spin_lock() in page_reporting.c to avoid the
>> possibility of an IRQ firing and causing lock recursion on the zone lock.
> Lockdep should make all of this a lot easier to find. Is it being used?
I do have it in the function which returns the pages to the buddy but I missed
it in the function that isolates the pages.
I will correct this.
--
Thanks
Nitesh
WARNING: multiple messages have this Message-ID (diff)
From: Nitesh Narayan Lal <nitesh@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
mst@redhat.com, linux-kernel@vger.kernel.org,
willy@infradead.org, mhocko@kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, osalvador@suse.de
Cc: yang.zhang.wz@gmail.com, pagupta@redhat.com,
konrad.wilk@oracle.com, riel@surriel.com, lcapitulino@redhat.com,
wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com
Subject: [virtio-dev] Re: [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting
Date: Wed, 2 Oct 2019 11:04:44 -0400 [thread overview]
Message-ID: <46593efd-4a97-cdcc-fe22-01a5400d23c9@redhat.com> (raw)
In-Reply-To: <150e09b3-42c0-567e-55b8-7be6b45fd576@intel.com>
On 10/1/19 4:51 PM, Dave Hansen wrote:
> On 10/1/19 1:49 PM, Alexander Duyck wrote:
>> So it looks like v12 still has issues. I'm pretty sure you should be using
>> spin_lock_irq(), not spin_lock() in page_reporting.c to avoid the
>> possibility of an IRQ firing and causing lock recursion on the zone lock.
> Lockdep should make all of this a lot easier to find. Is it being used?
I do have it in the function which returns the pages to the buddy but I missed
it in the function that isolates the pages.
I will correct this.
--
Thanks
Nitesh
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2019-10-02 15:05 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 15:29 [PATCH v11 0/6] mm / virtio: Provide support for unused page reporting Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:29 ` [PATCH v11 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:29 ` [PATCH v11 2/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-15 0:42 ` [mm] 2eca680594: will-it-scale.per_process_ops -2.5% regression kernel test robot
2019-10-15 0:42 ` kernel test robot
2019-10-01 15:29 ` [PATCH v11 3/6] mm: Introduce Reported pages Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:29 ` [PATCH v11 4/6] mm: Add device side and notifier for unused page reporting Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:29 ` [PATCH v11 5/6] virtio-balloon: Pull page poisoning config out of free page hinting Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:29 ` [PATCH v11 6/6] virtio-balloon: Add support for providing unused page reports to host Alexander Duyck
2019-10-01 15:29 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:31 ` [PATCH v11 QEMU 1/3] virtio-ballon: Implement support for page poison tracking feature Alexander Duyck
2019-10-01 15:31 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:31 ` [PATCH v11 QEMU 2/3] virtio-balloon: Add bit to notify guest of unused page reporting Alexander Duyck
2019-10-01 15:31 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:31 ` [PATCH v11 QEMU 3/3] virtio-balloon: Provide a interface for " Alexander Duyck
2019-10-01 15:31 ` [virtio-dev] " Alexander Duyck
2019-10-01 15:35 ` [PATCH v11 0/6] mm / virtio: Provide support " David Hildenbrand
2019-10-01 15:35 ` [virtio-dev] " David Hildenbrand
2019-10-01 16:21 ` Alexander Duyck
2019-10-01 16:21 ` [virtio-dev] " Alexander Duyck
2019-10-01 16:21 ` Alexander Duyck
2019-10-01 18:41 ` David Hildenbrand
2019-10-01 18:41 ` [virtio-dev] " David Hildenbrand
2019-10-01 19:17 ` Nitesh Narayan Lal
2019-10-01 19:17 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-01 19:08 ` Michael S. Tsirkin
2019-10-01 19:08 ` [virtio-dev] " Michael S. Tsirkin
2019-10-01 19:16 ` Nitesh Narayan Lal
2019-10-01 19:16 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-01 20:25 ` Alexander Duyck
2019-10-01 20:25 ` [virtio-dev] " Alexander Duyck
2019-10-01 20:25 ` Alexander Duyck
2019-10-01 20:49 ` Alexander Duyck
2019-10-01 20:49 ` [virtio-dev] " Alexander Duyck
2019-10-01 20:49 ` Alexander Duyck
2019-10-01 20:51 ` Dave Hansen
2019-10-02 15:04 ` Nitesh Narayan Lal [this message]
2019-10-02 15:04 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-02 14:41 ` Nitesh Narayan Lal
2019-10-02 14:41 ` Nitesh Narayan Lal
2019-10-02 0:55 ` Alexander Duyck
2019-10-02 0:55 ` [virtio-dev] " Alexander Duyck
2019-10-02 0:55 ` Alexander Duyck
2019-10-02 7:13 ` David Hildenbrand
2019-10-02 7:13 ` [virtio-dev] " David Hildenbrand
2019-10-02 10:44 ` Nitesh Narayan Lal
2019-10-02 10:44 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-02 10:36 ` Nitesh Narayan Lal
2019-10-02 10:36 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-02 14:25 ` Alexander Duyck
2019-10-02 14:25 ` [virtio-dev] " Alexander Duyck
2019-10-02 14:25 ` Alexander Duyck
2019-10-02 14:36 ` Nitesh Narayan Lal
2019-10-02 14:36 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-07 12:29 ` Nitesh Narayan Lal
2019-10-07 12:29 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-07 15:33 ` Alexander Duyck
2019-10-07 15:33 ` [virtio-dev] " Alexander Duyck
2019-10-07 15:33 ` Alexander Duyck
2019-10-07 16:19 ` Nitesh Narayan Lal
2019-10-07 16:19 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-07 16:27 ` Alexander Duyck
2019-10-07 16:27 ` [virtio-dev] " Alexander Duyck
2019-10-07 16:27 ` Alexander Duyck
2019-10-07 17:06 ` Nitesh Narayan Lal
2019-10-07 17:06 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-07 17:20 ` Alexander Duyck
2019-10-07 17:20 ` [virtio-dev] " Alexander Duyck
2019-10-07 17:20 ` Alexander Duyck
2019-10-09 16:25 ` Nitesh Narayan Lal
2019-10-09 16:25 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-09 16:25 ` Nitesh Narayan Lal
2019-10-09 16:50 ` Alexander Duyck
2019-10-09 16:50 ` [virtio-dev] " Alexander Duyck
2019-10-09 16:50 ` Alexander Duyck
2019-10-09 17:08 ` Nitesh Narayan Lal
2019-10-09 17:08 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-09 17:26 ` Alexander Duyck
2019-10-09 17:26 ` [virtio-dev] " Alexander Duyck
2019-10-09 17:26 ` Alexander Duyck
2019-10-09 15:21 ` Nitesh Narayan Lal
2019-10-09 15:21 ` [virtio-dev] " Nitesh Narayan Lal
2019-10-09 16:35 ` Alexander Duyck
2019-10-09 16:35 ` Alexander Duyck
2019-10-09 16:35 ` Alexander Duyck
2019-10-09 19:46 ` Nitesh Narayan Lal
2019-10-10 7:36 ` David Hildenbrand
2019-10-10 10:27 ` Nitesh Narayan Lal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46593efd-4a97-cdcc-fe22-01a5400d23c9@redhat.com \
--to=nitesh@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=willy@infradead.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.