Re: [PATCH v6 06/11] iotests: define group in each iotest

From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 06/11] iotests: define group in each iotest
Date: Wed, 13 Jan 2021 17:01:12 -0600	[thread overview]
Message-ID: <4699f967-d0d8-5f58-38c6-bfd6be65f4f0@redhat.com> (raw)
In-Reply-To: <20210109122631.167314-7-vsementsov@virtuozzo.com>

On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to drop group file. Define group in tests as a preparatory
> step.
> 
> The patch is generated by
> 
>     cd tests/qemu-iotests
> 
>     grep '^[0-9]\{3\} ' group | while read line; do
>         file=$(awk '{print $1}' <<< "$line");
>         groups=$(sed -e 's/^... //' <<< "$line");
>         awk "NR==2{print \"# group: $groups\"}1" $file > tmp;
>         cat tmp > $file;
>     done
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---

>  291 files changed, 291 insertions(+)

May need rebasing, but your reproduction formula works (requires bash,
but that's fine since the tests themselves do as well).

> +++ b/tests/qemu-iotests/312
> @@ -1,4 +1,5 @@
>  #!/usr/bin/env bash
> +# group: rw quick
>  #
>  # Test drive-mirror with quorum
>  #

I like how it looks.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org