Re: [PATCH v6 08/11] iotests: add testenv.py - Vladimir Sementsov-Ogievskiy

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
	den@openvz.org, jsnow@redhat.com
Subject: Re: [PATCH v6 08/11] iotests: add testenv.py
Date: Sat, 16 Jan 2021 14:03:25 +0300	[thread overview]
Message-ID: <c52d0f46-116f-5f28-a15f-0bc128fca7eb@virtuozzo.com> (raw)
In-Reply-To: <7e520790-bc1e-739e-3822-ca78799f5a3f@virtuozzo.com>

15.01.2021 16:30, Vladimir Sementsov-Ogievskiy wrote:
> 15.01.2021 16:20, Kevin Wolf wrote:
>> Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>> 15.01.2021 15:45, Kevin Wolf wrote:
>>>> Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>>> 15.01.2021 14:18, Kevin Wolf wrote:
>>>>>> Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>>>>> Add TestEnv class, which will handle test environment in a new python
>>>>>>> iotests running framework.
>>>>>>>
>>>>>>> Difference with current ./check interface:
>>>>>>> - -v (verbose) option dropped, as it is unused
>>>>>>>
>>>>>>> - -xdiff option is dropped, until somebody complains that it is needed
>>>>>>> - same for -n option
>>>>>>>
>>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>>>> ---
>>>>>>>     tests/qemu-iotests/testenv.py | 328 ++++++++++++++++++++++++++++++++++
>>>>>>>     1 file changed, 328 insertions(+)
>>>>>>>     create mode 100755 tests/qemu-iotests/testenv.py
>>>>>>>
>>>
>>> [..]
>>>
>>>>>>> +    def init_binaries(self):
>>>>>>> +        """Init binary path variables:
>>>>>>> +             PYTHON (for bash tests)
>>>>>>> +             QEMU_PROG, QEMU_IMG_PROG, QEMU_IO_PROG, QEMU_NBD_PROG, QSD_PROG
>>>>>>> +             SOCKET_SCM_HELPER
>>>>>>> +        """
>>>>>>> +        self.python = '/usr/bin/python3 -B'
>>>>>>
>>>>>> This doesn't look right, we need to respect the Python binary set in
>>>>>> configure (which I think we get from common.env)
>>>>>
>>>>> Oh, I missed the change. Then I should just drop this self.python.
>>>>
>>>> Do we still get the value from elsewhere or do we need to manually parse
>>>> common.env?
>>>
>>> Hmm.. Good question. We have either parse common.env, and still create self.python variable.
>>>
>>> Or drop it, and include common.env directly to bash tests. For this we'll need to export
>>>
>>> BUILD_IOTESTS, and do
>>>   . $BUILD_IOTESTS/common.env
>>>
>>> in common.rc..
>>
>> check uses it, too, for running Python test cases.
>>
> 
> But new check (written in python) doesn't.. Should I keep bash check, which will have only one line to call check.py with help of PYTHON?
> 
> 

Or finally, may be just drop it? Can we just use system python for tests, now when we are already in a python3 world?

-- 
Best regards,
Vladimir