From: Michal Wajdeczko <michal.wajdeczko@intel.com> To: Matthew Brost <matthew.brost@intel.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation Date: Mon, 7 Jun 2021 21:38:58 +0200 [thread overview] Message-ID: <46b24580-493d-7bee-09af-5996b886c6d4@intel.com> (raw) In-Reply-To: <20210607174550.GA14577@sdutt-i7> On 07.06.2021 19:45, Matthew Brost wrote: > On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote: >> From: Michal Wajdeczko <michal.wajdeczko@intel.com> >> >> GuC ABI documentation is now ready to be included in i915.rst >> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> >> Signed-off-by: Matthew Brost <matthew.brost@intel.com> >> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com> > > Michal - I noticed while putting this series together that there is > kernel doc in intel_guc_ct.* but this isn't inclued in i915.rst. Do you > think we should add the those here or in a new section (e.g. GuC CTBs)? > > Let me know what you think and I can fix this up before this gets > merged. What's in intel_guc_ct.* is implementation detail, that should be placed in separate section, while this patch adds pure ABI definitions that deserve its own dedicated section. Btw, this patch does not need to be squashed with others, as it is about updating .rst only and is not breaking anything. Same for patch 1/13 that introduces new definitions in new .h file. Michal > > With that, for this patch: > > Reviewed-by: Matthew Brost <matthew.brost@intel.com> > >> --- >> Documentation/gpu/i915.rst | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst >> index 42ce0196930a..c7846b1d9293 100644 >> --- a/Documentation/gpu/i915.rst >> +++ b/Documentation/gpu/i915.rst >> @@ -518,6 +518,14 @@ GuC-based command submission >> .. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> :doc: GuC-based command submission >> >> +GuC ABI >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h >> + >> HuC >> --- >> .. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_huc.c >> -- >> 2.28.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
WARNING: multiple messages have this Message-ID (diff)
From: Michal Wajdeczko <michal.wajdeczko@intel.com> To: Matthew Brost <matthew.brost@intel.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation Date: Mon, 7 Jun 2021 21:38:58 +0200 [thread overview] Message-ID: <46b24580-493d-7bee-09af-5996b886c6d4@intel.com> (raw) In-Reply-To: <20210607174550.GA14577@sdutt-i7> On 07.06.2021 19:45, Matthew Brost wrote: > On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote: >> From: Michal Wajdeczko <michal.wajdeczko@intel.com> >> >> GuC ABI documentation is now ready to be included in i915.rst >> >> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> >> Signed-off-by: Matthew Brost <matthew.brost@intel.com> >> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com> > > Michal - I noticed while putting this series together that there is > kernel doc in intel_guc_ct.* but this isn't inclued in i915.rst. Do you > think we should add the those here or in a new section (e.g. GuC CTBs)? > > Let me know what you think and I can fix this up before this gets > merged. What's in intel_guc_ct.* is implementation detail, that should be placed in separate section, while this patch adds pure ABI definitions that deserve its own dedicated section. Btw, this patch does not need to be squashed with others, as it is about updating .rst only and is not breaking anything. Same for patch 1/13 that introduces new definitions in new .h file. Michal > > With that, for this patch: > > Reviewed-by: Matthew Brost <matthew.brost@intel.com> > >> --- >> Documentation/gpu/i915.rst | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst >> index 42ce0196930a..c7846b1d9293 100644 >> --- a/Documentation/gpu/i915.rst >> +++ b/Documentation/gpu/i915.rst >> @@ -518,6 +518,14 @@ GuC-based command submission >> .. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> :doc: GuC-based command submission >> >> +GuC ABI >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h >> +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h >> + >> HuC >> --- >> .. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_huc.c >> -- >> 2.28.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-07 19:39 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 18:03 [PATCH 00/13] Update firmware to v62.0.0 Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 01/13] drm/i915/guc: Introduce unified HXG messages Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 22:46 ` Daniele Ceraolo Spurio 2021-06-07 22:46 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-08 7:59 ` Michal Wajdeczko 2021-06-08 7:59 ` [Intel-gfx] " Michal Wajdeczko 2021-06-07 18:03 ` [PATCH 02/13] drm/i915/guc: Update MMIO based communication Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 23:06 ` Daniele Ceraolo Spurio 2021-06-07 23:06 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-08 8:15 ` Michal Wajdeczko 2021-06-08 8:15 ` [Intel-gfx] " Michal Wajdeczko 2021-06-09 1:03 ` Daniele Ceraolo Spurio 2021-06-09 1:03 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-07 18:03 ` [PATCH 03/13] drm/i915/guc: Update CTB response status definition Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-08 0:05 ` Daniele Ceraolo Spurio 2021-06-08 0:05 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-08 8:23 ` Michal Wajdeczko 2021-06-08 8:23 ` [Intel-gfx] " Michal Wajdeczko 2021-06-07 18:03 ` [PATCH 04/13] drm/i915/guc: Support per context scheduling policies Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 05/13] drm/i915/guc: Add flag for mark broken CTB Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 06/13] drm/i915/guc: New definition of the CTB descriptor Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-08 0:59 ` Daniele Ceraolo Spurio 2021-06-08 0:59 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-09 18:28 ` Michal Wajdeczko 2021-06-09 18:28 ` [Intel-gfx] " Michal Wajdeczko 2021-06-07 18:03 ` [PATCH 07/13] drm/i915/guc: New definition of the CTB registration action Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-08 1:23 ` Daniele Ceraolo Spurio 2021-06-08 1:23 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-09 17:36 ` John Harrison 2021-06-09 17:36 ` [Intel-gfx] " John Harrison 2021-06-09 20:07 ` Michal Wajdeczko 2021-06-09 20:07 ` [Intel-gfx] " Michal Wajdeczko 2021-06-10 4:38 ` Matthew Brost 2021-06-10 4:38 ` [Intel-gfx] " Matthew Brost 2021-06-10 13:19 ` Michal Wajdeczko 2021-06-10 13:19 ` [Intel-gfx] " Michal Wajdeczko 2021-06-11 18:43 ` Matthew Brost 2021-06-11 18:43 ` [Intel-gfx] " Matthew Brost 2021-06-09 19:35 ` Michal Wajdeczko 2021-06-09 19:35 ` [Intel-gfx] " Michal Wajdeczko 2021-06-07 18:03 ` [PATCH 08/13] drm/i915/guc: New CTB based communication Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-08 2:20 ` Daniele Ceraolo Spurio 2021-06-08 2:20 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-10 4:01 ` Matthew Brost 2021-06-10 4:01 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 17:45 ` Matthew Brost 2021-06-07 17:45 ` Matthew Brost 2021-06-07 19:38 ` Michal Wajdeczko [this message] 2021-06-07 19:38 ` Michal Wajdeczko 2021-06-07 19:35 ` Matthew Brost 2021-06-07 19:35 ` Matthew Brost 2021-06-07 18:03 ` [PATCH 10/13] drm/i915/guc: Kill guc_clients.ct_pool Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 17:57 ` Matthew Brost 2021-06-07 17:57 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 11/13] drm/i915/guc: Kill ads.client_info Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 12/13] drm/i915/guc: Unified GuC log Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:05 ` Matthew Brost 2021-06-07 18:05 ` [Intel-gfx] " Matthew Brost 2021-06-07 18:03 ` [PATCH 13/13] drm/i915/guc: Update firmware to v62.0.0 Matthew Brost 2021-06-07 18:03 ` [Intel-gfx] " Matthew Brost 2021-06-07 19:17 ` Matthew Brost 2021-06-07 19:17 ` Matthew Brost 2021-06-07 18:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2021-06-07 18:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-06-07 18:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-07 18:34 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2021-06-07 22:19 ` [PATCH 00/13] " Daniele Ceraolo Spurio 2021-06-07 22:19 ` [Intel-gfx] " Daniele Ceraolo Spurio 2021-06-11 18:44 ` Matthew Brost 2021-06-11 18:44 ` [Intel-gfx] " Matthew Brost 2021-06-08 2:17 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 2021-06-10 4:36 [PATCH 00/13] " Matthew Brost 2021-06-10 4:36 ` [Intel-gfx] [PATCH 09/13] drm/i915/doc: Include GuC ABI documentation Matthew Brost 2021-06-10 13:55 ` Piotr Piórkowski 2021-06-10 13:55 ` Piotr Piórkowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=46b24580-493d-7bee-09af-5996b886c6d4@intel.com \ --to=michal.wajdeczko@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=matthew.brost@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.