From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Olof Johansson <olof@lixom.net>,
linux-samsung-soc@vger.kernel.org, t.figa@samsung.com,
hyunhee.kim@samsung.com, sw0312.kim@samsung.com,
linux-kernel@vger.kernel.org, yj44.cho@samsung.com,
inki.dae@samsung.com, kyungmin.park@samsung.com,
kgene.kim@samsung.com
Subject: Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID
Date: Fri, 11 Apr 2014 10:12:30 +0200 [thread overview]
Message-ID: <4735652.2Yh9suVdiT@wuerfel> (raw)
In-Reply-To: <53479545.4050707@samsung.com>
On Friday 11 April 2014 16:09:57 Chanwoo Choi wrote:
> On 04/11/2014 03:32 PM, Chanwoo Choi wrote:
> >>>
> >>> +#if defined(CONFIG_SOC_EXYNOS3250)
> >>> +# define soc_is_exynos3250() is_samsung_exynos3250()
> >>> +#else
> >>> +# define soc_is_exynos3250() 0
> >>> +#endif
> >>
> >> In general, I think we have too much code littered with soc_is_<foo>() going
> >> on, so please try to avoid adding more for this SoC. Especially in cases where
> >> you just want to bail out of certain features where we might already have
> >> function pointers to control if a function is called or not, such as the
> >> firmware interfaces.
> >>
> >
> > Do you prefer dt helper function such as following function instead of new soc_is_xx() ?
> > - of_machine_is_compatible("samsung,exynos3250")
> >
>
> I think of_machine_is_compatible() is not proper alternative method.
> of_machine_is_compatible can be only used if CONFIG_OF is enabled.
>
CONFIG_OF is enabled by definition, that wouldn't be a problem. However,
of_machine_is_compatible() doesn't solve the problem that Olof mentioned,
you still make runtime-decisions based on the SoC ID, which you should not.
Instead, the code should be restructured so it doesn't have to know which
SoC is being used. If some machines work differently from others, that should
be local knowledge within the device driver, and it can use for instance
a DT property of the device node that describes the register set the driver
is using.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, t.figa@samsung.com,
hyunhee.kim@samsung.com, sw0312.kim@samsung.com,
linux-kernel@vger.kernel.org, yj44.cho@samsung.com,
inki.dae@samsung.com, Chanwoo Choi <cw00.choi@samsung.com>,
kyungmin.park@samsung.com, kgene.kim@samsung.com,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID
Date: Fri, 11 Apr 2014 10:12:30 +0200 [thread overview]
Message-ID: <4735652.2Yh9suVdiT@wuerfel> (raw)
In-Reply-To: <53479545.4050707@samsung.com>
On Friday 11 April 2014 16:09:57 Chanwoo Choi wrote:
> On 04/11/2014 03:32 PM, Chanwoo Choi wrote:
> >>>
> >>> +#if defined(CONFIG_SOC_EXYNOS3250)
> >>> +# define soc_is_exynos3250() is_samsung_exynos3250()
> >>> +#else
> >>> +# define soc_is_exynos3250() 0
> >>> +#endif
> >>
> >> In general, I think we have too much code littered with soc_is_<foo>() going
> >> on, so please try to avoid adding more for this SoC. Especially in cases where
> >> you just want to bail out of certain features where we might already have
> >> function pointers to control if a function is called or not, such as the
> >> firmware interfaces.
> >>
> >
> > Do you prefer dt helper function such as following function instead of new soc_is_xx() ?
> > - of_machine_is_compatible("samsung,exynos3250")
> >
>
> I think of_machine_is_compatible() is not proper alternative method.
> of_machine_is_compatible can be only used if CONFIG_OF is enabled.
>
CONFIG_OF is enabled by definition, that wouldn't be a problem. However,
of_machine_is_compatible() doesn't solve the problem that Olof mentioned,
you still make runtime-decisions based on the SoC ID, which you should not.
Instead, the code should be restructured so it doesn't have to know which
SoC is being used. If some machines work differently from others, that should
be local knowledge within the device driver, and it can use for instance
a DT property of the device node that describes the register set the driver
is using.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID
Date: Fri, 11 Apr 2014 10:12:30 +0200 [thread overview]
Message-ID: <4735652.2Yh9suVdiT@wuerfel> (raw)
In-Reply-To: <53479545.4050707@samsung.com>
On Friday 11 April 2014 16:09:57 Chanwoo Choi wrote:
> On 04/11/2014 03:32 PM, Chanwoo Choi wrote:
> >>>
> >>> +#if defined(CONFIG_SOC_EXYNOS3250)
> >>> +# define soc_is_exynos3250() is_samsung_exynos3250()
> >>> +#else
> >>> +# define soc_is_exynos3250() 0
> >>> +#endif
> >>
> >> In general, I think we have too much code littered with soc_is_<foo>() going
> >> on, so please try to avoid adding more for this SoC. Especially in cases where
> >> you just want to bail out of certain features where we might already have
> >> function pointers to control if a function is called or not, such as the
> >> firmware interfaces.
> >>
> >
> > Do you prefer dt helper function such as following function instead of new soc_is_xx() ?
> > - of_machine_is_compatible("samsung,exynos3250")
> >
>
> I think of_machine_is_compatible() is not proper alternative method.
> of_machine_is_compatible can be only used if CONFIG_OF is enabled.
>
CONFIG_OF is enabled by definition, that wouldn't be a problem. However,
of_machine_is_compatible() doesn't solve the problem that Olof mentioned,
you still make runtime-decisions based on the SoC ID, which you should not.
Instead, the code should be restructured so it doesn't have to know which
SoC is being used. If some machines work differently from others, that should
be local knowledge within the device driver, and it can use for instance
a DT property of the device node that describes the register set the driver
is using.
Arnd
next prev parent reply other threads:[~2014-04-11 8:14 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 9:37 [PATCH 00/27] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-11 1:46 ` Olof Johansson
2014-04-11 1:46 ` Olof Johansson
2014-04-11 6:32 ` Chanwoo Choi
2014-04-11 6:32 ` Chanwoo Choi
2014-04-11 7:09 ` Chanwoo Choi
2014-04-11 7:09 ` Chanwoo Choi
2014-04-11 8:12 ` Arnd Bergmann [this message]
2014-04-11 8:12 ` Arnd Bergmann
2014-04-11 8:12 ` Arnd Bergmann
2014-04-11 8:39 ` Tomasz Figa
2014-04-11 8:39 ` Tomasz Figa
2014-04-14 5:13 ` Chanwoo Choi
2014-04-14 5:13 ` Chanwoo Choi
2014-04-16 15:53 ` Tomasz Figa
2014-04-16 15:53 ` Tomasz Figa
2014-04-17 1:37 ` Chanwoo Choi
2014-04-17 1:37 ` Chanwoo Choi
2014-04-11 3:56 ` Sachin Kamat
2014-04-11 3:56 ` Sachin Kamat
2014-04-11 5:54 ` Chanwoo Choi
2014-04-11 5:54 ` Chanwoo Choi
2014-04-11 5:56 ` Sachin Kamat
2014-04-11 5:56 ` Sachin Kamat
2014-04-11 6:07 ` Chanwoo Choi
2014-04-11 6:07 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 02/27] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM of Exynos3250 Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 03/27] ARM: EXYNOS: Add IO mapping for PMU " Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-11 1:48 ` Olof Johansson
2014-04-11 1:48 ` Olof Johansson
2014-04-11 2:03 ` Chanwoo Choi
2014-04-11 2:03 ` Chanwoo Choi
2014-04-11 8:41 ` Arnd Bergmann
2014-04-11 8:41 ` Arnd Bergmann
2014-04-11 22:39 ` 최찬우
2014-04-11 22:39 ` 최찬우
2014-04-10 9:37 ` [PATCH 04/27] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-11 1:44 ` Olof Johansson
2014-04-11 1:44 ` Olof Johansson
2014-04-11 5:14 ` Chanwoo Choi
2014-04-11 5:14 ` Chanwoo Choi
2014-04-11 6:04 ` Sangbeom Kim
2014-04-11 6:04 ` Sangbeom Kim
2014-04-11 7:14 ` Tomasz Figa
2014-04-11 7:14 ` Tomasz Figa
2014-04-10 9:37 ` [PATCH 05/27] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 06/27] ARM: EXYNOS:: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 07/27] irqchip: Declare cortex-a7's irqchip to initialize gic from dt Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 9:37 ` [PATCH 08/27] pinctrl: exynos: Add driver data for Exynos3250 Chanwoo Choi
2014-04-10 9:37 ` Chanwoo Choi
2014-04-10 10:05 ` [PATCH 09/27] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-10 10:05 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 10/27] ARM: dts: exynos3250: Add new exynos3250.dtsi file Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-11 4:01 ` Sachin Kamat
2014-04-11 4:01 ` Sachin Kamat
2014-04-11 4:46 ` Chanwoo Choi
2014-04-11 4:46 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 11/27] ARM: dts: exynos3250: Add GIC dt node for Exynos3250 Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 12/27] ARM: dts: exynos3250: Add default interrupt-parent connected with GIC Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-11 4:00 ` Olof Johansson
2014-04-11 4:00 ` Olof Johansson
2014-04-11 4:44 ` Chanwoo Choi
2014-04-11 4:44 ` Chanwoo Choi
2014-04-11 4:44 ` Chanwoo Choi
2014-04-11 8:51 ` Tomasz Figa
2014-04-11 8:51 ` Tomasz Figa
2014-04-11 22:30 ` 최찬우
2014-04-11 22:30 ` 최찬우
2014-04-10 10:06 ` [PATCH 13/27] ARM: dts: exynos3250: Add pin control device tree data Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 14/27] ARM: dts: exynos3250: Add device tree nodes for clock controllers Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 15/27] ARM: dts: exynos3250: Add uart dt node to support seiral ports Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-11 4:03 ` Sachin Kamat
2014-04-11 4:03 ` Sachin Kamat
2014-04-11 4:50 ` Chanwoo Choi
2014-04-11 4:50 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 16/27] ARM: dts: exynos3250: Add MCT dt node Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 17/27] ARM: dts: exynos3250: Add ADC dt node to read analog raw data Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 18/27] ARM: dts: exynos3250: Add i2c dt node Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 19/27] ARM: dts: exynos3250: Add Mobile Storage Host Card Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 20/27] ARM: dts: exynos3250: Move definitions of external clocks to SoC dtsi Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 21/27] ARM: dts: exynos3250: Add PMU dt data Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:23 ` Chanho Park
2014-04-10 10:23 ` Chanho Park
2014-04-10 11:20 ` Chanwoo Choi
2014-04-10 11:20 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 22/27] ARM: dts: exynos3250: Add amba and pdma dt node Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 23/27] ARM: dts: exynos3250: Add spi dt node to support spi bus Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 24/27] ARM: dts: exynos3250: Add pwm dt node to support PWM Timer Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 25/27] ARM: dts: exynos3250: Add RTC dt node Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 26/27] ARM: dts: exynos3250: Add power domain dt nodes Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` [PATCH 27/27] ARM: dts: exynos3250: Add CPUs dt node for Exynos3250 Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
2014-04-10 10:06 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2014-04-10 9:28 [PATCH 00/27] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-10 9:28 ` [PATCH 01/27] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-10 9:28 ` Chanwoo Choi
2014-04-10 9:28 ` Chanwoo Choi
2014-04-10 9:43 ` Arnd Bergmann
2014-04-10 9:43 ` Arnd Bergmann
2014-04-10 9:43 ` Arnd Bergmann
2014-04-11 1:31 ` Chanwoo Choi
2014-04-11 1:31 ` Chanwoo Choi
2014-04-14 6:20 ` Chanwoo Choi
2014-04-14 6:20 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4735652.2Yh9suVdiT@wuerfel \
--to=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=hyunhee.kim@samsung.com \
--cc=inki.dae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sw0312.kim@samsung.com \
--cc=t.figa@samsung.com \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.