From: Bart Van Assche <bvanassche@acm.org>
To: Chris Boot <bootc@bootc.net>
Cc: Chuhong Yuan <hslester96@gmail.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sbp-target: add the missed kfree() in an error path
Date: Thu, 28 May 2020 07:53:34 -0700 [thread overview]
Message-ID: <475e4f50-6d20-d653-8288-0676bc708bcc@acm.org> (raw)
In-Reply-To: <20200528102056.911825-1-hslester96@gmail.com>
On 2020-05-28 03:20, Chuhong Yuan wrote:
> sbp_fetch_command() forgets to call kfree() in an error path.
> Add the missed call to fix it.
Hi Chris,
The changelog of the code under drivers/target/sbp makes we wonder
whether this driver has ever had any other users than its original
author. Do you agree with this? If so, do you want to keep this driver
in the kernel tree?
Thanks,
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Chris Boot <bootc@bootc.net>
Cc: Chuhong Yuan <hslester96@gmail.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sbp-target: add the missed kfree() in an error path
Date: Thu, 28 May 2020 14:53:34 +0000 [thread overview]
Message-ID: <475e4f50-6d20-d653-8288-0676bc708bcc@acm.org> (raw)
In-Reply-To: <20200528102056.911825-1-hslester96@gmail.com>
On 2020-05-28 03:20, Chuhong Yuan wrote:
> sbp_fetch_command() forgets to call kfree() in an error path.
> Add the missed call to fix it.
Hi Chris,
The changelog of the code under drivers/target/sbp makes we wonder
whether this driver has ever had any other users than its original
author. Do you agree with this? If so, do you want to keep this driver
in the kernel tree?
Thanks,
Bart.
next prev parent reply other threads:[~2020-05-28 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 10:20 [PATCH] sbp-target: add the missed kfree() in an error path Chuhong Yuan
2020-05-28 10:20 ` Chuhong Yuan
2020-05-28 14:53 ` Bart Van Assche [this message]
2020-05-28 14:53 ` Bart Van Assche
2020-05-28 15:16 ` Chris Boot
2020-05-28 15:16 ` Chris Boot
2020-06-03 1:01 ` Martin K. Petersen
2020-06-03 1:01 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475e4f50-6d20-d653-8288-0676bc708bcc@acm.org \
--to=bvanassche@acm.org \
--cc=bootc@bootc.net \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.