From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, "Michał Winiarski" <michal.winiarski@intel.com> Subject: Re: [Intel-gfx] [PATCH i-g-t v2 00/16] tests/core_hotunplug: Fixes and enhancements Date: Mon, 10 Aug 2020 11:33:13 +0200 [thread overview] Message-ID: <47a5070960dbcd4238e4cbf578c5166305d7632d.camel@linux.intel.com> (raw) In-Reply-To: <20200807092002.32350-1-janusz.krzysztofik@linux.intel.com> On Fri, 2020-08-07 at 11:19 +0200, Janusz Krzysztofik wrote: > Clean up the test code and unblock unbind variants. From the CI report it looks for me like driver (hot)unbind-rebind operations affect hardware and the driver doesn't handle this correctly. Moreover, the test doesn't currently detect this faulty condition and happily returns success. On the other hand, the hardware seems not stuck permanently, it looks like it just requires engines to be reset. Then, I'm going to extend the series with a more thorough health check and a more careful recovery. The unbind-rebind subtest shall report a failure as soon as it detects that engines require a reset, I believe, but igt_abort shall not be called unless the recovery phase fails. Thanks, Janusz > > @Michał: Since most v2 updates are trivial, I've preserved your > Reviewd-by: except for patch 11/16 "Follow failed subtests with health > checks" - please have a look and confirm if you are still OK with it. > > Thanks, > Janusz > > Janusz Krzysztofik (16): > tests/core_hotunplug: Use igt_assert_fd() > tests/core_hotunplug: Constify dev_bus_addr string > tests/core_hotunplug: Consolidate duplicated debug messages > tests/core_hotunplug: Assert successful device filter application > tests/core_hotunplug: Fix missing newline > tests/core_hotunplug: Maintain a single data structure instance > tests/core_hotunplug: Pass errors via a data structure field > tests/core_hotunplug: Handle device close errors > tests/core_hotunplug: Prepare invariant data once per test run > tests/core_hotunplug: Skip selectively on sysfs close errors > tests/core_hotunplug: Follow failed subtests with health checks > tests/core_hotunplug: Fail subtests on device close errors > tests/core_hotunplug: Process return values of sysfs operations > tests/core_hotunplug: Assert expected device presence/absence > tests/core_hotunplug: Explicitly ignore unused return values > tests/core_hotunplug: Un-blocklist *unbind* subtests > > tests/core_hotunplug.c | 334 +++++++++++++++++++++-------------- > tests/intel-ci/blacklist.txt | 2 +- > 2 files changed, 204 insertions(+), 132 deletions(-) > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, "Michał Winiarski" <michal.winiarski@intel.com>, "Petri Latvala" <petri.latvala@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v2 00/16] tests/core_hotunplug: Fixes and enhancements Date: Mon, 10 Aug 2020 11:33:13 +0200 [thread overview] Message-ID: <47a5070960dbcd4238e4cbf578c5166305d7632d.camel@linux.intel.com> (raw) In-Reply-To: <20200807092002.32350-1-janusz.krzysztofik@linux.intel.com> On Fri, 2020-08-07 at 11:19 +0200, Janusz Krzysztofik wrote: > Clean up the test code and unblock unbind variants. From the CI report it looks for me like driver (hot)unbind-rebind operations affect hardware and the driver doesn't handle this correctly. Moreover, the test doesn't currently detect this faulty condition and happily returns success. On the other hand, the hardware seems not stuck permanently, it looks like it just requires engines to be reset. Then, I'm going to extend the series with a more thorough health check and a more careful recovery. The unbind-rebind subtest shall report a failure as soon as it detects that engines require a reset, I believe, but igt_abort shall not be called unless the recovery phase fails. Thanks, Janusz > > @Michał: Since most v2 updates are trivial, I've preserved your > Reviewd-by: except for patch 11/16 "Follow failed subtests with health > checks" - please have a look and confirm if you are still OK with it. > > Thanks, > Janusz > > Janusz Krzysztofik (16): > tests/core_hotunplug: Use igt_assert_fd() > tests/core_hotunplug: Constify dev_bus_addr string > tests/core_hotunplug: Consolidate duplicated debug messages > tests/core_hotunplug: Assert successful device filter application > tests/core_hotunplug: Fix missing newline > tests/core_hotunplug: Maintain a single data structure instance > tests/core_hotunplug: Pass errors via a data structure field > tests/core_hotunplug: Handle device close errors > tests/core_hotunplug: Prepare invariant data once per test run > tests/core_hotunplug: Skip selectively on sysfs close errors > tests/core_hotunplug: Follow failed subtests with health checks > tests/core_hotunplug: Fail subtests on device close errors > tests/core_hotunplug: Process return values of sysfs operations > tests/core_hotunplug: Assert expected device presence/absence > tests/core_hotunplug: Explicitly ignore unused return values > tests/core_hotunplug: Un-blocklist *unbind* subtests > > tests/core_hotunplug.c | 334 +++++++++++++++++++++-------------- > tests/intel-ci/blacklist.txt | 2 +- > 2 files changed, 204 insertions(+), 132 deletions(-) > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-08-10 9:33 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-07 9:19 [Intel-gfx] [PATCH i-g-t v2 00/16] tests/core_hotunplug: Fixes and enhancements Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 01/16] tests/core_hotunplug: Use igt_assert_fd() Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 02/16] tests/core_hotunplug: Constify dev_bus_addr string Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 03/16] tests/core_hotunplug: Consolidate duplicated debug messages Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 04/16] tests/core_hotunplug: Assert successful device filter application Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 05/16] tests/core_hotunplug: Fix missing newline Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 06/16] tests/core_hotunplug: Maintain a single data structure instance Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 07/16] tests/core_hotunplug: Pass errors via a data structure field Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 08/16] tests/core_hotunplug: Handle device close errors Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 09/16] tests/core_hotunplug: Prepare invariant data once per test run Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 10/16] tests/core_hotunplug: Skip selectively on sysfs close errors Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 11/16] tests/core_hotunplug: Follow failed subtests with health checks Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 12/16] tests/core_hotunplug: Fail subtests on device close errors Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:19 ` [Intel-gfx] [PATCH i-g-t v2 13/16] tests/core_hotunplug: Process return values of sysfs operations Janusz Krzysztofik 2020-08-07 9:19 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:20 ` [Intel-gfx] [PATCH i-g-t v2 14/16] tests/core_hotunplug: Assert expected device presence/absence Janusz Krzysztofik 2020-08-07 9:20 ` [Intel-gfx] [PATCH i-g-t v2 15/16] tests/core_hotunplug: Explicitly ignore unused return values Janusz Krzysztofik 2020-08-07 9:20 ` [igt-dev] " Janusz Krzysztofik 2020-08-07 9:20 ` [Intel-gfx] [PATCH i-g-t 16/16] tests/core_hotunplug: Un-blocklist *unbind* subtests Janusz Krzysztofik 2020-08-07 11:53 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/core_hotunplug: Fixes and enhancements (rev2) Patchwork 2020-08-07 14:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2020-08-10 9:33 ` Janusz Krzysztofik [this message] 2020-08-10 9:33 ` [igt-dev] [PATCH i-g-t v2 00/16] tests/core_hotunplug: Fixes and enhancements Janusz Krzysztofik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=47a5070960dbcd4238e4cbf578c5166305d7632d.camel@linux.intel.com \ --to=janusz.krzysztofik@linux.intel.com \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=michal.winiarski@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.