From: "Moudy Ho (何宗原)" <Moudy.Ho@mediatek.com> To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: Re: [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes Date: Mon, 16 Jan 2023 09:14:38 +0000 [thread overview] Message-ID: <47f79e0ffda3fe72e574596aad8c4562a3b6e14a.camel@mediatek.com> (raw) In-Reply-To: <63f3d41a-1aa3-396a-b515-bc805f4a19b4@linaro.org> On Mon, 2023-01-16 at 09:11 +0100, Krzysztof Kozlowski wrote: > On 16/01/2023 04:21, Moudy Ho wrote: > > Add device nodes for Media Data Path 3 (MDP3) modules. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 420 > > +++++++++++++++++++++++ > > 1 file changed, 420 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > index 206dd534c3f6..d2d1ba71222d 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > @@ -1706,6 +1706,133 @@ > > #clock-cells = <1>; > > }; > > > > + mdp3-rdma0@14001000 { > > Node names should be generic. > https://urldefense.com/v3/__https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html*generic-names-recommendation__;Iw!!CTRNKA9wMg0ARbw!gmuIIk9pHTEGcVTtOXNeP3a8XUucoiTd5vTmxNK8lCHtytRDc3R8Eh44WOWNEUkJlv_pPCtg_DvPCHsCHNscg6_0cfJe$ > > > 0 is definitely not generic > > Isn't this dma-controller? or if not then just rdma? > > > + compatible = "mediatek,mt8195-mdp3-rdma"; > > + reg = <0 0x14001000 0 0x1000>; > > + mediatek,gce-client-reg = <&gce1 > > SUBSYS_1400XXXX 0x1000 0x1000>; > > + mediatek,gce-events = > > <CMDQ_EVENT_VPP0_MDP_RDMA_SOF>, > > + <CMDQ_EVENT_VPP0_MDP_RDMA > > _FRAME_DONE>; > > + power-domains = <&spm > > MT8195_POWER_DOMAIN_VPPSYS0>, > > + <&spm > > MT8195_POWER_DOMAIN_VPPSYS1>; > > + iommus = <&iommu_vpp M4U_PORT_L4_MDP_RDMA>, > > + <&iommu_vpp M4U_PORT_L4_MDP_WROT>; > > + clocks = <&vppsys0 CLK_VPP0_MDP_RDMA>, > > + <&topckgen CLK_TOP_CFG_VPP0>, > > + <&topckgen CLK_TOP_CFG_26M_VPP0>, > > + <&vppsys0 CLK_VPP0_WARP0_ASYNC_TX>, > > + <&vppsys0 CLK_VPP0_WARP0_RELAY>, > > + <&vppsys0 > > CLK_VPP0_WARP0_MDP_DL_ASYNC>, > > + <&vppsys0 CLK_VPP0_WARP1_ASYNC_TX>, > > + <&vppsys0 CLK_VPP0_WARP1_RELAY>, > > + <&vppsys0 > > CLK_VPP0_WARP1_MDP_DL_ASYNC>, > > + <&vppsys0 CLK_VPP0_VPP02VPP1_RELAY>, > > + <&vppsys1 CLK_VPP1_DL_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL_RELAY>, > > + <&vppsys0 CLK_VPP0_VPP12VPP0_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL1_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP2_VDO0_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP3_VDO1_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP2_VDO1_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP3_VDO0_DL_RELAY>; > > + mboxes = <&gce1 12 CMDQ_THR_PRIO_1>, > > + <&gce1 13 CMDQ_THR_PRIO_1>, > > + <&gce1 14 CMDQ_THR_PRIO_1>, > > + <&gce1 21 CMDQ_THR_PRIO_1>, > > + <&gce1 22 CMDQ_THR_PRIO_1>; > > + }; > > + > > + mdp3-fg0@14002000 { > > Node names should be generic. > https://urldefense.com/v3/__https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html*generic-names-recommendation__;Iw!!CTRNKA9wMg0ARbw!gmuIIk9pHTEGcVTtOXNeP3a8XUucoiTd5vTmxNK8lCHtytRDc3R8Eh44WOWNEUkJlv_pPCtg_DvPCHsCHNscg6_0cfJe$ > > > "0" suffix is definitely nothing generic. Drop such suffixes > everywhere. > Drop also "mdp3" prefix everywhere. > > > Best regards, > Krzysztof > Hi Krzysztof, May I uniformly name all MediaTek's media data path ver.3(MDP3) nodes as "mdp3@xxx"? Thanks & Regards, Moudy
WARNING: multiple messages have this Message-ID (diff)
From: "Moudy Ho (何宗原)" <Moudy.Ho@mediatek.com> To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>, "mchehab@kernel.org" <mchehab@kernel.org>, "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>, "linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: Re: [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes Date: Mon, 16 Jan 2023 09:14:38 +0000 [thread overview] Message-ID: <47f79e0ffda3fe72e574596aad8c4562a3b6e14a.camel@mediatek.com> (raw) In-Reply-To: <63f3d41a-1aa3-396a-b515-bc805f4a19b4@linaro.org> On Mon, 2023-01-16 at 09:11 +0100, Krzysztof Kozlowski wrote: > On 16/01/2023 04:21, Moudy Ho wrote: > > Add device nodes for Media Data Path 3 (MDP3) modules. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 420 > > +++++++++++++++++++++++ > > 1 file changed, 420 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > index 206dd534c3f6..d2d1ba71222d 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > > @@ -1706,6 +1706,133 @@ > > #clock-cells = <1>; > > }; > > > > + mdp3-rdma0@14001000 { > > Node names should be generic. > https://urldefense.com/v3/__https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html*generic-names-recommendation__;Iw!!CTRNKA9wMg0ARbw!gmuIIk9pHTEGcVTtOXNeP3a8XUucoiTd5vTmxNK8lCHtytRDc3R8Eh44WOWNEUkJlv_pPCtg_DvPCHsCHNscg6_0cfJe$ > > > 0 is definitely not generic > > Isn't this dma-controller? or if not then just rdma? > > > + compatible = "mediatek,mt8195-mdp3-rdma"; > > + reg = <0 0x14001000 0 0x1000>; > > + mediatek,gce-client-reg = <&gce1 > > SUBSYS_1400XXXX 0x1000 0x1000>; > > + mediatek,gce-events = > > <CMDQ_EVENT_VPP0_MDP_RDMA_SOF>, > > + <CMDQ_EVENT_VPP0_MDP_RDMA > > _FRAME_DONE>; > > + power-domains = <&spm > > MT8195_POWER_DOMAIN_VPPSYS0>, > > + <&spm > > MT8195_POWER_DOMAIN_VPPSYS1>; > > + iommus = <&iommu_vpp M4U_PORT_L4_MDP_RDMA>, > > + <&iommu_vpp M4U_PORT_L4_MDP_WROT>; > > + clocks = <&vppsys0 CLK_VPP0_MDP_RDMA>, > > + <&topckgen CLK_TOP_CFG_VPP0>, > > + <&topckgen CLK_TOP_CFG_26M_VPP0>, > > + <&vppsys0 CLK_VPP0_WARP0_ASYNC_TX>, > > + <&vppsys0 CLK_VPP0_WARP0_RELAY>, > > + <&vppsys0 > > CLK_VPP0_WARP0_MDP_DL_ASYNC>, > > + <&vppsys0 CLK_VPP0_WARP1_ASYNC_TX>, > > + <&vppsys0 CLK_VPP0_WARP1_RELAY>, > > + <&vppsys0 > > CLK_VPP0_WARP1_MDP_DL_ASYNC>, > > + <&vppsys0 CLK_VPP0_VPP02VPP1_RELAY>, > > + <&vppsys1 CLK_VPP1_DL_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL_RELAY>, > > + <&vppsys0 CLK_VPP0_VPP12VPP0_ASYNC>, > > + <&vppsys1 CLK_VPP1_VPP0_DL1_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP2_VDO0_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP3_VDO1_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP2_VDO1_DL_RELAY>, > > + <&vppsys1 > > CLK_VPP1_SVPP3_VDO0_DL_RELAY>; > > + mboxes = <&gce1 12 CMDQ_THR_PRIO_1>, > > + <&gce1 13 CMDQ_THR_PRIO_1>, > > + <&gce1 14 CMDQ_THR_PRIO_1>, > > + <&gce1 21 CMDQ_THR_PRIO_1>, > > + <&gce1 22 CMDQ_THR_PRIO_1>; > > + }; > > + > > + mdp3-fg0@14002000 { > > Node names should be generic. > https://urldefense.com/v3/__https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html*generic-names-recommendation__;Iw!!CTRNKA9wMg0ARbw!gmuIIk9pHTEGcVTtOXNeP3a8XUucoiTd5vTmxNK8lCHtytRDc3R8Eh44WOWNEUkJlv_pPCtg_DvPCHsCHNscg6_0cfJe$ > > > "0" suffix is definitely nothing generic. Drop such suffixes > everywhere. > Drop also "mdp3" prefix everywhere. > > > Best regards, > Krzysztof > Hi Krzysztof, May I uniformly name all MediaTek's media data path ver.3(MDP3) nodes as "mdp3@xxx"? Thanks & Regards, Moudy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-16 9:15 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-16 3:21 [RESEND v3 00/13] add support MDP3 on MT8195 platform Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 01/13] dt-binding: mediatek: add bindings for MediaTek mt8195 MDP3 components Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 8:10 ` Krzysztof Kozlowski 2023-01-16 8:10 ` Krzysztof Kozlowski 2023-01-16 9:39 ` Moudy Ho (何宗原) 2023-01-16 9:39 ` Moudy Ho (何宗原) 2023-01-16 10:01 ` Krzysztof Kozlowski 2023-01-16 10:01 ` Krzysztof Kozlowski 2023-01-18 8:52 ` Moudy Ho (何宗原) 2023-01-18 8:52 ` Moudy Ho (何宗原) 2023-01-18 12:47 ` Krzysztof Kozlowski 2023-01-18 12:47 ` Krzysztof Kozlowski 2023-01-16 3:21 ` [RESEND v3 02/13] arm64: dts: mediatek: mt8195: add MDP3 nodes Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 8:11 ` Krzysztof Kozlowski 2023-01-16 8:11 ` Krzysztof Kozlowski 2023-01-16 9:14 ` Moudy Ho (何宗原) [this message] 2023-01-16 9:14 ` Moudy Ho (何宗原) 2023-01-16 9:17 ` Krzysztof Kozlowski 2023-01-16 9:17 ` Krzysztof Kozlowski 2023-01-16 9:56 ` Moudy Ho (何宗原) 2023-01-16 9:56 ` Moudy Ho (何宗原) 2023-01-16 3:21 ` [RESEND v3 03/13] media: platform: mtk-mdp3: add support second sets of MMSYS Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 04/13] media: platform: mtk-mdp3: add support second sets of MUTEX Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 05/13] media: platform: mtk-mdp3: introduce more MDP3 components Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 06/13] media: platform: mtk-mdp3: add checks for dummy components Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 07/13] media: platform: mtk-mdp3: avoid multiple driver registrations Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 08/13] media: platform: mtk-mdp3: extend GCE event waiting in RDMA and WROT Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 09/13] media: platform: mtk-mdp3: add the blend of component in MUTEX MOD Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 10/13] media: platform: mtk-mdp3: add mt8195 platform configuration Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 11/13] media: platform: mtk-mdp3: add mt8195 shared memory configurations Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 12/13] media: platform: mtk-mdp3: add mt8195 MDP3 component settings Moudy Ho 2023-01-16 3:21 ` Moudy Ho 2023-01-16 3:21 ` [RESEND v3 13/13] media: platform: mtk-mdp3: add support for parallel pipe to improve FPS Moudy Ho 2023-01-16 3:21 ` Moudy Ho
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=47f79e0ffda3fe72e574596aad8c4562a3b6e14a.camel@mediatek.com \ --to=moudy.ho@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.