From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: peter.ujfalusi@ti.com, alsa-devel@alsa-project.org,
amistry@google.com, nartemiev@google.com,
Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Chuhong Yuan <hslester96@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence
Date: Tue, 6 Jul 2021 01:40:59 +0530 [thread overview]
Message-ID: <48b0a8e6-ca29-3f77-2689-ad7515f8743b@amd.com> (raw)
In-Reply-To: <20210705192952.GI4574@sirena.org.uk>
On 7/6/21 12:59 AM, Mark Brown wrote:
> On Tue, Jul 06, 2021 at 12:30:10AM +0530, Mukunda,Vijendar wrote:
>
>> As per our understanding by going with card wide option is easier rather
>> than checking dai link name for re-ordering the stop sequence for
>> specific platforms.
>> We will rename the flag as "stop_dma_fist" and will post the new version.
>
> Why would we need to check the name for the link? Presumably all
> affected AMD cards would just unconditionally set the flag, and other
> systems could do what they like?
>
This issue is only observed with older ACP2.x AMD platforms.
To make AMD specific platform change(which uses ACP 2.x IP), As per our
understanding we should only update the flag in ACP DMA driver by adding
flag in snd_pcm_substream structure rather than adding flag in card
structure.
Please suggest us, if there is any better place holder to add
"stop_dma_first" flag.
Due to some problem with mail client, i have received mail response
late. I have posted v2 version already.
Based on your suggestion, We will make the changes and post the new version.
WARNING: multiple messages have this Message-ID (diff)
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, Sunil-kumar.Dommati@amd.com,
amistry@google.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
open list <linux-kernel@vger.kernel.org>,
Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
Chuhong Yuan <hslester96@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
peter.ujfalusi@ti.com, Alexander.Deucher@amd.com,
nartemiev@google.com
Subject: Re: [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence
Date: Tue, 6 Jul 2021 01:40:59 +0530 [thread overview]
Message-ID: <48b0a8e6-ca29-3f77-2689-ad7515f8743b@amd.com> (raw)
In-Reply-To: <20210705192952.GI4574@sirena.org.uk>
On 7/6/21 12:59 AM, Mark Brown wrote:
> On Tue, Jul 06, 2021 at 12:30:10AM +0530, Mukunda,Vijendar wrote:
>
>> As per our understanding by going with card wide option is easier rather
>> than checking dai link name for re-ordering the stop sequence for
>> specific platforms.
>> We will rename the flag as "stop_dma_fist" and will post the new version.
>
> Why would we need to check the name for the link? Presumably all
> affected AMD cards would just unconditionally set the flag, and other
> systems could do what they like?
>
This issue is only observed with older ACP2.x AMD platforms.
To make AMD specific platform change(which uses ACP 2.x IP), As per our
understanding we should only update the flag in ACP DMA driver by adding
flag in snd_pcm_substream structure rather than adding flag in card
structure.
Please suggest us, if there is any better place holder to add
"stop_dma_first" flag.
Due to some problem with mail client, i have received mail response
late. I have posted v2 version already.
Based on your suggestion, We will make the changes and post the new version.
next prev parent reply other threads:[~2021-07-05 19:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 15:58 [PATCH] ASoC: add dai_reoder flag to reverse the stop sequence Vijendar Mukunda
2021-07-05 15:58 ` Vijendar Mukunda
2021-07-05 17:42 ` Mark Brown
2021-07-05 17:42 ` Mark Brown
2021-07-05 19:00 ` Mukunda,Vijendar
2021-07-05 19:00 ` Mukunda,Vijendar
2021-07-05 19:29 ` Mark Brown
2021-07-05 19:29 ` Mark Brown
2021-07-05 20:10 ` Mukunda,Vijendar [this message]
2021-07-05 20:10 ` Mukunda,Vijendar
2021-07-06 12:30 ` Mark Brown
2021-07-06 12:30 ` Mark Brown
2021-07-05 18:06 ` kernel test robot
2021-07-05 18:06 ` kernel test robot
2021-07-05 19:14 ` Mukunda,Vijendar
2021-07-05 19:14 ` Mukunda, Vijendar
2021-07-05 19:01 ` kernel test robot
2021-07-05 19:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b0a8e6-ca29-3f77-2689-ad7515f8743b@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=amistry@google.com \
--cc=broonie@kernel.org \
--cc=hslester96@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nartemiev@google.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.