Re: [PATCH v2 2/3] xen/arm: Add MESON UART driver for Amlogic Meson SoCs

From: Julien Grall <julien.grall@arm.com>
To: Amit Tomer <amittomer25@gmail.com>
Cc: "André Przywara" <andre.przywara@arm.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 2/3] xen/arm: Add MESON UART driver for Amlogic Meson SoCs
Date: Tue, 9 Apr 2019 11:14:35 +0100	[thread overview]
Message-ID: <48bd9982-2569-4a43-ee34-22eaf7a16f24@arm.com> (raw)
In-Reply-To: <CABHD4K8R7wyA=yGdfdVvsb21Ewyb3buAbhTCsJVuFuLNvGqV6A@mail.gmail.com>

On 09/04/2019 11:09, Amit Tomer wrote:
> Hello,
> 
> On Tue, Apr 9, 2019 at 3:09 PM Julien Grall <julien.grall@arm.com> wrote:
>>
>> Hi,
>>
>> On 02/04/2019 21:01, André Przywara wrote:
>>> On 21/03/2019 10:25, Amit Singh Tomar wrote:
>>>> This patch adds driver for UART controller present on Amlogic Meson
>>>> SoCs and it has been tested on Nanopi K2 board based on S905 SoC.
>>>>
>>>> Controller registers defination is taken from Linux 4.20.
>>>> https://github.com/torvalds/linux/blob/v4.20-rc1/drivers/tty/serial/meson_uart.c
>>>>
>>>> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
>>>
>>> Thanks for the changes!
>>>
>>> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>
>> Acked-by: Julien Grall <julien.grall@arm.com>
> 
> Thanks.
> 
>> I have committed this patch and the following patch. Please resend the first
>> patch with the comments addressed.
> 
> Is it the patch with following subject:
> [PATCH v2 1/3] xen/arm: Add Amlogic Meson SoCs earlyprintk support
> 
> Really, couldn't find any comments over there.

See https://lists.xenproject.org/archives/html/xen-devel/2019-04/msg00145.html

I pointed two issues:
	1) The lack of cover letter
	2) The lack of commit message

1) does not need to be addressed for this series, but should be for any new 
series you send with more than 1 patch.

2) should be addressed before I will commit the patch. The exact issue were 
already described in version 1 (see [1]).

Cheers,

[1] https://lists.xenproject.org/archives/html/xen-devel/2019-02/msg01204.html

> 
> -Amit.
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel