From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Vincent Chen <vincent.chen@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-kselftest <linux-kselftest@vger.kernel.org>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH V2 3/3] rseq/selftests: Add support for riscv
Date: Thu, 26 Mar 2020 12:17:06 -0400 (EDT) [thread overview]
Message-ID: <490218026.13345.1585239426829.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <mhng-e1457171-db30-49be-9e98-298f4d1453ed@palmerdabbelt-glaptop1>
----- On Mar 26, 2020, at 11:49 AM, Palmer Dabbelt palmer@dabbelt.com wrote:
> On Sun, 08 Mar 2020 22:59:52 PDT (-0700), vincent.chen@sifive.com wrote:
>> Add support for risc-v in the rseq selftests, which covers both
>> 64-bit and 32-bit ISA with little endian mode.
>>
>> Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
>> ---
>> tools/testing/selftests/rseq/param_test.c | 23 ++
>> tools/testing/selftests/rseq/rseq-riscv.h | 622 ++++++++++++++++++++++++++++++
>> tools/testing/selftests/rseq/rseq.h | 2 +
>> 3 files changed, 647 insertions(+)
>> create mode 100644 tools/testing/selftests/rseq/rseq-riscv.h
>
> There are a ton of checkpatch errors in here.
Is it just my mail client or the main issue is:
ERROR: DOS line endings
?
As far as other issues are concerned, I know there are a few checkpatch
false-positives that trigger for my rseq-{$ARCH}.h header, from which rseq-riscv.h
is derived, because it has issues with extensive use of inline assembly.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Vincent Chen <vincent.chen@sifive.com>,
linux-riscv@lists.infradead.org,
linux-kselftest <linux-kselftest@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH V2 3/3] rseq/selftests: Add support for riscv
Date: Thu, 26 Mar 2020 12:17:06 -0400 (EDT) [thread overview]
Message-ID: <490218026.13345.1585239426829.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <mhng-e1457171-db30-49be-9e98-298f4d1453ed@palmerdabbelt-glaptop1>
----- On Mar 26, 2020, at 11:49 AM, Palmer Dabbelt palmer@dabbelt.com wrote:
> On Sun, 08 Mar 2020 22:59:52 PDT (-0700), vincent.chen@sifive.com wrote:
>> Add support for risc-v in the rseq selftests, which covers both
>> 64-bit and 32-bit ISA with little endian mode.
>>
>> Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
>> ---
>> tools/testing/selftests/rseq/param_test.c | 23 ++
>> tools/testing/selftests/rseq/rseq-riscv.h | 622 ++++++++++++++++++++++++++++++
>> tools/testing/selftests/rseq/rseq.h | 2 +
>> 3 files changed, 647 insertions(+)
>> create mode 100644 tools/testing/selftests/rseq/rseq-riscv.h
>
> There are a ton of checkpatch errors in here.
Is it just my mail client or the main issue is:
ERROR: DOS line endings
?
As far as other issues are concerned, I know there are a few checkpatch
false-positives that trigger for my rseq-{$ARCH}.h header, from which rseq-riscv.h
is derived, because it has issues with extensive use of inline assembly.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2020-03-26 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 5:59 [PATCH V2 0/3] riscv: add support for restartable sequence Vincent Chen
2020-03-09 5:59 ` Vincent Chen
2020-03-09 5:59 ` [PATCH V2 1/3] riscv: add required functions to enable HAVE_REGS_AND_STACK_ACCESS_API Vincent Chen
2020-03-09 5:59 ` Vincent Chen
2020-03-09 5:59 ` [PATCH V2 2/3] riscv: Add support for restartable sequence Vincent Chen
2020-03-09 5:59 ` Vincent Chen
2021-07-19 14:43 ` Mathieu Desnoyers
2021-07-19 14:43 ` Mathieu Desnoyers
2021-07-21 3:19 ` Vincent Chen
2021-07-21 3:19 ` Vincent Chen
2020-03-09 5:59 ` [PATCH V2 3/3] rseq/selftests: Add support for riscv Vincent Chen
2020-03-09 5:59 ` Vincent Chen
2020-03-26 15:49 ` Palmer Dabbelt
2020-03-26 15:49 ` Palmer Dabbelt
2020-03-26 16:17 ` Mathieu Desnoyers [this message]
2020-03-26 16:17 ` Mathieu Desnoyers
2020-03-27 8:33 ` Vincent Chen
2020-03-27 8:33 ` Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490218026.13345.1585239426829.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.