From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-mm@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] slab: fix slab flags for archs use alignment larger
Date: Fri, 13 Feb 2009 10:16:00 +0000 [thread overview]
Message-ID: <4995565D.5010105@st.com> (raw)
In-Reply-To: <84144f020902130205x4dc5886l70fe6a695ef050a4@mail.gmail.com>
Pekka Enberg wrote:
> Hi Giuseppe,
>
> On Fri, Feb 13, 2009 at 12:46 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>
>> 1) LOG with my patch:
>> root@linux:~# cat /proc/meminfo | grep Slab
>> Slab: 2612 kB
>>
>> 2) LOG without my patch:
>> root@linux:~# cat /proc/meminfo | grep Slab
>> Slab: 2504 kB
>>
>
> That's not too bad. I assume it's L1_CACHE_BYTES set to 32 bytes?
you are perfectly right.
> One big problem with your patch is that on some MIPS configurations
> ARCH_KMALLOC_MINALIGN is as big as 128.
Agree again and problem understood... thanks!
> So if you're going to do this, you can't use ARCH_KMALLOC_MINALIGN directly but add a some
> SLAB_MAX_DEBUG_ALIGN which can be overridden by architecture code.
>
If you like, I can prepare a patch in any case.
Then we can decide if it actually adds complexity and discard it.
Otherwise we could maintain it.
> One obvious question, though, is whether all this is worth the added
> complexity. I mean, we've managed "just fine" without it for years.
> Paul, thoughts?
>
> Pekka
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-mm@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH] slab: fix slab flags for archs use alignment larger 64-bit
Date: Fri, 13 Feb 2009 12:15:41 +0100 [thread overview]
Message-ID: <4995565D.5010105@st.com> (raw)
In-Reply-To: <84144f020902130205x4dc5886l70fe6a695ef050a4@mail.gmail.com>
Pekka Enberg wrote:
> Hi Giuseppe,
>
> On Fri, Feb 13, 2009 at 12:46 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>
>> 1) LOG with my patch:
>> root@linux:~# cat /proc/meminfo | grep Slab
>> Slab: 2612 kB
>>
>> 2) LOG without my patch:
>> root@linux:~# cat /proc/meminfo | grep Slab
>> Slab: 2504 kB
>>
>
> That's not too bad. I assume it's L1_CACHE_BYTES set to 32 bytes?
you are perfectly right.
> One big problem with your patch is that on some MIPS configurations
> ARCH_KMALLOC_MINALIGN is as big as 128.
Agree again and problem understood... thanks!
> So if you're going to do this, you can't use ARCH_KMALLOC_MINALIGN directly but add a some
> SLAB_MAX_DEBUG_ALIGN which can be overridden by architecture code.
>
If you like, I can prepare a patch in any case.
Then we can decide if it actually adds complexity and discard it.
Otherwise we could maintain it.
> One obvious question, though, is whether all this is worth the added
> complexity. I mean, we've managed "just fine" without it for years.
> Paul, thoughts?
>
> Pekka
>
>
next prev parent reply other threads:[~2009-02-13 10:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 17:51 [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-12 18:56 ` Paul Mundt
2009-02-12 18:56 ` Paul Mundt
2009-02-13 9:00 ` Giuseppe CAVALLARO
2009-02-13 10:00 ` Giuseppe CAVALLARO
2009-02-13 9:22 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 9:22 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 9:30 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 9:30 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 9:30 ` Pekka Enberg
2009-02-13 9:47 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-13 10:46 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-13 10:05 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 10:05 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-13 10:16 ` Giuseppe CAVALLARO [this message]
2009-02-13 11:15 ` Giuseppe CAVALLARO
2009-02-13 13:11 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-13 14:11 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
2009-02-13 13:41 ` [PATCH] slab: fix slab flags for archs use alignment larger Pekka Enberg
2009-02-13 13:41 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Pekka Enberg
2009-02-18 8:31 ` [PATCH] slab: fix slab flags for archs use alignment larger Giuseppe CAVALLARO
2009-02-18 9:30 ` [PATCH] slab: fix slab flags for archs use alignment larger 64-bit Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4995565D.5010105@st.com \
--to=peppe.cavallaro@st.com \
--cc=cl@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.