From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>,
Kyle McMartin <kyle@mcmartin.ca>,
rtc-linux@googlegroups.com, linux-parisc@vger.kernel.org,
linuxppc-dev@ozlabs.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>,
Dann Frazier <dannf@dannf.org>
Subject: Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3
Date: Mon, 9 Mar 2009 11:35:58 -0700 [thread overview]
Message-ID: <49B5618E.9050501@am.sony.com> (raw)
In-Reply-To: <1236605183-22718-8-git-send-email-Geert.Uytterhoeven@sonycom.com>
On 03/09/2009 06:26 AM, Geert Uytterhoeven wrote:
> Create a real RTC driver for PS3, and unhook the deprecated
> ppc_md.[gs]et_rtc_time.
> 8 files changed, 132 insertions(+), 18 deletions(-)
Sorry, I hadn't been following the discussion closely, but
could you explain why we are going from a generic framework
where we hook in our platform specific part to a totally
independent driver that has such an increase in code size.
Why couldn't you fix the generic part so that udev could
load it automatically?
I much prefer to have this code in the platform support
code as it was. It is much more effort (a pain) to maintain
a separate driver were I have to cater to a subsystem's
maintainer, and with this rtc it seems everyone who was
using the generic PPC driver will need to do the same.
-Geoff
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linux-m68k@vger.kernel.org,
Alessandro Zummo <alessandro.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, Kyle McMartin <kyle@mcmartin.ca>,
linuxppc-dev@ozlabs.org, Paul Mundt <lethal@linux-sh.org>,
Dann Frazier <dannf@dannf.org>
Subject: Re: [PATCH 7/7] powerpc/ps3: Add rtc-ps3
Date: Mon, 9 Mar 2009 11:35:58 -0700 [thread overview]
Message-ID: <49B5618E.9050501@am.sony.com> (raw)
In-Reply-To: <1236605183-22718-8-git-send-email-Geert.Uytterhoeven@sonycom.com>
On 03/09/2009 06:26 AM, Geert Uytterhoeven wrote:
> Create a real RTC driver for PS3, and unhook the deprecated
> ppc_md.[gs]et_rtc_time.
> 8 files changed, 132 insertions(+), 18 deletions(-)
Sorry, I hadn't been following the discussion closely, but
could you explain why we are going from a generic framework
where we hook in our platform specific part to a totally
independent driver that has such an increase in code size.
Why couldn't you fix the generic part so that udev could
load it automatically?
I much prefer to have this code in the platform support
code as it was. It is much more effort (a pain) to maintain
a separate driver were I have to cater to a subsystem's
maintainer, and with this rtc it seems everyone who was
using the generic PPC driver will need to do the same.
-Geoff
next prev parent reply other threads:[~2009-03-09 18:35 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 13:26 [PATCH 0/7] Generic RTC class driver Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 1/7] parisc: rtc: get_rtc_time() returns unsigned int Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 2/7] parisc: rtc: platform_driver_probe() fixups Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 3/7] parisc: rtc: Add missing module alias Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 4/7] parisc: rtc: Rename rtc-parisc to rtc-generic Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 5/7] m68k: Hook up rtc-generic Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 6/7] powerpc: Hook up rtc-generic, and kill rtc-ppc Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 7/7] powerpc/ps3: Add rtc-ps3 Geert Uytterhoeven
2009-03-09 13:26 ` Geert Uytterhoeven
2009-03-09 14:12 ` [rtc-linux] " Alessandro Zummo
2009-03-09 14:12 ` Alessandro Zummo
2009-03-09 15:24 ` Geert Uytterhoeven
2009-03-09 15:24 ` Geert Uytterhoeven
2009-03-09 15:24 ` Geert Uytterhoeven
2009-03-09 15:24 ` Geert Uytterhoeven
2009-03-09 18:04 ` Geoff Levand
2009-03-09 18:04 ` Geoff Levand
2009-03-09 18:43 ` [rtc-linux] " Alessandro Zummo
2009-03-09 18:43 ` Alessandro Zummo
2009-03-09 19:06 ` Geoff Levand
2009-03-09 19:06 ` Geoff Levand
2009-03-09 19:18 ` Joe Perches
2009-03-09 19:18 ` Joe Perches
2009-03-09 18:35 ` Geoff Levand [this message]
2009-03-09 18:35 ` Geoff Levand
2009-03-10 9:21 ` Geert Uytterhoeven
2009-03-10 9:21 ` Geert Uytterhoeven
2009-03-10 9:21 ` Geert Uytterhoeven
2009-03-10 9:39 ` [rtc-linux] " Alessandro Zummo
2009-03-10 9:39 ` Alessandro Zummo
2009-03-10 16:18 ` Geoff Levand
2009-03-10 16:18 ` Geoff Levand
2009-03-09 13:59 ` [PATCH 6/7] powerpc: Hook up rtc-generic, and kill rtc-ppc David Woodhouse
2009-03-09 13:59 ` David Woodhouse
2009-03-11 4:15 ` Benjamin Herrenschmidt
2009-03-11 4:15 ` Benjamin Herrenschmidt
2009-03-16 13:09 ` [PATCH 4/7] parisc: rtc: Rename rtc-parisc to rtc-generic Christoph Hellwig
2009-03-16 13:09 ` Christoph Hellwig
2009-03-09 14:14 ` [rtc-linux] [PATCH 0/7] Generic RTC class driver Alessandro Zummo
2009-03-09 14:14 ` Alessandro Zummo
2009-03-09 15:46 ` Paul Mundt
2009-03-09 15:46 ` Paul Mundt
2009-03-11 10:36 ` Geert Uytterhoeven
2009-03-11 10:36 ` Geert Uytterhoeven
2009-03-11 10:36 ` Geert Uytterhoeven
2009-03-11 10:36 ` Geert Uytterhoeven
2009-03-11 15:45 ` Kyle McMartin
2009-03-11 15:45 ` Kyle McMartin
2009-03-11 17:26 ` Geert Uytterhoeven
2009-03-11 17:26 ` Geert Uytterhoeven
2009-03-11 17:26 ` Geert Uytterhoeven
2009-03-13 4:25 ` Kyle McMartin
2009-03-13 4:25 ` Kyle McMartin
2009-04-02 9:42 ` Geert Uytterhoeven
2009-04-02 9:42 ` Geert Uytterhoeven
2009-04-02 9:42 ` Geert Uytterhoeven
2009-04-02 9:42 ` Geert Uytterhoeven
2009-04-02 13:56 ` Kyle McMartin
2009-04-02 13:56 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B5618E.9050501@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=alessandro.zummo@towertech.it \
--cc=dannf@dannf.org \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.