Re: [PATCH 05/17] Stop/start cpus before/after devices

From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, Glauber Costa <glommer@gmail.com>,
	Yaniv Kamay <yaniv@redhat.com>
Subject: Re: [PATCH 05/17] Stop/start cpus before/after devices
Date: Mon, 18 May 2009 17:46:42 +0300	[thread overview]
Message-ID: <4A1174D2.20408@redhat.com> (raw)
In-Reply-To: <4A117017.400@us.ibm.com>

Anthony Liguori wrote:
> Marcelo Tosatti wrote:
>> On Sun, May 17, 2009 at 07:59:51PM +0300, Avi Kivity wrote:
>>  
>>> Anthony Liguori wrote:
>>>    
>>>> From: Yaniv Kamay <yaniv@qumranet.com>
>>>>
>>>> Stop cpus before devices when stopping the VM, start cpus after 
>>>> devices
>>>> when starting VM.  Otherwise a vcpu could access a stopped device.
>>>>
>>>>         
>>> IIRC we decided this was unnecessary since everything is under  
>>> qemu_mutex.  However we might want to be on the safe side here and 
>>> be  similar to master.
>>>     
>>
>> Yes, it is not necessary. Since upstream is already on the safe side
>> (and the plan is to merge with it), IMO better leave this patch out.
>>   
>
> Maybe it ought to be reverted from master then?
>

Yes.  I'll do that.

-- 
error compiling committee.c: too many arguments to function