Re: [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6

From: Rafi Rubin <rafi@seas.upenn.edu>
To: mickib1@gmail.com
Cc: jkosina@suse.cz, chatty@enac.fr, peterhuewe@gmx.de,
	micki@n-trig.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafi@seas.upenn.edu
Subject: Re: [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6
Date: Mon, 08 Mar 2010 20:20:13 -0500	[thread overview]
Message-ID: <4B95A24D.2090903@seas.upenn.edu> (raw)
In-Reply-To: <1268082827-2680-6-git-send-email-micki@n-trig.com>

>   static const struct hid_device_id ntrig_devices[] = {
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN),
> -		.driver_data = NTRIG_DUPLICATE_USAGES },
> +		.driver_data = NTRIG_USB_DEVICE_ID },

The vendor and device id are in the first field "HID_USB_DEVICE", driver 
data is for flags, not id.  Its merely a coincidence that they are the 
same in this case.

The duplicate usages tells hid to let you have more than one "x" and "y" 
axis.  Otherwise each finger gets a new set (the second finger gets "z" 
and "rx" and so on).

>   static int __init ntrig_init(void)
>   {
> +	info("N-trig Driver Version 1.6\n");

Perhaps you mean:
MODULE_VERSION("1.06");