From: "Stéphane Chatty" <chatty@enac.fr>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: mickib1@gmail.com, Jiri Kosina <jkosina@suse.cz>,
peterhuewe@gmx.de, Micki Balanga <micki@n-trig.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2
Date: Tue, 9 Mar 2010 16:43:08 +0100 [thread overview]
Message-ID: <AC7EBCFD-B650-4B58-B12A-13D20F56E7FF@enac.fr> (raw)
In-Reply-To: <4B959F3C.3020701@seas.upenn.edu>
Le 9 mars 10 à 02:07, Rafi Rubin a écrit :
>
>> case HID_DG_HEIGHT:
>> hid_map_usage(hi, usage, bit, max,
>> EV_ABS, ABS_MT_TOUCH_MINOR);
>> - input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
>> - 0, 1, 0, 0);
>
> Stephane added the orientation to height, I can't comment about the
> wisdom of pulling it.
The MT kernel protocol says that width/height is reported through
TouchMinor/TouchMajor/Orientation. Orientation needs to be added
somewhere. Doing it when encountering width or height seemed a
logical thing to do, but I would see no objection at doing it
somewhere else with TouchMinor and TouchMajor.
Cheers,
St.
WARNING: multiple messages have this Message-ID (diff)
From: "Stéphane Chatty" <chatty@enac.fr>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: mickib1@gmail.com, Jiri Kosina <jkosina@suse.cz>,
peterhuewe@gmx.de, Micki Balanga <micki@n-trig.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2
Date: Tue, 9 Mar 2010 16:43:08 +0100 [thread overview]
Message-ID: <AC7EBCFD-B650-4B58-B12A-13D20F56E7FF@enac.fr> (raw)
In-Reply-To: <4B959F3C.3020701@seas.upenn.edu>
Le 9 mars 10 à 02:07, Rafi Rubin a écrit :
>
>> case HID_DG_HEIGHT:
>> hid_map_usage(hi, usage, bit, max,
>> EV_ABS, ABS_MT_TOUCH_MINOR);
>> - input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
>> - 0, 1, 0, 0);
>
> Stephane added the orientation to height, I can't comment about the
> wisdom of pulling it.
The MT kernel protocol says that width/height is reported through
TouchMinor/TouchMajor/Orientation. Orientation needs to be added
somewhere. Doing it when encountering width or height seemed a
logical thing to do, but I would see no objection at doing it
somewhere else with TouchMinor and TouchMajor.
Cheers,
St.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-09 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:13 [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 mickib1
2010-03-08 21:13 ` mickib1
2010-03-08 21:13 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 mickib1
2010-03-08 21:13 ` [PATCH 3/7] HID: N-trig MTM Driver fix And cleanup patch 3 mickib1
2010-03-08 21:13 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 mickib1
2010-03-08 21:13 ` mickib1
2010-03-08 21:13 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 mickib1
2010-03-08 21:13 ` mickib1
2010-03-08 21:13 ` [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6 mickib1
2010-03-08 21:13 ` mickib1
2010-03-09 1:20 ` Rafi Rubin
2010-03-09 10:15 ` Jiri Kosina
2010-03-09 1:29 ` [PATCH 5/7] HID: N-trig MTM Driver fix And cleanup patch 5 Rafi Rubin
2010-03-09 1:10 ` [PATCH 4/7] HID: N-trig MTM Driver fix And cleanup Patch 4 Rafi Rubin
2010-03-09 1:07 ` [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2 Rafi Rubin
2010-03-09 15:43 ` Stéphane Chatty [this message]
2010-03-09 15:43 ` Stéphane Chatty
2010-03-09 0:34 ` [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1 Rafi Rubin
2010-03-09 0:50 ` Rafi Rubin
2010-03-09 10:11 ` Jiri Kosina
2010-03-09 8:43 ` Dmitry Torokhov
2010-03-09 8:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AC7EBCFD-B650-4B58-B12A-13D20F56E7FF@enac.fr \
--to=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=mickib1@gmail.com \
--cc=peterhuewe@gmx.de \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.