From: Sergei Shtylyov <sshtylyov@mvista.com> To: srinath@mistralsolutions.com Cc: linux-omap@vger.kernel.org, nm@ti.com, linux@arm.linux.org.uk, umeshk@mistralsolutions.com, tony@atomide.com, nagendra@mistralsolutions.com, linux-kernel@vger.kernel.org, khilman@deeprootsystems.com, jdk@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [Patch v1] AM35xx: Craneboard: Add USB EHCI support Date: Sat, 20 Nov 2010 14:39:11 +0300 [thread overview] Message-ID: <4CE7B35F.6000704@ru.mvista.com> (raw) In-Reply-To: <1290182862-21837-1-git-send-email-srinath@mistralsolutions.com> Hello. On 19-11-2010 19:07, srinath@mistralsolutions.com wrote: > From: Srinath<srinath@mistralsolutions.com> > AM3517/05 Craneboard has one EHCI interface on board using port1. > GPIO35 is used as power enable. > GPIO38 is used as port1 PHY reset. > Signed-off-by: Srinath<srinath@mistralsolutions.com> > --- > arch/arm/mach-omap2/board-am3517crane.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c > index 13ead33..0e1a806 100644 > --- a/arch/arm/mach-omap2/board-am3517crane.c > +++ b/arch/arm/mach-omap2/board-am3517crane.c [...] > @@ -53,10 +55,29 @@ static void __init am3517_crane_init_irq(void) > omap_gpio_init(); > } > > +static struct ehci_hcd_omap_platform_data ehci_pdata __initdata = { > + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY, > + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + > + .phy_reset = true, > + .reset_gpio_port[0] = 38, > + .reset_gpio_port[1] = -EINVAL, > + .reset_gpio_port[2] = -EINVAL > +}; > + > static void __init am3517_crane_init(void) > { > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap_serial_init(); > + > + /* Configure GPIO for EHCI port */ > + omap_mux_init_gpio(35, OMAP_PIN_OUTPUT); > + gpio_request(35, "usb_ehci_enable"); > + gpio_direction_output(35, 1); > + gpio_set_value(35, 1); There's no need to call gpio_set_value(), as gpio_direction_output() has already set the GPIO's value. WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov) To: linux-arm-kernel@lists.infradead.org Subject: [Patch v1] AM35xx: Craneboard: Add USB EHCI support Date: Sat, 20 Nov 2010 14:39:11 +0300 [thread overview] Message-ID: <4CE7B35F.6000704@ru.mvista.com> (raw) In-Reply-To: <1290182862-21837-1-git-send-email-srinath@mistralsolutions.com> Hello. On 19-11-2010 19:07, srinath at mistralsolutions.com wrote: > From: Srinath<srinath@mistralsolutions.com> > AM3517/05 Craneboard has one EHCI interface on board using port1. > GPIO35 is used as power enable. > GPIO38 is used as port1 PHY reset. > Signed-off-by: Srinath<srinath@mistralsolutions.com> > --- > arch/arm/mach-omap2/board-am3517crane.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > diff --git a/arch/arm/mach-omap2/board-am3517crane.c b/arch/arm/mach-omap2/board-am3517crane.c > index 13ead33..0e1a806 100644 > --- a/arch/arm/mach-omap2/board-am3517crane.c > +++ b/arch/arm/mach-omap2/board-am3517crane.c [...] > @@ -53,10 +55,29 @@ static void __init am3517_crane_init_irq(void) > omap_gpio_init(); > } > > +static struct ehci_hcd_omap_platform_data ehci_pdata __initdata = { > + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY, > + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN, > + > + .phy_reset = true, > + .reset_gpio_port[0] = 38, > + .reset_gpio_port[1] = -EINVAL, > + .reset_gpio_port[2] = -EINVAL > +}; > + > static void __init am3517_crane_init(void) > { > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap_serial_init(); > + > + /* Configure GPIO for EHCI port */ > + omap_mux_init_gpio(35, OMAP_PIN_OUTPUT); > + gpio_request(35, "usb_ehci_enable"); > + gpio_direction_output(35, 1); > + gpio_set_value(35, 1); There's no need to call gpio_set_value(), as gpio_direction_output() has already set the GPIO's value. WBR, Sergei
next prev parent reply other threads:[~2010-11-20 11:41 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <[PATCH] AM35xx-Craneboard-Add-USB-EHCI-support> 2010-11-19 16:07 ` [Patch v1] AM35xx: Craneboard: Add USB EHCI support srinath 2010-11-19 16:07 ` srinath at mistralsolutions.com 2010-11-19 16:59 ` Igor Grinberg 2010-11-19 16:59 ` Igor Grinberg 2010-11-20 11:39 ` Sergei Shtylyov [this message] 2010-11-20 11:39 ` Sergei Shtylyov 2010-11-22 8:55 ` Srinath R 2010-11-22 8:55 ` Srinath R 2010-11-22 8:55 ` Srinath R 2010-11-22 8:32 ` [Patch v2] " srinath 2010-11-22 8:32 ` srinath at mistralsolutions.com 2010-11-22 17:56 ` Kevin Hilman 2010-11-22 17:56 ` Kevin Hilman 2010-12-16 15:25 ` [Patch v4] " srinath 2010-12-16 15:25 ` srinath at mistralsolutions.com 2010-12-17 6:22 ` Felipe Balbi 2010-12-17 6:22 ` Felipe Balbi 2010-12-17 12:45 ` Sergei Shtylyov 2010-12-17 12:45 ` Sergei Shtylyov 2010-12-20 13:08 ` [Patch v5] " srinath 2010-12-20 13:08 ` srinath at mistralsolutions.com 2010-12-21 6:58 ` Felipe Balbi 2010-12-21 6:58 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4CE7B35F.6000704@ru.mvista.com \ --to=sshtylyov@mvista.com \ --cc=jdk@ti.com \ --cc=khilman@deeprootsystems.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=nagendra@mistralsolutions.com \ --cc=nm@ti.com \ --cc=srinath@mistralsolutions.com \ --cc=tony@atomide.com \ --cc=umeshk@mistralsolutions.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.