From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Finn Thain <fthain@telegraphics.com.au>,
devel@driverdev.osuosl.org, trivial@kernel.org,
linux-scsi@vger.kernel.org, netdev@vger.kernel.orglinux-
Subject: Re: [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h Typo change diable to disable.
Date: Sat, 01 Jan 2011 06:53:34 -0800 [thread overview]
Message-ID: <4D1F3FEE.7__44888.2512785078$1293893622$gmane$org@gmail.com> (raw)
In-Reply-To: <20110101090931.GH1886@bicker>
On 01/01/2011 01:09 AM, Dan Carpenter wrote:
> On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote:
>> On 12/31/2010 10:48 PM, Finn Thain wrote:
>>>> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */
>>>> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */
>>>
>>> I think, "other values disable" was what you meant?
>>>
>>> Finn
>>>
>>>> #define EEPROM_SW_AD_MASK 0x0300
>>>> #define EEPROM_SW_AD_ENABLE 0x0100
>>>>
>>>>
>>>
>>
>> no! I changed it to disabled to make it proper..
>
> Finn is obviously right, but maybe a compromise would be:
>
> Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean
> "disable".
>
> regards,
> dan carpenter
>
ahh.. I see what you your saying now.. alright let me send this out that
way..
Justin P. Mattock
next prev parent reply other threads:[~2011-01-01 14:53 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 23:07 [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 02/15]drivers:spi:dw_spi.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 04/15]drivers:staging:comedi:drivers:das800.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 05/15]drivers:staging:vt6655:rf.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 06/15]drivers:staging:xgifb:vb_setmode.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 07/15]drivers:net:wireless:iwlwifi " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 09/15]drivers:usb:host " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 10/15]drivers:usb:gadget:langwell " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:08 ` [PATCH 11/15]drivers:media:video:cx18:cx23418.h " Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` [PATCH 12/15]drivers:media:video:tvp7002.c " Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` [PATCH 13/15]drivers:isdn:mISDN:dsp_cmx.c " Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` [PATCH 14/15]include:media:davinci:vpss.h " Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` [PATCH 15/15]drivers:spi:dw_spi.c " Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-30 23:08 ` Justin P. Mattock
2010-12-31 6:34 ` Dan Carpenter
2010-12-31 6:34 ` Dan Carpenter
2010-12-31 6:34 ` Dan Carpenter
2010-12-31 6:38 ` Justin P. Mattock
2010-12-31 6:38 ` Justin P. Mattock
2010-12-31 6:38 ` Justin P. Mattock
2010-12-31 6:38 ` Justin P. Mattock
2010-12-31 10:27 ` [PATCH 14/15]include:media:davinci:vpss.h " Mauro Carvalho Chehab
2010-12-31 10:27 ` Mauro Carvalho Chehab
2010-12-31 10:27 ` Mauro Carvalho Chehab
2010-12-31 14:15 ` Justin P. Mattock
2010-12-31 14:15 ` Justin P. Mattock
2010-12-31 14:15 ` Justin P. Mattock
2010-12-31 14:15 ` Justin P. Mattock
2011-01-03 15:01 ` Jiri Kosina
2011-01-03 15:11 ` Justin P. Mattock
2011-01-03 15:11 ` Justin P. Mattock
2010-12-31 10:27 ` Mauro Carvalho Chehab
2010-12-30 23:08 ` Justin P. Mattock
2010-12-31 10:24 ` [PATCH 12/15]drivers:media:video:tvp7002.c " Mauro Carvalho Chehab
2010-12-31 10:24 ` Mauro Carvalho Chehab
2010-12-30 23:08 ` Justin P. Mattock
2010-12-31 10:23 ` [PATCH 11/15]drivers:media:video:cx18:cx23418.h " Mauro Carvalho Chehab
2010-12-31 10:23 ` Mauro Carvalho Chehab
2010-12-31 10:23 ` Mauro Carvalho Chehab
2011-01-03 15:04 ` Jiri Kosina
2010-12-31 21:15 ` Andy Walls
2010-12-31 21:15 ` Andy Walls
2010-12-31 21:15 ` Andy Walls
2010-12-31 21:15 ` Andy Walls
2010-12-31 22:33 ` Justin P. Mattock
2010-12-31 22:33 ` Justin P. Mattock
2010-12-31 22:33 ` Justin P. Mattock
2011-01-03 15:09 ` [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c " Jiri Kosina
2010-12-31 15:33 ` [PATCH 07/15]drivers:net:wireless:iwlwifi " Larry Finger
2010-12-31 15:33 ` Larry Finger
2011-01-03 15:06 ` Jiri Kosina
2010-12-31 15:33 ` Larry Finger
2011-01-04 17:56 ` John W. Linville
2010-12-30 23:07 ` [PATCH 05/15]drivers:staging:vt6655:rf.c " Justin P. Mattock
2010-12-30 23:07 ` [PATCH 04/15]drivers:staging:comedi:drivers:das800.c " Justin P. Mattock
2010-12-31 15:32 ` [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h " Larry Finger
2010-12-31 15:32 ` Larry Finger
2010-12-31 15:32 ` Larry Finger
2011-01-01 6:48 ` Finn Thain
2011-01-01 6:48 ` Finn Thain
2011-01-01 6:48 ` Finn Thain
2011-01-01 7:43 ` Justin P. Mattock
2011-01-01 7:43 ` Justin P. Mattock
2011-01-01 7:43 ` Justin P. Mattock
2011-01-01 9:09 ` Dan Carpenter
2011-01-01 9:09 ` Dan Carpenter
2011-01-01 9:09 ` Dan Carpenter
2011-01-01 14:53 ` Justin P. Mattock [this message]
2011-01-01 14:53 ` Justin P. Mattock
2011-01-01 14:53 ` Justin P. Mattock
2011-01-01 14:53 ` Justin P. Mattock
2011-01-01 14:53 ` Justin P. Mattock
2011-01-01 14:53 ` Justin P. Mattock
2011-01-01 9:09 ` Dan Carpenter
2011-01-01 7:43 ` Justin P. Mattock
2011-01-01 6:48 ` Finn Thain
2010-12-30 23:07 ` Justin P. Mattock
2010-12-31 6:45 ` [PATCH 02/15]drivers:spi:dw_spi.c " Grant Likely
2010-12-31 6:45 ` Grant Likely
2010-12-31 6:45 ` Grant Likely
2010-12-31 6:45 ` Grant Likely
2010-12-31 6:52 ` Justin P. Mattock
2010-12-31 6:52 ` Justin P. Mattock
2010-12-31 6:52 ` Justin P. Mattock
2010-12-31 9:11 ` Dan Carpenter
2010-12-31 9:11 ` Dan Carpenter
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 14:17 ` Justin P. Mattock
2010-12-31 15:06 ` James Bottomley
2010-12-31 15:06 ` James Bottomley
2010-12-31 15:06 ` James Bottomley
2010-12-31 15:06 ` James Bottomley
2010-12-31 17:41 ` Dan Carpenter
2010-12-31 17:41 ` Dan Carpenter
2010-12-31 17:59 ` Justin P. Mattock
2010-12-31 17:59 ` Justin P. Mattock
2010-12-31 17:59 ` Justin P. Mattock
2010-12-31 17:59 ` Justin P. Mattock
2010-12-31 17:59 ` Justin P. Mattock
2010-12-31 17:41 ` Dan Carpenter
2010-12-31 10:33 ` [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S " Geert Uytterhoeven
2010-12-31 10:33 ` Geert Uytterhoeven
2011-01-03 15:07 ` Jiri Kosina
2011-01-03 15:07 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='4D1F3FEE.7__44888.2512785078$1293893622$gmane$org@gmail.com' \
--to=justinmattock@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=error27@gmail.com \
--cc=fthain@telegraphics.com.au \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.orglinux- \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.