All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	trivial@kernel.org, devel@driverdev.osuosl.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ivtv-devel@ivtvdriver.org,
	linux-m68k@lists.linux-m68k.org,
	spi-devel-general@lists.sourceforge.net,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Fri, 31 Dec 2010 09:06:08 -0600	[thread overview]
Message-ID: <1293807968.3085.1.camel@mulgrave.site> (raw)
In-Reply-To: <4D1DE616.7010105@gmail.com>

On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote:
> On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> >> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>>> is correct or not.
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> >>>
> >>> applied, thanks.
> >>>
> >>> g.
> >>
> >> ahh.. thanks.. just cleared up the left out diabled that I had
> >> thought I forgotten(ended up separating comments and code and
> >> forgot)
> >
> > This is really just defensiveness and random grumbling and grumpiness on
> > my part, but one reason I may have missed the first patch is because
> > your subject lines are crap.
> >
> > Wrong:  [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> > Right:  [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> > regards,
> > dan carpenter
> >
> 
> alright.. so having the backlash is alright for the subject
> 
> Thanks for the pointer on this..

There is actually no specific form.  Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use.  I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.

James



WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@suse.de>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	trivial@kernel.org, devel@driverdev.osuosl.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ivtv-devel@ivtvdriver.org,
	linux-m68k@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	linux-media@vger.kernel.org
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Fri, 31 Dec 2010 09:06:08 -0600	[thread overview]
Message-ID: <1293807968.3085.1.camel@mulgrave.site> (raw)
In-Reply-To: <4D1DE616.7010105@gmail.com>

On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote:
> On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> >> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>>> is correct or not.
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
> >>>
> >>> applied, thanks.
> >>>
> >>> g.
> >>
> >> ahh.. thanks.. just cleared up the left out diabled that I had
> >> thought I forgotten(ended up separating comments and code and
> >> forgot)
> >
> > This is really just defensiveness and random grumbling and grumpiness on
> > my part, but one reason I may have missed the first patch is because
> > your subject lines are crap.
> >
> > Wrong:  [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> > Right:  [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> > regards,
> > dan carpenter
> >
> 
> alright.. so having the backlash is alright for the subject
> 
> Thanks for the pointer on this..

There is actually no specific form.  Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use.  I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.

James



WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley-l3A5Bk7waGM@public.gmane.org>
To: "Justin P. Mattock"
	<justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ivtv-devel-jGorlIydJmRM656bX5wj8A@public.gmane.org,
	linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Date: Fri, 31 Dec 2010 09:06:08 -0600	[thread overview]
Message-ID: <1293807968.3085.1.camel@mulgrave.site> (raw)
In-Reply-To: <4D1DE616.7010105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Fri, 2010-12-31 at 06:17 -0800, Justin P. Mattock wrote:
> On 12/31/2010 01:11 AM, Dan Carpenter wrote:
> > On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
> >> On 12/30/2010 10:45 PM, Grant Likely wrote:
> >>> On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
> >>>> The below patch fixes a typo "diable" to "disable". Please let me know if this
> >>>> is correct or not.
> >>>>
> >>>> Signed-off-by: Justin P. Mattock<justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>>
> >>> applied, thanks.
> >>>
> >>> g.
> >>
> >> ahh.. thanks.. just cleared up the left out diabled that I had
> >> thought I forgotten(ended up separating comments and code and
> >> forgot)
> >
> > This is really just defensiveness and random grumbling and grumpiness on
> > my part, but one reason I may have missed the first patch is because
> > your subject lines are crap.
> >
> > Wrong:  [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
> >
> > Right:  [PATCH 02/15] spi/dw_spi: Typo change diable to disable
> >
> > regards,
> > dan carpenter
> >
> 
> alright.. so having the backlash is alright for the subject
> 
> Thanks for the pointer on this..

There is actually no specific form.  Most of us edit this part of the
subject line anyway to conform to whatever (nonuniform) conventions we
use.  I just use <component>: with no scsi or drivers prefix because the
git tree is tagged [SCSI]; others are different.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-12-31 15:06 UTC|newest]

Thread overview: 139+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 23:07 [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S Typo change diable to disable Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07 ` [PATCH 02/15]drivers:spi:dw_spi.c " Justin P. Mattock
2010-12-30 23:07 ` Justin P. Mattock
2010-12-30 23:07   ` Justin P. Mattock
2010-12-30 23:07   ` [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h " Justin P. Mattock
2010-12-30 23:07     ` Justin P. Mattock
2010-12-30 23:07     ` Justin P. Mattock
2010-12-30 23:07     ` [PATCH 04/15]drivers:staging:comedi:drivers:das800.c " Justin P. Mattock
2010-12-30 23:07       ` Justin P. Mattock
2010-12-30 23:07       ` [PATCH 05/15]drivers:staging:vt6655:rf.c " Justin P. Mattock
2010-12-30 23:07         ` Justin P. Mattock
2010-12-30 23:07         ` [PATCH 06/15]drivers:staging:xgifb:vb_setmode.c " Justin P. Mattock
2010-12-30 23:07         ` Justin P. Mattock
2010-12-30 23:07           ` Justin P. Mattock
2010-12-30 23:07           ` Justin P. Mattock
2010-12-30 23:07           ` [PATCH 07/15]drivers:net:wireless:iwlwifi " Justin P. Mattock
2010-12-30 23:07           ` Justin P. Mattock
2010-12-30 23:07             ` Justin P. Mattock
2010-12-30 23:07             ` Justin P. Mattock
2010-12-30 23:07             ` [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c " Justin P. Mattock
2010-12-30 23:07             ` Justin P. Mattock
2010-12-30 23:07               ` Justin P. Mattock
2010-12-30 23:07               ` [PATCH 09/15]drivers:usb:host " Justin P. Mattock
2010-12-30 23:07               ` Justin P. Mattock
2010-12-30 23:07                 ` Justin P. Mattock
2010-12-30 23:07                 ` Justin P. Mattock
2010-12-30 23:07                 ` [PATCH 10/15]drivers:usb:gadget:langwell " Justin P. Mattock
2010-12-30 23:07                 ` Justin P. Mattock
2010-12-30 23:07                   ` Justin P. Mattock
2010-12-30 23:08                   ` [PATCH 11/15]drivers:media:video:cx18:cx23418.h " Justin P. Mattock
2010-12-30 23:08                   ` Justin P. Mattock
2010-12-30 23:08                     ` Justin P. Mattock
2010-12-30 23:08                     ` [PATCH 12/15]drivers:media:video:tvp7002.c " Justin P. Mattock
2010-12-30 23:08                       ` Justin P. Mattock
2010-12-30 23:08                       ` Justin P. Mattock
2010-12-30 23:08                       ` [PATCH 13/15]drivers:isdn:mISDN:dsp_cmx.c " Justin P. Mattock
2010-12-30 23:08                       ` Justin P. Mattock
2010-12-30 23:08                         ` Justin P. Mattock
2010-12-30 23:08                         ` Justin P. Mattock
2010-12-30 23:08                         ` [PATCH 14/15]include:media:davinci:vpss.h " Justin P. Mattock
2010-12-30 23:08                           ` Justin P. Mattock
2010-12-30 23:08                           ` [PATCH 15/15]drivers:spi:dw_spi.c " Justin P. Mattock
2010-12-30 23:08                           ` Justin P. Mattock
2010-12-30 23:08                             ` Justin P. Mattock
2010-12-31  6:34                             ` Dan Carpenter
2010-12-31  6:34                             ` Dan Carpenter
2010-12-31  6:34                               ` Dan Carpenter
2010-12-31  6:38                               ` Justin P. Mattock
2010-12-31  6:38                               ` Justin P. Mattock
2010-12-31  6:38                                 ` Justin P. Mattock
2010-12-31  6:38                                 ` Justin P. Mattock
2010-12-31 10:27                           ` [PATCH 14/15]include:media:davinci:vpss.h " Mauro Carvalho Chehab
2010-12-31 10:27                             ` Mauro Carvalho Chehab
2010-12-31 10:27                             ` Mauro Carvalho Chehab
2010-12-31 14:15                             ` Justin P. Mattock
2010-12-31 14:15                             ` Justin P. Mattock
2010-12-31 14:15                               ` Justin P. Mattock
2010-12-31 14:15                               ` Justin P. Mattock
2011-01-03 15:01                             ` Jiri Kosina
2011-01-03 15:11                               ` Justin P. Mattock
2011-01-03 15:11                                 ` Justin P. Mattock
2010-12-31 10:27                           ` Mauro Carvalho Chehab
2010-12-30 23:08                         ` Justin P. Mattock
2010-12-31 10:24                       ` [PATCH 12/15]drivers:media:video:tvp7002.c " Mauro Carvalho Chehab
2010-12-31 10:24                         ` Mauro Carvalho Chehab
2010-12-30 23:08                     ` Justin P. Mattock
2010-12-31 10:23                     ` [PATCH 11/15]drivers:media:video:cx18:cx23418.h " Mauro Carvalho Chehab
2010-12-31 10:23                     ` Mauro Carvalho Chehab
2010-12-31 10:23                       ` Mauro Carvalho Chehab
2011-01-03 15:04                       ` Jiri Kosina
2010-12-31 21:15                     ` Andy Walls
2010-12-31 21:15                     ` Andy Walls
2010-12-31 21:15                       ` Andy Walls
2010-12-31 21:15                       ` Andy Walls
2010-12-31 22:33                       ` Justin P. Mattock
2010-12-31 22:33                         ` Justin P. Mattock
2010-12-31 22:33                       ` Justin P. Mattock
2011-01-03 15:09               ` [PATCH 08/15]drivers:scsi:lpfc:lpfc_init.c " Jiri Kosina
2010-12-31 15:33             ` [PATCH 07/15]drivers:net:wireless:iwlwifi " Larry Finger
2010-12-31 15:33               ` Larry Finger
2011-01-03 15:06               ` Jiri Kosina
2010-12-31 15:33             ` Larry Finger
2011-01-04 17:56             ` John W. Linville
2010-12-30 23:07       ` [PATCH 05/15]drivers:staging:vt6655:rf.c " Justin P. Mattock
2010-12-30 23:07     ` [PATCH 04/15]drivers:staging:comedi:drivers:das800.c " Justin P. Mattock
2010-12-31 15:32     ` [PATCH 03/15]drivers:staging:rtl8187se:r8180_hw.h " Larry Finger
2010-12-31 15:32       ` Larry Finger
2010-12-31 15:32     ` Larry Finger
2011-01-01  6:48     ` Finn Thain
2011-01-01  6:48       ` Finn Thain
2011-01-01  6:48       ` Finn Thain
2011-01-01  7:43       ` Justin P. Mattock
2011-01-01  7:43         ` Justin P. Mattock
2011-01-01  7:43         ` Justin P. Mattock
2011-01-01  9:09         ` Dan Carpenter
2011-01-01  9:09           ` Dan Carpenter
2011-01-01  9:09           ` Dan Carpenter
2011-01-01 14:53           ` Justin P. Mattock
2011-01-01 14:53           ` Justin P. Mattock
2011-01-01 14:53             ` Justin P. Mattock
2011-01-01 14:53             ` Justin P. Mattock
2011-01-01 14:53             ` Justin P. Mattock
2011-01-01 14:53           ` Justin P. Mattock
2011-01-01  9:09         ` Dan Carpenter
2011-01-01  7:43       ` Justin P. Mattock
2011-01-01  6:48     ` Finn Thain
2010-12-30 23:07   ` Justin P. Mattock
2010-12-31  6:45   ` [PATCH 02/15]drivers:spi:dw_spi.c " Grant Likely
2010-12-31  6:45   ` Grant Likely
2010-12-31  6:45     ` Grant Likely
2010-12-31  6:45     ` Grant Likely
2010-12-31  6:52     ` Justin P. Mattock
2010-12-31  6:52     ` Justin P. Mattock
2010-12-31  6:52       ` Justin P. Mattock
2010-12-31  9:11       ` Dan Carpenter
2010-12-31  9:11         ` Dan Carpenter
2010-12-31 14:17         ` Justin P. Mattock
2010-12-31 14:17         ` Justin P. Mattock
2010-12-31 14:17         ` Justin P. Mattock
2010-12-31 14:17           ` Justin P. Mattock
2010-12-31 14:17           ` Justin P. Mattock
2010-12-31 14:17           ` Justin P. Mattock
2010-12-31 15:06           ` James Bottomley [this message]
2010-12-31 15:06             ` James Bottomley
2010-12-31 15:06             ` James Bottomley
2010-12-31 15:06           ` James Bottomley
2010-12-31 17:41           ` Dan Carpenter
2010-12-31 17:41             ` Dan Carpenter
2010-12-31 17:59             ` Justin P. Mattock
2010-12-31 17:59             ` Justin P. Mattock
2010-12-31 17:59               ` Justin P. Mattock
2010-12-31 17:59               ` Justin P. Mattock
2010-12-31 17:59               ` Justin P. Mattock
2010-12-31 17:41           ` Dan Carpenter
2010-12-31 10:33 ` [PATCH 01/15]arch:m68k:ifpsp060:src:fpsp.S " Geert Uytterhoeven
2010-12-31 10:33   ` Geert Uytterhoeven
2011-01-03 15:07   ` Jiri Kosina
2011-01-03 15:07     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293807968.3085.1.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=error27@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.