From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC
Date: Thu, 25 Feb 2021 08:54:09 +0100 [thread overview]
Message-ID: <4DF5654C-1412-4E89-BF21-60C649EEDF4F@gmail.com> (raw)
In-Reply-To: <20210225084838.34bbdbff@xps13>
Hi Miquel,
> El 25 feb 2021, a las 8:48, Miquel Raynal <miquel.raynal@bootlin.com> escribió:
>
> Hi Álvaro,
>
> Brian Norris <computersforpeace@gmail.com> wrote on Wed, 24 Feb 2021
> 13:01:13 -0800:
>
>> On Wed, Feb 24, 2021 at 12:02 AM Álvaro Fernández Rojas
>> <noltari@gmail.com> wrote:
>>> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
>>
>> FWIW, I could believe this was broken. We weren't testing Hamming ECC
>> (nor JFFS2) at the time, so it could easily have obvious bugs like
>> this.
>
> Right, you should probably limit the backport to the time when raw
> accessors got introduced/fixed.
What do you mean?
Those accessors have been there since the first commit (27c5b17cd1b10564fa36f8f51e4b4b41436ecc32):
https://github.com/torvalds/linux/blob/27c5b17cd1b10564fa36f8f51e4b4b41436ecc32/drivers/mtd/nand/brcmnand/brcmnand.c#L1896-L1899
>
> Thanks,
> Miquèl
Best regards,
Álvaro.
WARNING: multiple messages have this Message-ID (diff)
From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Richard Weinberger <richard@nod.at>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC
Date: Thu, 25 Feb 2021 08:54:09 +0100 [thread overview]
Message-ID: <4DF5654C-1412-4E89-BF21-60C649EEDF4F@gmail.com> (raw)
In-Reply-To: <20210225084838.34bbdbff@xps13>
Hi Miquel,
> El 25 feb 2021, a las 8:48, Miquel Raynal <miquel.raynal@bootlin.com> escribió:
>
> Hi Álvaro,
>
> Brian Norris <computersforpeace@gmail.com> wrote on Wed, 24 Feb 2021
> 13:01:13 -0800:
>
>> On Wed, Feb 24, 2021 at 12:02 AM Álvaro Fernández Rojas
>> <noltari@gmail.com> wrote:
>>> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
>>
>> FWIW, I could believe this was broken. We weren't testing Hamming ECC
>> (nor JFFS2) at the time, so it could easily have obvious bugs like
>> this.
>
> Right, you should probably limit the backport to the time when raw
> accessors got introduced/fixed.
What do you mean?
Those accessors have been there since the first commit (27c5b17cd1b10564fa36f8f51e4b4b41436ecc32):
https://github.com/torvalds/linux/blob/27c5b17cd1b10564fa36f8f51e4b4b41436ecc32/drivers/mtd/nand/brcmnand/brcmnand.c#L1896-L1899
>
> Thanks,
> Miquèl
Best regards,
Álvaro.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-02-25 7:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 20:16 [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC Álvaro Fernández Rojas
2021-02-22 20:16 ` Álvaro Fernández Rojas
2021-02-24 3:46 ` Florian Fainelli
2021-02-24 3:46 ` Florian Fainelli
2021-02-24 7:16 ` Álvaro Fernández Rojas
2021-02-24 7:16 ` Álvaro Fernández Rojas
2021-02-24 7:38 ` Miquel Raynal
2021-02-24 7:38 ` Miquel Raynal
2021-02-24 8:02 ` [PATCH v2] " Álvaro Fernández Rojas
2021-02-24 8:02 ` Álvaro Fernández Rojas
2021-02-24 21:01 ` Brian Norris
2021-02-24 21:01 ` Brian Norris
2021-02-25 7:48 ` Miquel Raynal
2021-02-25 7:48 ` Miquel Raynal
2021-02-25 7:54 ` Álvaro Fernández Rojas [this message]
2021-02-25 7:54 ` Álvaro Fernández Rojas
2021-02-25 8:12 ` Miquel Raynal
2021-02-25 8:12 ` Miquel Raynal
2021-03-02 16:32 ` Miquel Raynal
2021-03-02 16:32 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF5654C-1412-4E89-BF21-60C649EEDF4F@gmail.com \
--to=noltari@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.