All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Russell King <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 03/11] dt/irq: add irq_domain_add_simple() helper
Date: Thu, 16 Jun 2011 09:04:51 -0500	[thread overview]
Message-ID: <4DFA0D83.6070604@gmail.com> (raw)
In-Reply-To: <20110616044141.29371.76366.stgit@ponder>

Grant,

On 06/15/2011 11:41 PM, Grant Likely wrote:
> irq_domain_add_simple() is an easy way to generate an irq translation
> domain for simple irq controllers.  It assumes a flat 1:1 mapping from
> hardware irq number to an offset of the first linux irq number assigned
> to the controller
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>  include/linux/irq.h    |   11 +++++++++
>  kernel/irq/irqdomain.c |   58 +++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 68 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index a103c01..50830fc 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -797,6 +797,17 @@ extern unsigned int irq_domain_map(struct irq_domain *domain,
>  				   irq_hw_number_t hwirq);
>  extern void irq_domain_unmap(struct irq_domain *domain, irq_hw_number_t hw);
>  
> +struct of_device_id;
> +#ifdef CONFIG_OF
> +extern void irq_domain_add_simple(struct device_node *controller, int irq_base);
> +extern void irq_domain_generate_simple(struct of_device_id *match,

match should be const

> +					u64 phys_base, unsigned int irq_start);
> +#else

Empty function for irq_domain_add_simple?

> +static inline void irq_domain_generate_simple(struct of_device_id *match,
> +					u64 phys_base, unsigned int irq_start) { }
> +#endif
> +
> +

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Nicolas Pitre
	<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH 03/11] dt/irq: add irq_domain_add_simple() helper
Date: Thu, 16 Jun 2011 09:04:51 -0500	[thread overview]
Message-ID: <4DFA0D83.6070604@gmail.com> (raw)
In-Reply-To: <20110616044141.29371.76366.stgit@ponder>

Grant,

On 06/15/2011 11:41 PM, Grant Likely wrote:
> irq_domain_add_simple() is an easy way to generate an irq translation
> domain for simple irq controllers.  It assumes a flat 1:1 mapping from
> hardware irq number to an offset of the first linux irq number assigned
> to the controller
> 
> Signed-off-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> ---
>  include/linux/irq.h    |   11 +++++++++
>  kernel/irq/irqdomain.c |   58 +++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 68 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index a103c01..50830fc 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -797,6 +797,17 @@ extern unsigned int irq_domain_map(struct irq_domain *domain,
>  				   irq_hw_number_t hwirq);
>  extern void irq_domain_unmap(struct irq_domain *domain, irq_hw_number_t hw);
>  
> +struct of_device_id;
> +#ifdef CONFIG_OF
> +extern void irq_domain_add_simple(struct device_node *controller, int irq_base);
> +extern void irq_domain_generate_simple(struct of_device_id *match,

match should be const

> +					u64 phys_base, unsigned int irq_start);
> +#else

Empty function for irq_domain_add_simple?

> +static inline void irq_domain_generate_simple(struct of_device_id *match,
> +					u64 phys_base, unsigned int irq_start) { }
> +#endif
> +
> +

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 03/11] dt/irq: add irq_domain_add_simple() helper
Date: Thu, 16 Jun 2011 09:04:51 -0500	[thread overview]
Message-ID: <4DFA0D83.6070604@gmail.com> (raw)
In-Reply-To: <20110616044141.29371.76366.stgit@ponder>

Grant,

On 06/15/2011 11:41 PM, Grant Likely wrote:
> irq_domain_add_simple() is an easy way to generate an irq translation
> domain for simple irq controllers.  It assumes a flat 1:1 mapping from
> hardware irq number to an offset of the first linux irq number assigned
> to the controller
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>  include/linux/irq.h    |   11 +++++++++
>  kernel/irq/irqdomain.c |   58 +++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 68 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/irq.h b/include/linux/irq.h
> index a103c01..50830fc 100644
> --- a/include/linux/irq.h
> +++ b/include/linux/irq.h
> @@ -797,6 +797,17 @@ extern unsigned int irq_domain_map(struct irq_domain *domain,
>  				   irq_hw_number_t hwirq);
>  extern void irq_domain_unmap(struct irq_domain *domain, irq_hw_number_t hw);
>  
> +struct of_device_id;
> +#ifdef CONFIG_OF
> +extern void irq_domain_add_simple(struct device_node *controller, int irq_base);
> +extern void irq_domain_generate_simple(struct of_device_id *match,

match should be const

> +					u64 phys_base, unsigned int irq_start);
> +#else

Empty function for irq_domain_add_simple?

> +static inline void irq_domain_generate_simple(struct of_device_id *match,
> +					u64 phys_base, unsigned int irq_start) { }
> +#endif
> +
> +

Rob

  reply	other threads:[~2011-06-16 14:04 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16  4:40 [RFC PATCH 00/11] Full device tree support for ARM Versatile Grant Likely
2011-06-16  4:40 ` Grant Likely
2011-06-16  4:40 ` Grant Likely
2011-06-16  4:41 ` [RFC PATCH 01/11] irq: add irq_domain translation infrastructure Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-20  9:54   ` Marc Zyngier
2011-06-20  9:54     ` Marc Zyngier
2011-06-20  9:54     ` Marc Zyngier
2011-06-16  4:41 ` [RFC PATCH 02/11] of/address: Add of_find_matching_node_by_address helper Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:41 ` [RFC PATCH 03/11] dt/irq: add irq_domain_add_simple() helper Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16 14:04   ` Rob Herring [this message]
2011-06-16 14:04     ` Rob Herring
2011-06-16 14:04     ` Rob Herring
2011-06-16 14:21     ` Rob Herring
2011-06-16 14:21       ` Rob Herring
2011-06-16 14:21       ` Rob Herring
2011-06-16 16:57       ` Grant Likely
2011-06-16 16:57         ` Grant Likely
2011-06-16 16:57         ` Grant Likely
2011-06-16 16:56     ` Grant Likely
2011-06-16 16:56       ` Grant Likely
2011-06-16 16:56       ` Grant Likely
2011-06-16  4:41 ` [RFC PATCH 04/11] dt: add of_platform_populate() for creating device from the device tree Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:41   ` Grant Likely
2011-06-16  4:42 ` [RFC PATCH 05/11] dt: Add default match table for bus ids Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42 ` [RFC PATCH 06/11] drivers/amba: create devices from device tree Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42 ` [RFC PATCH 07/11] dt/platform: allow device name to be overridden Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42 ` [RFC PATCH 08/11] powerpc/5200: convert mpc5200 to use of_platform_populate() Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42 ` [RFC PATCH 09/11] arm/dt: Add dt machine definition Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-06-16  4:42   ` Grant Likely
2011-07-08 14:30   ` Rob Herring
2011-07-08 14:30     ` Rob Herring
2011-06-16  4:43 ` [RFC PATCH 10/11] arm/dt: Add skeleton dtsi file Grant Likely
2011-06-16  4:43   ` Grant Likely
2011-06-16  4:43   ` Grant Likely
2011-06-16  4:43 ` [RFC PATCH 11/11] arm/versatile: Add device tree support Grant Likely
2011-06-16  4:43   ` Grant Likely
2011-06-16  4:43   ` Grant Likely
2011-06-16 14:19   ` Rob Herring
2011-06-16 14:19     ` Rob Herring
2011-06-16 15:42     ` Grant Likely
2011-06-16 15:42       ` Grant Likely
2011-06-16 15:42       ` Grant Likely
2011-06-16 14:20   ` Arnd Bergmann
2011-06-16 14:20     ` Arnd Bergmann
2011-06-16 14:20     ` Arnd Bergmann
2011-06-16 14:56     ` Grant Likely
2011-06-16 14:56       ` Grant Likely
2011-06-17  1:11   ` Shawn Guo
2011-06-17  1:11     ` Shawn Guo
2011-06-17  1:11     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFA0D83.6070604@gmail.com \
    --to=robherring2@gmail.com \
    --cc=arnd@arndb.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nicolas.pitre@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.