From: viresh kumar <viresh.kumar@st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
Grant Likely <grant.likely@secretlab.ca>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Amit VIRDI <amit.virdi@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
viresh kumar <viresh.linux@gmail.com>,
deepak sikri <deepak.sikri@st.com>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/6] spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate
Date: Wed, 10 Aug 2011 09:06:43 +0530 [thread overview]
Message-ID: <4E41FCCB.7040609@st.com> (raw)
In-Reply-To: <CACRpkdYAkPtOkVuF-UhpFHugvZpw_owmgoxP_opF8KE=cYF95w@mail.gmail.com>
[Probably you missed reply-all by mistake, so adding them again]
On 08/10/2011 01:34 AM, Linus Walleij wrote:
> On Tue, Aug 9, 2011 at 1:05 PM, Viresh Kumar <viresh.kumar@st.com> wrote:
>
>> There were few issues with calculate_effective_freq() routine:
>> - It was returning first rate found >= requested rate. Now, if system have spi's
>> rate as 83 MHz, with possible prescaled rates as 83, 41.5, 20.75, 13.83 (as we
>> can prescale with multiples of 2). If user has given rate to be programmed as
>> 22 MHz, then driver programmes it to 41.5 MHz. This looks to be incorrect, as
>> user might have given the upper limit of the device, and we are programming it
>> above it.
>> - Driver finds the first satisfying rate and programmes it, but with other
>> values of scr & cpsdvsr, it is possible to get more closer rate.
>
> Good that you found this bug!
>
>> +#define SPI_RATE(rate, cpsdvsr, scr) (rate / (cpsdvsr * (1 + scr)))
>
> Can you use a static inline instead of a macro? It is often preferred.
> If you do, this is Acked-by.
>
Not a problem. Will surely do that.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@st.com (viresh kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate
Date: Wed, 10 Aug 2011 09:06:43 +0530 [thread overview]
Message-ID: <4E41FCCB.7040609@st.com> (raw)
In-Reply-To: <CACRpkdYAkPtOkVuF-UhpFHugvZpw_owmgoxP_opF8KE=cYF95w@mail.gmail.com>
[Probably you missed reply-all by mistake, so adding them again]
On 08/10/2011 01:34 AM, Linus Walleij wrote:
> On Tue, Aug 9, 2011 at 1:05 PM, Viresh Kumar <viresh.kumar@st.com> wrote:
>
>> There were few issues with calculate_effective_freq() routine:
>> - It was returning first rate found >= requested rate. Now, if system have spi's
>> rate as 83 MHz, with possible prescaled rates as 83, 41.5, 20.75, 13.83 (as we
>> can prescale with multiples of 2). If user has given rate to be programmed as
>> 22 MHz, then driver programmes it to 41.5 MHz. This looks to be incorrect, as
>> user might have given the upper limit of the device, and we are programming it
>> above it.
>> - Driver finds the first satisfying rate and programmes it, but with other
>> values of scr & cpsdvsr, it is possible to get more closer rate.
>
> Good that you found this bug!
>
>> +#define SPI_RATE(rate, cpsdvsr, scr) (rate / (cpsdvsr * (1 + scr)))
>
> Can you use a static inline instead of a macro? It is often preferred.
> If you do, this is Acked-by.
>
Not a problem. Will surely do that.
--
viresh
next prev parent reply other threads:[~2011-08-10 3:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 11:05 [PATCH 0/6] spi/spi-pl022 fixes Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
[not found] ` <cover.1312887860.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2011-08-09 11:05 ` [PATCH 1/6] spi/spi-pl022: Resolve formatting issues Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
2011-08-09 11:05 ` [PATCH 2/6] spi/spi-pl022: Use GFP_NOWAIT for allocation from tasklet Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
2011-08-09 11:26 ` Jassi Brar
2011-08-09 11:26 ` Jassi Brar
[not found] ` <CABb+yY3CuYqNcpvdP8fa6FsaN3EBDAXivKSP56gRh6-oPyp2Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-10 3:27 ` viresh kumar
2011-08-10 3:27 ` viresh kumar
2011-08-09 11:05 ` [PATCH 3/6] spi/spi-pl022: Don't allocate more sg than required Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
2011-08-09 11:05 ` [PATCH 4/6] spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
[not found] ` <CACRpkdYAkPtOkVuF-UhpFHugvZpw_owmgoxP_opF8KE=cYF95w@mail.gmail.com>
2011-08-10 3:36 ` viresh kumar [this message]
2011-08-10 3:36 ` viresh kumar
2011-08-09 11:05 ` [PATCH 5/6] spi/spi-pl022: Call pl022_dma_remove(pl022) only if enable_dma is true Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
2011-08-09 11:05 ` [PATCH 6/6] spi/spi-pl022: Request/free DMA channels as and when required Viresh Kumar
2011-08-09 11:05 ` Viresh Kumar
2011-08-09 20:10 ` [PATCH 0/6] spi/spi-pl022 fixes Linus Walleij
2011-08-09 20:10 ` Linus Walleij
2011-08-10 3:55 ` viresh kumar
2011-08-10 3:55 ` viresh kumar
2011-08-10 7:20 ` Linus Walleij
2011-08-10 7:20 ` Linus Walleij
[not found] ` <CAKnu2MoTQTYMa4JvWyr7sPMhPyziTtnLeZLySUYxcuQC2Vu-6Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-10 14:12 ` Arnd Bergmann
2011-08-10 14:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E41FCCB.7040609@st.com \
--to=viresh.kumar@st.com \
--cc=amit.virdi@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.