From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com,
anthony@codemonkey.ws, rusty@rustcorp.com.au
Subject: Re: [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE
Date: Tue, 03 Jul 2012 15:54:04 +0200 [thread overview]
Message-ID: <4FF2F97C.70803@redhat.com> (raw)
In-Reply-To: <4FF2F79E.2080805@redhat.com>
Il 03/07/2012 15:46, Kevin Wolf ha scritto:
>> > Introduce a new feature bit and configuration field that provide
>> > support for toggling the cache mode between writethrough and writeback.
>> >
>> > Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
>> > the spec.
> My spec (and my kernel as well) call it VIRTIO_BLK_F_FLUSH.
>
> What's the status of the kernel and spec side of the change?
Both posted. The spec patch that introduces VIRTIO_BLK_F_CONFIG_WCE
also renames it to VIRTIO_BLK_F_WCE, since that's really what it does.
See this old comment in the kernel (not in the latest git anymore):
/*
* If the FLUSH feature is supported we do have support for
* flushing a volatile write cache on the host. [...]
* otherwise, we must assume that the host does not
* perform any kind of volatile write caching.
*/
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: anthony@codemonkey.ws, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE
Date: Tue, 03 Jul 2012 15:54:04 +0200 [thread overview]
Message-ID: <4FF2F97C.70803@redhat.com> (raw)
In-Reply-To: <4FF2F79E.2080805@redhat.com>
Il 03/07/2012 15:46, Kevin Wolf ha scritto:
>> > Introduce a new feature bit and configuration field that provide
>> > support for toggling the cache mode between writethrough and writeback.
>> >
>> > Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
>> > the spec.
> My spec (and my kernel as well) call it VIRTIO_BLK_F_FLUSH.
>
> What's the status of the kernel and spec side of the change?
Both posted. The spec patch that introduces VIRTIO_BLK_F_CONFIG_WCE
also renames it to VIRTIO_BLK_F_WCE, since that's really what it does.
See this old comment in the kernel (not in the latest git anymore):
/*
* If the FLUSH feature is supported we do have support for
* flushing a volatile write cache on the host. [...]
* otherwise, we must assume that the host does not
* perform any kind of volatile write caching.
*/
Paolo
next prev parent reply other threads:[~2012-07-03 13:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:20 [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements Paolo Bonzini
2012-07-03 13:20 ` [Qemu-devel] " Paolo Bonzini
2012-07-03 13:20 ` [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE Paolo Bonzini
2012-07-03 13:20 ` [Qemu-devel] " Paolo Bonzini
2012-07-03 13:46 ` Kevin Wolf
2012-07-03 13:46 ` [Qemu-devel] " Kevin Wolf
2012-07-03 13:54 ` Paolo Bonzini [this message]
2012-07-03 13:54 ` Paolo Bonzini
2012-07-03 13:20 ` [PATCH 2/2] virtio-blk: disable write cache if not negotiated Paolo Bonzini
2012-07-03 13:20 ` [Qemu-devel] " Paolo Bonzini
2012-07-03 13:49 ` Kevin Wolf
2012-07-03 13:49 ` [Qemu-devel] " Kevin Wolf
2012-07-03 13:51 ` Paolo Bonzini
2012-07-03 13:51 ` [Qemu-devel] " Paolo Bonzini
2012-07-04 10:16 ` Kevin Wolf
2012-07-04 10:16 ` Kevin Wolf
2012-07-04 12:21 ` Paolo Bonzini
2012-07-04 12:21 ` Paolo Bonzini
2012-07-04 12:50 ` Kevin Wolf
2012-07-04 12:50 ` [Qemu-devel] " Kevin Wolf
2012-07-04 13:20 ` Paolo Bonzini
2012-07-04 13:20 ` Paolo Bonzini
2012-07-23 16:32 ` [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements Paolo Bonzini
2012-07-23 16:32 ` [Qemu-devel] " Paolo Bonzini
2012-08-01 15:52 ` Paolo Bonzini
2012-08-01 15:52 ` [Qemu-devel] " Paolo Bonzini
2012-08-01 16:25 ` Kevin Wolf
2012-08-01 16:25 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF2F97C.70803@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.