Re: [PATCH v2 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

From: Andrey Grodzovsky <Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>
To: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.
Date: Tue, 16 Jan 2018 12:28:39 -0500	[thread overview]
Message-ID: <4a3881f0-a656-e1fa-ad93-cfb7e24bbd9e@amd.com> (raw)
In-Reply-To: <ce727655-b4cc-0e41-eeef-7e768fe958d6-5C7GfCeVMHo@public.gmane.org>

On 01/16/2018 11:42 AM, Felix Kuehling wrote:
> On 2018-01-16 10:18 AM, Andrey Grodzovsky wrote:
>> Avoid OOM on syatem pages allocations.
>>
>> v2:
>> Remove modeprobe parameter, making this behaviour the only option.
>>
>> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> index 5c4c3e0..b4dc3bd 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
>> @@ -420,6 +420,10 @@ static int amdgpu_bo_do_create(struct amdgpu_device *adev,
>>   #endif
>>   
>>   	bo->tbo.bdev = &adev->mman.bdev;
>> +
>> +	/* We opt to avoid OOM on system pages allocations */
>> +	bo->tbo.bdev->no_retry = true;
>> +
> Couldn't this be done once in amdgpu_ttm_init just after calling
> ttm_bo_device_init? No need to do this for every BO creation.
>
> Regards,
>    Felix

Good catch, will fix.

Thanks,
Andrey

>
>>   	amdgpu_ttm_placement_from_domain(bo, domain);
>>   
>>   	r = ttm_bo_init_reserved(&adev->mman.bdev, &bo->tbo, size, type,
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx