Re: [PATCH v3] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v3] drm/amdgpu: Use new TTM flag to avoid OOM triggering.
Date: Tue, 16 Jan 2018 15:00:02 -0500	[thread overview]
Message-ID: <a8cc5f06-7b07-abab-4dbb-b9a1deaf04f0@amd.com> (raw)
In-Reply-To: <1516132211-32035-1-git-send-email-andrey.grodzovsky-5C7GfCeVMHo@public.gmane.org>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

On 2018-01-16 02:50 PM, Andrey Grodzovsky wrote:
> Avoid OOM on syatem pages allocations.
>
> v2:
> Remove modeprobe parameter, make this behaviour the only option.
>
> v3:
> Move setting no_retry flag into amdgpu_ttm_init.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 290cdf0..d32f482 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1387,6 +1387,10 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
>  		return r;
>  	}
>  	adev->mman.initialized = true;
> +
> +	/* We opt to avoid OOM on system pages allocations */
> +	adev->mman.bdev.no_retry = true;
> +
>  	r = ttm_bo_init_mm(&adev->mman.bdev, TTM_PL_VRAM,
>  				adev->gmc.real_vram_size >> PAGE_SHIFT);
>  	if (r) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx