From: Dmitry Osipenko <digetx@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Keerthy <j-keerthy@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-kernel@vger.kernel.org,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 5/5] OPP: Remove custom OPP helper support
Date: Mon, 27 Jun 2022 09:10:49 +0300 [thread overview]
Message-ID: <4a8114f7-4ee6-a9ad-f5be-ceaf64be8a0e@gmail.com> (raw)
In-Reply-To: <20220627060636.rfpok75zydgcwwo6@vireshk-i7>
27.06.2022 09:06, Viresh Kumar пишет:
> Hi Dmitry,
>
> On 25-06-22, 14:42, Dmitry Osipenko wrote:
>> 31.05.2022 13:10, Viresh Kumar пишет:
>>> The only user of the custom helper is migrated to use
>>> config_regulators() interface. Remove the now unused custom OPP helper
>>> support.
>>>
>>> This cleans up _set_opp() and leaves a single code path to be used by
>>> all users.
>
>> Unfortunately we can't remove the set_opp_helper(). It's terrible that
>> this function is unused by Tegra 3d driver because it should be used.
>>
>> The patch that supposed to use the devm_pm_opp_register_set_opp_helper()
>> [1] was merged a half year ago and just today I noticed that the merged
>> code doesn't have devm_pm_opp_register_set_opp_helper() [2]. I think
>> Thierry edited my patch before applying it, perhaps there was a merge
>> conflict :/ This needs to be fixed now.
>
> As the commit log above says, we aren't removing the feature, but just
> changing the interface to cnofig_regulators(). That was the only
> special handling the drivers were required to do earlier as well, for
> which the helper interface was added.
>
Okay, but Tegra 3d driver doesn't need config_regulators(), it needs
customized set_opp() to set clock rate for both 3d engines.
next prev parent reply other threads:[~2022-06-27 6:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 10:09 [PATCH 0/5] OPP: Replace custom set_opp() with config_regulators() Viresh Kumar
2022-05-31 10:10 ` [PATCH 1/5] OPP: Add support for config_regulators() helper Viresh Kumar
2022-05-31 10:10 ` [PATCH 2/5] OPP: Make _generic_set_opp_regulator() a config_regulators() interface Viresh Kumar
2022-05-31 10:10 ` [PATCH 3/5] OPP: Add dev_pm_opp_get_supplies() Viresh Kumar
2022-05-31 10:10 ` [PATCH 4/5] OPP: ti: Migrate to config_regulators() Viresh Kumar
2022-05-31 10:10 ` [PATCH 5/5] OPP: Remove custom OPP helper support Viresh Kumar
2022-06-25 11:42 ` Dmitry Osipenko
2022-06-27 6:06 ` Viresh Kumar
2022-06-27 6:10 ` Dmitry Osipenko [this message]
2022-06-27 6:41 ` Viresh Kumar
2022-06-27 7:09 ` Dmitry Osipenko
2022-06-27 7:19 ` Viresh Kumar
2022-06-28 10:04 ` Dmitry Osipenko
2022-06-28 11:04 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8114f7-4ee6-a9ad-f5be-ceaf64be8a0e@gmail.com \
--to=digetx@gmail.com \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.