All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Keerthy <j-keerthy@ti.com>, Dave Gerlach <d-gerlach@ti.com>,
	Nishanth Menon <nm@ti.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] OPP: Replace custom set_opp() with config_regulators()
Date: Tue, 31 May 2022 15:39:59 +0530	[thread overview]
Message-ID: <cover.1653991004.git.viresh.kumar@linaro.org> (raw)

Hi,

This series is in continuation to OPP cleanups [1] posted earlier and is rebased over them.

Currently the custom set_opp() helper, which is implemented only for omap, is responsible to set
both clock and regulators for the device and may end up doing tricky stuff behind the scene. This
makes the OPP core contain special code to support it.

This patch series tries to streamline the code path in _set_opp() in the OPP core and minimize the
platform specific code within it. The platforms provide a config_regulators() callback now, from
which they should only program the regulators in their preferred sequence. Rest of the code sequence
to program clk, bw, required-opps, etc is common across all device and platform types and is present
in the OPP core.

Keerthy/Dave: I couldn't test it on omap, can any of you do that please ? It builds just fine
though. Also maybe you can simplify the OPP driver to drop all restoration logic on failures, as the
OPP core doesn't do any of it as well. I can add a patch for that if you guys are fine with it.

This is pushed here along with other dependencies:

git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/config-regulators

Thanks.

--
Viresh

[1] https://lore.kernel.org/lkml/cover.1653564321.git.viresh.kumar@linaro.org/

Viresh Kumar (5):
  OPP: Add support for config_regulators() helper
  OPP: Make _generic_set_opp_regulator() a config_regulators() interface
  OPP: Add dev_pm_opp_get_supplies()
  OPP: ti: Migrate to config_regulators()
  OPP: Remove custom OPP helper support

 drivers/opp/core.c          | 204 +++++++++++++-----------------------
 drivers/opp/opp.h           |   9 +-
 drivers/opp/ti-opp-supply.c |  74 ++++++-------
 include/linux/pm_opp.h      |  47 +++------
 4 files changed, 118 insertions(+), 216 deletions(-)

-- 
2.31.1.272.g89b43f80a514


             reply	other threads:[~2022-05-31 10:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 10:09 Viresh Kumar [this message]
2022-05-31 10:10 ` [PATCH 1/5] OPP: Add support for config_regulators() helper Viresh Kumar
2022-05-31 10:10 ` [PATCH 2/5] OPP: Make _generic_set_opp_regulator() a config_regulators() interface Viresh Kumar
2022-05-31 10:10 ` [PATCH 3/5] OPP: Add dev_pm_opp_get_supplies() Viresh Kumar
2022-05-31 10:10 ` [PATCH 4/5] OPP: ti: Migrate to config_regulators() Viresh Kumar
2022-05-31 10:10 ` [PATCH 5/5] OPP: Remove custom OPP helper support Viresh Kumar
2022-06-25 11:42   ` Dmitry Osipenko
2022-06-27  6:06     ` Viresh Kumar
2022-06-27  6:10       ` Dmitry Osipenko
2022-06-27  6:41         ` Viresh Kumar
2022-06-27  7:09           ` Dmitry Osipenko
2022-06-27  7:19             ` Viresh Kumar
2022-06-28 10:04               ` Dmitry Osipenko
2022-06-28 11:04                 ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1653991004.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=d-gerlach@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.