Re: [PATCH v1 4/7] dt-bindings: usb: hpe,gxp-vuhc: add binding for gxp vEHCI

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: richard.yu@hpe.com, verdun@hpe.com, nick.hawkins@hpe.com,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
	balbi@kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 4/7] dt-bindings: usb: hpe,gxp-vuhc: add binding for gxp vEHCI
Date: Thu, 3 Nov 2022 12:32:26 -0400	[thread overview]
Message-ID: <4acf1dd3-afb3-b69a-5c03-05c74c4ad69c@linaro.org> (raw)
In-Reply-To: <20221103160625.15574-5-richard.yu@hpe.com>

On 03/11/2022 12:06, richard.yu@hpe.com wrote:
> From: Richard Yu <richard.yu@hpe.com>
> 
> Create documentation for the hpe,gxp-vuhc binding to support access to
> the gxp virtual EHCI controller.
> 

Previous comments apply.

> Signed-off-by: Richard Yu <richard.yu@hpe.com>
> ---
>  .../devicetree/bindings/usb/hpe,gxp-vuhc.yaml | 34 +++++++++++++++++++
>  1 file changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
> new file mode 100644
> index 000000000000..1411a2550092
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/hpe,gxp-vuhc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP Virtual Universal Host Controller (vUHC)

This is getting confusing.

If it is EHCI, you miss usb-hcd.yaml reference. But in fact you describe
at syscon, maybe to avoid proper hardware description.

That does not look right.

> +
> +maintainers:
> +  - Richard Yu <richard.yu@hpe.com>
> +  - Jean-Marie Verdun <verdun@hpe.com>
> +  - Nick Hawkins <nick.hawkins@hpe.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: hpe,gxp-vuhc
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    vuhc@80400000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +      compatible = "hpe,gxp-vuhc", "syscon";
> +      reg = <0x80400000 0x80>;
> +    };

Best regards,
Krzysztof