From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Matt Merhar <mattmerhar@protonmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management
Date: Thu, 18 Mar 2021 13:33:38 +0300 [thread overview]
Message-ID: <4ad258c7-964e-d6e7-2222-2f85030ded76@gmail.com> (raw)
In-Reply-To: <20210318093142.GB18038@qmqm.qmqm.pl>
18.03.2021 12:31, Michał Mirosław пишет:
>> static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = {
>> @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info tegra194_dc_soc_info = {
>> .has_nvdisplay = true,
>> .wgrps = tegra194_dc_wgrps,
>> .num_wgrps = ARRAY_SIZE(tegra194_dc_wgrps),
>> + .plane_tiled_memory_bandwidth_x2 = false,
>> };
> For globals you will have .x = false by default; I'm not sure those entries
> add much value.
>
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
IIRC, in the past Thierry preferred to add the defaults to this driver
in order to ease reading/understanding of the code. So I added them for
consistency.
Thank you very much for helping with the review!
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-pm@vger.kernel.org, Nicolas Chauvet <kwizart@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
Peter Geis <pgwipeout@gmail.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management
Date: Thu, 18 Mar 2021 13:33:38 +0300 [thread overview]
Message-ID: <4ad258c7-964e-d6e7-2222-2f85030ded76@gmail.com> (raw)
In-Reply-To: <20210318093142.GB18038@qmqm.qmqm.pl>
18.03.2021 12:31, Michał Mirosław пишет:
>> static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = {
>> @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info tegra194_dc_soc_info = {
>> .has_nvdisplay = true,
>> .wgrps = tegra194_dc_wgrps,
>> .num_wgrps = ARRAY_SIZE(tegra194_dc_wgrps),
>> + .plane_tiled_memory_bandwidth_x2 = false,
>> };
> For globals you will have .x = false by default; I'm not sure those entries
> add much value.
>
> Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
IIRC, in the past Thierry preferred to add the defaults to this driver
in order to ease reading/understanding of the code. So I added them for
consistency.
Thank you very much for helping with the review!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-18 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 18:57 [PATCH v16 0/2] Add memory bandwidth management to NVIDIA Tegra DRM driver Dmitry Osipenko
2021-03-17 18:57 ` Dmitry Osipenko
2021-03-17 18:57 ` [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2021-03-17 18:57 ` Dmitry Osipenko
2021-03-18 9:31 ` Michał Mirosław
2021-03-18 9:31 ` Michał Mirosław
2021-03-18 10:33 ` Dmitry Osipenko [this message]
2021-03-18 10:33 ` Dmitry Osipenko
2021-03-17 18:57 ` [PATCH v16 2/2] drm/tegra: dc: Extend debug stats with total number of events Dmitry Osipenko
2021-03-17 18:57 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad258c7-964e-d6e7-2222-2f85030ded76@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.