From: Matthias Brugger <matthias.bgg@gmail.com> To: Ryder Lee <ryder.lee@mediatek.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net> Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Wang <sean.wang@mediatek.com>, Roy Luo <cheng-hao.luo@mediatek.com> Subject: Re: [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation Date: Mon, 5 Dec 2016 11:18:06 +0100 [thread overview] Message-ID: <4b0df417-825f-65c6-4c02-85fe1c20ce50@gmail.com> (raw) In-Reply-To: <1480921284-45827-3-git-send-email-ryder.lee@mediatek.com> On 05/12/16 08:01, Ryder Lee wrote: > Add DT bindings documentation for the crypto driver > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > .../devicetree/bindings/crypto/mediatek-crypto.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > new file mode 100644 > index 0000000..8b1db08 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > @@ -0,0 +1,32 @@ > +MediaTek cryptographic accelerators > + > +Required properties: > +- compatible: Should be "mediatek,mt7623-crypto" Do you know how big the difference is between the crypto engine for mt7623/mt2701/mt8521p in comparison, let's say mt8173 or mt6797? Do this SoCs have a crypot engine? If so and they are quite similar, we might think of adding a mtk-crypto binding and add soc specific bindings. Regards, Matthias > +- reg: Address and length of the register set for the device > +- interrupts: Should contain the five crypto engines interrupts in numeric > + order. These are global system and four descriptor rings. > +- clocks: the clock used by the core > +- clock-names: the names of the clock listed in the clocks property. These are > + "ethif", "cryp" > +- power-domains: Must contain a reference to the PM domain. > + > + > +Optional properties: > +- interrupt-parent: Should be the phandle for the interrupt controller > + that services interrupts for this device > + > + > +Example: > + crypto: crypto@1b240000 { > + compatible = "mediatek,mt7623-crypto"; > + reg = <0 0x1b240000 0 0x20000>; > + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > + <ðsys CLK_ETHSYS_CRYPTO>; > + clock-names = "ethif","cryp"; > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > + }; >
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation Date: Mon, 5 Dec 2016 11:18:06 +0100 [thread overview] Message-ID: <4b0df417-825f-65c6-4c02-85fe1c20ce50@gmail.com> (raw) In-Reply-To: <1480921284-45827-3-git-send-email-ryder.lee@mediatek.com> On 05/12/16 08:01, Ryder Lee wrote: > Add DT bindings documentation for the crypto driver > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > .../devicetree/bindings/crypto/mediatek-crypto.txt | 32 ++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > new file mode 100644 > index 0000000..8b1db08 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt > @@ -0,0 +1,32 @@ > +MediaTek cryptographic accelerators > + > +Required properties: > +- compatible: Should be "mediatek,mt7623-crypto" Do you know how big the difference is between the crypto engine for mt7623/mt2701/mt8521p in comparison, let's say mt8173 or mt6797? Do this SoCs have a crypot engine? If so and they are quite similar, we might think of adding a mtk-crypto binding and add soc specific bindings. Regards, Matthias > +- reg: Address and length of the register set for the device > +- interrupts: Should contain the five crypto engines interrupts in numeric > + order. These are global system and four descriptor rings. > +- clocks: the clock used by the core > +- clock-names: the names of the clock listed in the clocks property. These are > + "ethif", "cryp" > +- power-domains: Must contain a reference to the PM domain. > + > + > +Optional properties: > +- interrupt-parent: Should be the phandle for the interrupt controller > + that services interrupts for this device > + > + > +Example: > + crypto: crypto at 1b240000 { > + compatible = "mediatek,mt7623-crypto"; > + reg = <0 0x1b240000 0 0x20000>; > + interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 83 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>, > + <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > + <ðsys CLK_ETHSYS_CRYPTO>; > + clock-names = "ethif","cryp"; > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > + }; >
next prev parent reply other threads:[~2016-12-05 10:18 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-05 7:01 [PATCH v1 0/2] Add MediaTek crypto acclelrator driver Ryder Lee 2016-12-05 7:01 ` Ryder Lee 2016-12-05 7:01 ` Ryder Lee 2016-12-05 7:01 ` [PATCH v1 1/2] Add crypto driver support for some MediaTek chips Ryder Lee 2016-12-05 7:01 ` Ryder Lee 2016-12-05 7:01 ` Ryder Lee [not found] ` <1480921284-45827-2-git-send-email-ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2016-12-05 8:52 ` Corentin Labbe 2016-12-05 8:52 ` Corentin Labbe 2016-12-05 8:52 ` Corentin Labbe 2016-12-08 9:05 ` Ryder Lee 2016-12-08 9:05 ` Ryder Lee 2016-12-08 9:05 ` Ryder Lee 2016-12-08 9:05 ` Ryder Lee 2016-12-05 7:01 ` [PATCH v1 2/2] crypto: mediatek - add DT bindings documentation Ryder Lee 2016-12-05 7:01 ` Ryder Lee 2016-12-05 7:01 ` Ryder Lee 2016-12-05 10:18 ` Matthias Brugger [this message] 2016-12-05 10:18 ` Matthias Brugger 2016-12-08 9:19 ` Ryder Lee 2016-12-08 9:19 ` Ryder Lee 2016-12-08 9:19 ` Ryder Lee 2016-12-09 9:45 ` Matthias Brugger 2016-12-09 9:45 ` Matthias Brugger 2016-12-09 9:45 ` Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4b0df417-825f-65c6-4c02-85fe1c20ce50@gmail.com \ --to=matthias.bgg@gmail.com \ --cc=cheng-hao.luo@mediatek.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=ryder.lee@mediatek.com \ --cc=sean.wang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.