From: John Garry <john.garry@huawei.com>
To: Robin Murphy <robin.murphy@arm.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
iommu <iommu@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v3 2/3] perf/smmuv3: Add a MODULE_SOFTDEP() to indicate dependency on SMMU
Date: Fri, 29 Jan 2021 15:34:33 +0000 [thread overview]
Message-ID: <4b116f38-84da-9ef9-350c-8900944b0433@huawei.com> (raw)
In-Reply-To: <67e0859b-2633-3516-527f-57557e210fa1@arm.com>
On 29/01/2021 15:12, Robin Murphy wrote:
> On 2021-01-27 11:32, Zhen Lei wrote:
>> The MODULE_SOFTDEP() gives user space a hint of the loading sequence. And
>> when command "modprobe arm_smmuv3_pmu" is executed, the arm_smmu_v3.ko is
>> automatically loaded in advance.
>
> Why do we need this? If probe order doesn't matter when both drivers are
> built-in, why should module load order?
>
> TBH I'm not sure why we even have a Kconfig dependency on ARM_SMMU_V3,
> given that the drivers operate completely independently :/
Can that Kconfig dependency just be removed? I think that it was added
under the idea that there is no point in having the SMMUv3 PMU driver
without the SMMUv3 driver.
However even on that basis it seems broken, as we cannot have
ARM_SMMU_V3=m + ARM_SMMU_V3_PMU=y.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Robin Murphy <robin.murphy@arm.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
iommu <iommu@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v3 2/3] perf/smmuv3: Add a MODULE_SOFTDEP() to indicate dependency on SMMU
Date: Fri, 29 Jan 2021 15:34:33 +0000 [thread overview]
Message-ID: <4b116f38-84da-9ef9-350c-8900944b0433@huawei.com> (raw)
In-Reply-To: <67e0859b-2633-3516-527f-57557e210fa1@arm.com>
On 29/01/2021 15:12, Robin Murphy wrote:
> On 2021-01-27 11:32, Zhen Lei wrote:
>> The MODULE_SOFTDEP() gives user space a hint of the loading sequence. And
>> when command "modprobe arm_smmuv3_pmu" is executed, the arm_smmu_v3.ko is
>> automatically loaded in advance.
>
> Why do we need this? If probe order doesn't matter when both drivers are
> built-in, why should module load order?
>
> TBH I'm not sure why we even have a Kconfig dependency on ARM_SMMU_V3,
> given that the drivers operate completely independently :/
Can that Kconfig dependency just be removed? I think that it was added
under the idea that there is no point in having the SMMUv3 PMU driver
without the SMMUv3 driver.
However even on that basis it seems broken, as we cannot have
ARM_SMMU_V3=m + ARM_SMMU_V3_PMU=y.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 15:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 11:32 [PATCH v3 0/3] perf/smmuv3: Don't reserve the PMCG register spaces Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-27 11:32 ` [PATCH v3 1/3] " Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-29 15:06 ` Robin Murphy
2021-01-29 15:06 ` Robin Murphy
2021-01-30 2:23 ` Leizhen (ThunderTown)
2021-01-30 2:23 ` Leizhen (ThunderTown)
2021-01-30 2:23 ` Leizhen (ThunderTown)
2021-01-27 11:32 ` [PATCH v3 2/3] perf/smmuv3: Add a MODULE_SOFTDEP() to indicate dependency on SMMU Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-29 15:12 ` Robin Murphy
2021-01-29 15:12 ` Robin Murphy
2021-01-29 15:34 ` John Garry [this message]
2021-01-29 15:34 ` John Garry
2021-01-29 17:03 ` Robin Murphy
2021-01-29 17:03 ` Robin Murphy
2021-01-29 17:03 ` Robin Murphy
2021-01-30 1:34 ` Leizhen (ThunderTown)
2021-01-30 1:34 ` Leizhen (ThunderTown)
2021-01-30 1:34 ` Leizhen (ThunderTown)
2021-01-27 11:32 ` [PATCH v3 3/3] iommu/arm-smmu-v3: Reserving the entire SMMU register space Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-27 11:32 ` Zhen Lei
2021-01-29 15:27 ` Robin Murphy
2021-01-29 15:27 ` Robin Murphy
2021-01-30 1:54 ` Leizhen (ThunderTown)
2021-01-30 1:54 ` Leizhen (ThunderTown)
2021-01-30 1:54 ` Leizhen (ThunderTown)
2021-02-01 11:44 ` Robin Murphy
2021-02-01 11:44 ` Robin Murphy
2021-02-01 11:44 ` Robin Murphy
2021-02-01 12:00 ` Leizhen (ThunderTown)
2021-02-01 12:00 ` Leizhen (ThunderTown)
2021-02-01 12:00 ` Leizhen (ThunderTown)
2021-01-28 20:31 ` [PATCH v3 0/3] perf/smmuv3: Don't reserve the PMCG register spaces Will Deacon
2021-01-28 20:31 ` Will Deacon
2021-01-28 20:31 ` Will Deacon
2021-01-29 13:15 ` Leizhen (ThunderTown)
2021-01-29 13:15 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b116f38-84da-9ef9-350c-8900944b0433@huawei.com \
--to=john.garry@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=thunder.leizhen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.