Re: [PATCH v3 2/3] x86/ioreq server: Add new functions to get/set memory types.

From: "Yu, Zhang" <yu.c.zhang@linux.intel.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xen.org, Paul.Durrant@citrix.com,
	zhiyuan.lv@intel.com, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v3 2/3] x86/ioreq server: Add new functions to get/set memory types.
Date: Wed, 27 Apr 2016 17:11:56 +0800	[thread overview]
Message-ID: <4b7568fb-f720-7a65-d18e-0321361d0e70@linux.intel.com> (raw)
In-Reply-To: <20160426105331.GG20763@citrix.com>

On 4/26/2016 6:53 PM, Wei Liu wrote:
> Hi Yu
>
> On Mon, Apr 25, 2016 at 06:35:39PM +0800, Yu Zhang wrote:
>> For clarity this patch breaks the code to set/get memory types out
>> of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type().
>> Also, for clarity, checks for whether a memory type change is allowed
>> are broken out into a separate function called by hvmop_set_mem_type().
>>
>> There is no intentional functional change in this patch.
>>
>> changes in v3:
>>   - Add Andrew's Acked-by and George's Reviewed-by.
>>
>> changes in v2:
>>   - According to George Dunlap's comments, follow the "set rc /
>>     do something / goto out" pattern in hvmop_get_mem_type().
>>
>
> Normally we put these changelogs (or other information that is not
> intended to be committed) between "---" so that they are ignored
> when committing. Here is one example:
>
> https://marc.info/?l=xen-devel&m=146056699332101
>
> Note the Cc and some extra words inside surrounded by two "---". They
> will be ignored when committing.
>

Oh. Thanks for your information, Wei. :)

B.R.
Yu

> The code itself looks good to me.
>
> Wei.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel