All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH v4 31/41] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip()
Date: Fri, 15 Sep 2023 10:53:46 +0200	[thread overview]
Message-ID: <4c87bb31403d142f8f146176cb859a10a28a3601.1694767209.git.geert+renesas@glider.be> (raw)
In-Reply-To: <cover.1694767208.git.geert+renesas@glider.be>

Move the shmob_drm_crtc_finish_page_flip() function up, to avoid having
to move it during the modification in the next change.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v4:
  - No changes,

v3:
  - No changes,

v2:
  - Add Reviewed-by,
  - Move further up.
---
 .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 36 ++++++++++---------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
index f55b5263e611c782..0adf5d33ba31695e 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
@@ -35,6 +35,26 @@
  * TODO: panel support
  */
 
+/* -----------------------------------------------------------------------------
+ * Page Flip
+ */
+
+void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc)
+{
+	struct drm_pending_vblank_event *event;
+	struct drm_device *dev = scrtc->base.dev;
+	unsigned long flags;
+
+	spin_lock_irqsave(&dev->event_lock, flags);
+	event = scrtc->event;
+	scrtc->event = NULL;
+	if (event) {
+		drm_crtc_send_vblank_event(&scrtc->base, event);
+		drm_crtc_vblank_put(&scrtc->base);
+	}
+	spin_unlock_irqrestore(&dev->event_lock, flags);
+}
+
 /* -----------------------------------------------------------------------------
  * CRTC
  */
@@ -364,22 +384,6 @@ static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
 	.mode_set_base = shmob_drm_crtc_mode_set_base,
 };
 
-void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc)
-{
-	struct drm_pending_vblank_event *event;
-	struct drm_device *dev = scrtc->base.dev;
-	unsigned long flags;
-
-	spin_lock_irqsave(&dev->event_lock, flags);
-	event = scrtc->event;
-	scrtc->event = NULL;
-	if (event) {
-		drm_crtc_send_vblank_event(&scrtc->base, event);
-		drm_crtc_vblank_put(&scrtc->base);
-	}
-	spin_unlock_irqrestore(&dev->event_lock, flags);
-}
-
 static int shmob_drm_crtc_page_flip(struct drm_crtc *crtc,
 				    struct drm_framebuffer *fb,
 				    struct drm_pending_vblank_event *event,
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v4 31/41] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip()
Date: Fri, 15 Sep 2023 10:53:46 +0200	[thread overview]
Message-ID: <4c87bb31403d142f8f146176cb859a10a28a3601.1694767209.git.geert+renesas@glider.be> (raw)
In-Reply-To: <cover.1694767208.git.geert+renesas@glider.be>

Move the shmob_drm_crtc_finish_page_flip() function up, to avoid having
to move it during the modification in the next change.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
v4:
  - No changes,

v3:
  - No changes,

v2:
  - Add Reviewed-by,
  - Move further up.
---
 .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 36 ++++++++++---------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
index f55b5263e611c782..0adf5d33ba31695e 100644
--- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
+++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
@@ -35,6 +35,26 @@
  * TODO: panel support
  */
 
+/* -----------------------------------------------------------------------------
+ * Page Flip
+ */
+
+void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc)
+{
+	struct drm_pending_vblank_event *event;
+	struct drm_device *dev = scrtc->base.dev;
+	unsigned long flags;
+
+	spin_lock_irqsave(&dev->event_lock, flags);
+	event = scrtc->event;
+	scrtc->event = NULL;
+	if (event) {
+		drm_crtc_send_vblank_event(&scrtc->base, event);
+		drm_crtc_vblank_put(&scrtc->base);
+	}
+	spin_unlock_irqrestore(&dev->event_lock, flags);
+}
+
 /* -----------------------------------------------------------------------------
  * CRTC
  */
@@ -364,22 +384,6 @@ static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
 	.mode_set_base = shmob_drm_crtc_mode_set_base,
 };
 
-void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc)
-{
-	struct drm_pending_vblank_event *event;
-	struct drm_device *dev = scrtc->base.dev;
-	unsigned long flags;
-
-	spin_lock_irqsave(&dev->event_lock, flags);
-	event = scrtc->event;
-	scrtc->event = NULL;
-	if (event) {
-		drm_crtc_send_vblank_event(&scrtc->base, event);
-		drm_crtc_vblank_put(&scrtc->base);
-	}
-	spin_unlock_irqrestore(&dev->event_lock, flags);
-}
-
 static int shmob_drm_crtc_page_flip(struct drm_crtc *crtc,
 				    struct drm_framebuffer *fb,
 				    struct drm_pending_vblank_event *event,
-- 
2.34.1


  parent reply	other threads:[~2023-09-15  8:55 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  8:53 [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support Geert Uytterhoeven
2023-09-15  8:53 ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 01/41] MAINTAINER: Create entry for Renesas SH-Mobile DRM drivers Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 02/41] dt-bindings: display: Add Renesas SH-Mobile LCDC bindings Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 03/41] media: uapi: Add MEDIA_BUS_FMT_RGB666_2X9_BE format Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 04/41] drm: renesas: shmobile: Fix overlay plane disable Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 05/41] drm: renesas: shmobile: Fix ARGB32 overlay format typo Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 06/41] drm: renesas: shmobile: Correct encoder/connector types Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 07/41] drm: renesas: shmobile: Add support for Runtime PM Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 08/41] drm: renesas: shmobile: Restore indentation of shmob_drm_setup_clocks() Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 09/41] drm: renesas: shmobile: Use %p4cc to print fourcc code Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 10/41] drm: renesas: shmobile: Add missing YCbCr formats Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 11/41] drm: renesas: shmobile: Improve shmob_drm_format_info table Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 12/41] drm: renesas: shmobile: Remove backlight support Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 13/41] drm: renesas: shmobile: Don't set display info width and height twice Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 14/41] drm: renesas: shmobile: Rename input clocks Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 15/41] drm: renesas: shmobile: Remove support for SYS panels Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 16/41] drm: renesas: shmobile: Improve error handling Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 17/41] drm: renesas: shmobile: Convert to use devm_request_irq() Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 18/41] drm: renesas: shmobile: Remove custom plane destroy callback Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 19/41] drm: renesas: shmobile: Use drmm_universal_plane_alloc() Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 20/41] drm: renesas: shmobile: Embed drm_device in shmob_drm_device Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 21/41] drm: renesas: shmobile: Convert container helpers to static inline functions Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 22/41] drm: renesas: shmobile: Replace .dev_private with container_of() Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 23/41] drm: renesas: shmobile: Use struct videomode in platform data Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 24/41] drm: renesas: shmobile: Use media bus formats " Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 25/41] drm: renesas: shmobile: Move interface handling to connector setup Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 26/41] drm: renesas: shmobile: Unify plane allocation Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 27/41] drm: renesas: shmobile: Rename shmob_drm_crtc.crtc Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 28/41] drm: renesas: shmobile: Rename shmob_drm_connector.connector Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 29/41] drm: renesas: shmobile: Rename shmob_drm_plane.plane Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 30/41] drm: renesas: shmobile: Use drm_crtc_handle_vblank() Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` Geert Uytterhoeven [this message]
2023-09-15  8:53   ` [PATCH v4 31/41] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip() Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 32/41] drm: renesas: shmobile: Wait for page flip when turning CRTC off Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 33/41] drm: renesas: shmobile: Turn vblank on/off when enabling/disabling CRTC Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 34/41] drm: renesas: shmobile: Shutdown the display on remove Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 35/41] drm: renesas: shmobile: Cleanup encoder Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 36/41] drm: renesas: shmobile: Atomic conversion part 1 Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 37/41] drm: renesas: shmobile: Atomic conversion part 2 Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 38/41] drm: renesas: shmobile: Use suspend/resume helpers Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 39/41] drm: renesas: shmobile: Remove internal CRTC state tracking Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 40/41] drm: renesas: shmobile: Atomic conversion part 3 Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-15  8:53 ` [PATCH v4 41/41] drm: renesas: shmobile: Add DT support Geert Uytterhoeven
2023-09-15  8:53   ` Geert Uytterhoeven
2023-09-19 14:28 ` [GIT PULL] drm: renesas: shmobile: Atomic conversion + DT support (was: Re: [PATCH v4 00/41] drm: renesas: shmobile: Atomic conversion + DT support) Geert Uytterhoeven
2023-09-19 14:28   ` Geert Uytterhoeven
2023-09-19 15:24   ` Laurent Pinchart
2023-09-19 15:24     ` Laurent Pinchart
2023-09-26 14:51     ` Geert Uytterhoeven
2023-09-26 14:51       ` Geert Uytterhoeven
2023-10-06  6:57       ` Geert Uytterhoeven
2023-10-06  6:57         ` Geert Uytterhoeven
2023-10-16  9:59   ` [GIT PULL v2] " Geert Uytterhoeven
2023-10-16  9:59     ` Geert Uytterhoeven
2023-10-24 10:08     ` Geert Uytterhoeven
2023-10-24 10:08       ` Geert Uytterhoeven
2023-10-27  8:09       ` Geert Uytterhoeven
2023-10-27  8:09         ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c87bb31403d142f8f146176cb859a10a28a3601.1694767209.git.geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.