From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org
Cc: Rajkumar Manoharan <rmanohar@codeaurora.org>,
ath10k@lists.infradead.org, make-wifi-fast@lists.bufferbloat.net
Subject: Re: [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function
Date: Fri, 25 Jan 2019 14:25:50 +0100 [thread overview]
Message-ID: <4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net> (raw)
In-Reply-To: <20190122142019.21417-2-toke@redhat.com> (sfid-20190122_152134_612942_99BDC416)
> +void ieee80211_schedule_txq(struct ieee80211_hw *hw,
> + struct ieee80211_txq *txq)
> + __acquires(txq_lock) __releases(txq_lock)
> +{
> + struct ieee80211_local *local = hw_to_local(hw);
> + struct txq_info *txqi = to_txq_info(txq);
> +
> + spin_lock_bh(&local->active_txq_lock[txq->ac]);
> + ieee80211_return_txq(hw, txq);
> + spin_unlock_bh(&local->active_txq_lock[ac]);
>
Maybe v6 had txq->ac here instead of just ac which doesn't compile ;-)
I fixed it up, but I hope you tested a compiling version :P
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org
Cc: make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org,
Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function
Date: Fri, 25 Jan 2019 14:25:50 +0100 [thread overview]
Message-ID: <4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net> (raw)
In-Reply-To: <20190122142019.21417-2-toke@redhat.com> (sfid-20190122_152134_612942_99BDC416)
> +void ieee80211_schedule_txq(struct ieee80211_hw *hw,
> + struct ieee80211_txq *txq)
> + __acquires(txq_lock) __releases(txq_lock)
> +{
> + struct ieee80211_local *local = hw_to_local(hw);
> + struct txq_info *txqi = to_txq_info(txq);
> +
> + spin_lock_bh(&local->active_txq_lock[txq->ac]);
> + ieee80211_return_txq(hw, txq);
> + spin_unlock_bh(&local->active_txq_lock[ac]);
>
Maybe v6 had txq->ac here instead of just ac which doesn't compile ;-)
I fixed it up, but I hope you tested a compiling version :P
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-01-25 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 14:20 [PATCH v6 0/4] Switch ath9k and ath10k to mac80211 airtime framework Toke Høiland-Jørgensen
2019-01-22 14:20 ` Toke Høiland-Jørgensen
2019-01-22 14:20 ` [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function Toke Høiland-Jørgensen
2019-01-22 14:20 ` Toke Høiland-Jørgensen
2019-01-22 14:23 ` Toke Høiland-Jørgensen
2019-01-22 14:23 ` Toke Høiland-Jørgensen
2019-01-25 13:25 ` Johannes Berg [this message]
2019-01-25 13:25 ` Johannes Berg
2019-01-25 13:31 ` Toke Høiland-Jørgensen
2019-01-25 13:31 ` Toke Høiland-Jørgensen
2019-01-22 14:20 ` [PATCH v6 2/4] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs Toke Høiland-Jørgensen
2019-01-22 14:20 ` Toke Høiland-Jørgensen
2019-02-12 18:45 ` Kalle Valo
2019-02-12 18:45 ` Kalle Valo
2019-01-22 14:20 ` [PATCH v6 3/4] ath10k: migrate to mac80211 txq scheduling Toke Høiland-Jørgensen
2019-01-22 14:20 ` Toke Høiland-Jørgensen
2019-01-22 14:47 ` Sebastian Gottschall
2019-01-22 14:20 ` [PATCH v6 4/4] ath10k: reporting estimated tx airtime for fairness Toke Høiland-Jørgensen
2019-01-22 14:20 ` Toke Høiland-Jørgensen
2019-01-24 19:28 ` Kan Yan
2019-01-24 19:28 ` Kan Yan
2019-01-25 8:31 ` Toke Høiland-Jørgensen
2019-01-25 8:31 ` Toke Høiland-Jørgensen
2019-02-11 9:24 ` Kalle Valo
2019-02-11 9:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=rmanohar@codeaurora.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.