All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <david@lechnology.com>
To: robh@kernel.org
Cc: bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
	grzegorz.jaszczyk@linaro.org, lee.jones@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, mathieu.poirier@linaro.org,
	ohad@wizery.com, praneeth@ti.com, rogerq@ti.com, s-anna@ti.com,
	ssantosh@kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: remoteproc: Add PRU consumer bindings
Date: Mon, 4 Jan 2021 13:56:01 -0600	[thread overview]
Message-ID: <4fd5d68a-830a-83df-fc7a-1070e2619a86@lechnology.com> (raw)
In-Reply-To: <CAL_Jsq+W8GuqKdqSxt7bKcfpK3Wg35V9R-3+UzNi_+3uRqA=AQ@mail.gmail.com>


> Also, I think you can get rid of 'ti,pruss-gp-mux-sel'. Can't it just
> be an arg cell in 'ti,prus' entries?
> 
> Rob

+1 for using cells instead of a separate property.

FYI, we will have a similar issue with the PRUSSEVTSEL signal for the
interrupt controller on the AM18XX. I am still of the opinion (described
in more detail at [1]) that using a cell for this makes for both better
device tree bindings and easier driver implementation. So I am interested
to see what the resolution is here.

[1]: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20190708035243.12170-5-s-anna@ti.com/

WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com>
To: robh@kernel.org
Cc: ohad@wizery.com, devicetree@vger.kernel.org,
	grzegorz.jaszczyk@linaro.org, mathieu.poirier@linaro.org,
	praneeth@ti.com, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
	ssantosh@kernel.org, linux-omap@vger.kernel.org,
	lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org,
	rogerq@ti.com
Subject: Re: [PATCH 1/5] dt-bindings: remoteproc: Add PRU consumer bindings
Date: Mon, 4 Jan 2021 13:56:01 -0600	[thread overview]
Message-ID: <4fd5d68a-830a-83df-fc7a-1070e2619a86@lechnology.com> (raw)
In-Reply-To: <CAL_Jsq+W8GuqKdqSxt7bKcfpK3Wg35V9R-3+UzNi_+3uRqA=AQ@mail.gmail.com>


> Also, I think you can get rid of 'ti,pruss-gp-mux-sel'. Can't it just
> be an arg cell in 'ti,prus' entries?
> 
> Rob

+1 for using cells instead of a separate property.

FYI, we will have a similar issue with the PRUSSEVTSEL signal for the
interrupt controller on the AM18XX. I am still of the opinion (described
in more detail at [1]) that using a cell for this makes for both better
device tree bindings and easier driver implementation. So I am interested
to see what the resolution is here.

[1]: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20190708035243.12170-5-s-anna@ti.com/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-04 20:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 14:29 [PATCH 0/5] Introduce PRU remoteproc consumer API Grzegorz Jaszczyk
2020-12-11 14:29 ` Grzegorz Jaszczyk
2020-12-11 14:29 ` [PATCH 1/5] dt-bindings: remoteproc: Add PRU consumer bindings Grzegorz Jaszczyk
2020-12-11 14:29   ` Grzegorz Jaszczyk
2020-12-14 22:58   ` Rob Herring
2020-12-14 22:58     ` Rob Herring
2020-12-16 15:55     ` Grzegorz Jaszczyk
2020-12-16 15:55       ` Grzegorz Jaszczyk
2020-12-18 22:50       ` Rob Herring
2020-12-18 22:50         ` Rob Herring
2020-12-22 15:57         ` Grzegorz Jaszczyk
2020-12-22 15:57           ` Grzegorz Jaszczyk
2020-12-31 19:14           ` Rob Herring
2020-12-31 19:14             ` Rob Herring
2021-01-04 19:56             ` David Lechner [this message]
2021-01-04 19:56               ` David Lechner
2020-12-11 14:29 ` [PATCH 2/5] remoteproc: pru: Add APIs to get and put the PRU cores Grzegorz Jaszczyk
2020-12-11 14:29   ` Grzegorz Jaszczyk
2020-12-11 14:29 ` [PATCH 3/5] remoteproc: pru: Deny rproc sysfs ops for PRU client driven boots Grzegorz Jaszczyk
2020-12-11 14:29   ` Grzegorz Jaszczyk
2020-12-11 14:29 ` [PATCH 4/5] remoteproc: pru: Add pru_rproc_set_ctable() function Grzegorz Jaszczyk
2020-12-11 14:29   ` Grzegorz Jaszczyk
2020-12-11 14:29 ` [PATCH 5/5] remoteproc: pru: Configure firmware based on client setup Grzegorz Jaszczyk
2020-12-11 14:29   ` Grzegorz Jaszczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fd5d68a-830a-83df-fc7a-1070e2619a86@lechnology.com \
    --to=david@lechnology.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grzegorz.jaszczyk@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@ti.com \
    --cc=s-anna@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.