From: Markus Elfring <Markus.Elfring@web.de> To: Ayush Singh <ayushdevel1325@gmail.com>, Vaishnav M A <vaishnav@beagleboard.org>, devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorforlinux@beagleboard.org, greybus-dev@lists.linaro.org Cc: LKML <linux-kernel@vger.kernel.org>, Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Conor Dooley <conor+dt@kernel.org>, Derek Kiernan <derek.kiernan@amd.com>, Dragan Cvetic <dragan.cvetic@amd.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jason Kridner <jkridner@beagleboard.org>, Johan Hovold <johan@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mark Brown <broonie@kernel.org>, Nishanth Menon <nm@ti.com>, Rob Herring <robh@kernel.org>, Robert Nelson <robertcnelson@beagleboard.org>, Tero Kristo <kristo@kernel.org>, Vaishnav M A <vaishnav.a@ti.com>, Vignesh Raghavendra <vigneshr@ti.com> Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver Date: Mon, 18 Mar 2024 18:58:10 +0100 [thread overview] Message-ID: <4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de> (raw) In-Reply-To: <20240317193714.403132-5-ayushdevel1325@gmail.com> … > +++ b/drivers/misc/mikrobus/mikrobus_core.c … > +static int mikrobus_pinctrl_setup(struct mikrobus_port *port, > + struct addon_board_info *board) > +{ > + int ret; > + > + if (!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) > + ret = mikrobus_pinctrl_select(port, "pwm_default"); > + else > + ret = mikrobus_pinctrl_select(port, "pwm_gpio"); … How do you think about to avoid the specification of a bit of duplicate source code here by using conditional operator expressions? ret = mikrobus_pinctrl_select(port, ((!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) ? "pwm_default" : "pwm_gpio")); Regards, Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de> To: Ayush Singh <ayushdevel1325@gmail.com>, Vaishnav M A <vaishnav@beagleboard.org>, devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorforlinux@beagleboard.org, greybus-dev@lists.linaro.org Cc: LKML <linux-kernel@vger.kernel.org>, Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Conor Dooley <conor+dt@kernel.org>, Derek Kiernan <derek.kiernan@amd.com>, Dragan Cvetic <dragan.cvetic@amd.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jason Kridner <jkridner@beagleboard.org>, Johan Hovold <johan@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mark Brown <broonie@kernel.org>, Nishanth Menon <nm@ti.com>, Rob Herring <robh@kernel.org>, Robert Nelson <robertcnelson@beagleboard.org>, Tero Kristo <kristo@kernel.org>, Vaishnav M A <vaishnav.a@ti.com>, Vignesh Raghavendra <vigneshr@ti.com> Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver Date: Mon, 18 Mar 2024 18:58:10 +0100 [thread overview] Message-ID: <4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de> (raw) In-Reply-To: <20240317193714.403132-5-ayushdevel1325@gmail.com> … > +++ b/drivers/misc/mikrobus/mikrobus_core.c … > +static int mikrobus_pinctrl_setup(struct mikrobus_port *port, > + struct addon_board_info *board) > +{ > + int ret; > + > + if (!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) > + ret = mikrobus_pinctrl_select(port, "pwm_default"); > + else > + ret = mikrobus_pinctrl_select(port, "pwm_gpio"); … How do you think about to avoid the specification of a bit of duplicate source code here by using conditional operator expressions? ret = mikrobus_pinctrl_select(port, ((!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM) ? "pwm_default" : "pwm_gpio")); Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-18 17:58 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-17 19:37 [PATCH v4 0/5] misc: Add mikroBUS driver Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-17 19:37 ` [PATCH v4 1/5] dt-bindings: misc: Add mikrobus-connector Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-18 12:22 ` Michael Walle 2024-03-18 12:22 ` Michael Walle 2024-03-18 17:20 ` Ayush Singh 2024-03-18 17:20 ` Ayush Singh 2024-03-19 5:58 ` Krzysztof Kozlowski 2024-03-19 5:58 ` Krzysztof Kozlowski 2024-03-19 7:36 ` Ayush Singh 2024-03-19 7:36 ` Ayush Singh 2024-03-19 9:38 ` Michael Walle 2024-03-19 9:38 ` Michael Walle 2024-03-19 11:36 ` Ayush Singh 2024-03-19 11:36 ` Ayush Singh 2024-03-19 12:08 ` Michael Walle 2024-03-19 12:08 ` Michael Walle 2024-03-19 13:03 ` Ayush Singh 2024-03-19 13:03 ` Ayush Singh 2024-03-19 14:21 ` Michael Walle 2024-03-19 14:21 ` Michael Walle 2024-03-19 17:19 ` Vaishnav Achath 2024-03-19 17:19 ` Vaishnav Achath 2024-03-19 17:35 ` Ayush Singh 2024-03-19 17:35 ` Ayush Singh 2024-03-19 19:32 ` Andrew Lunn 2024-03-19 19:32 ` Andrew Lunn 2024-03-20 16:39 ` Ayush Singh 2024-03-20 16:39 ` Ayush Singh 2024-03-20 18:44 ` Andrew Lunn 2024-03-20 18:44 ` Andrew Lunn 2024-03-21 7:35 ` Vaishnav Achath 2024-03-21 7:35 ` Vaishnav Achath 2024-03-21 12:31 ` Andrew Lunn 2024-03-21 12:31 ` Andrew Lunn 2024-03-19 12:25 ` Andrew Lunn 2024-03-19 12:25 ` Andrew Lunn 2024-03-19 17:35 ` Vaishnav Achath 2024-03-19 17:35 ` Vaishnav Achath 2024-03-19 18:19 ` Conor Dooley 2024-03-19 18:19 ` Conor Dooley 2024-03-21 6:30 ` Vaishnav Achath 2024-03-21 6:30 ` Vaishnav Achath 2024-03-19 19:23 ` Andrew Lunn 2024-03-19 19:23 ` Andrew Lunn 2024-03-21 7:07 ` Vaishnav Achath 2024-03-21 7:07 ` Vaishnav Achath 2024-03-21 9:38 ` Michael Walle 2024-03-21 9:38 ` Michael Walle 2024-03-21 11:55 ` Vaishnav Achath 2024-03-21 11:55 ` Vaishnav Achath 2024-03-21 12:44 ` Michael Walle 2024-03-21 12:44 ` Michael Walle 2024-03-21 12:55 ` Andrew Lunn 2024-03-21 12:55 ` Andrew Lunn 2024-03-19 6:03 ` Krzysztof Kozlowski 2024-03-19 6:03 ` Krzysztof Kozlowski 2024-03-19 6:42 ` Ayush Singh 2024-03-19 6:42 ` Ayush Singh 2024-03-19 19:37 ` Conor Dooley 2024-03-19 19:37 ` Conor Dooley 2024-03-22 18:15 ` Ayush Singh 2024-03-22 18:15 ` Ayush Singh 2024-03-22 18:51 ` Andrew Lunn 2024-03-22 18:51 ` Andrew Lunn 2024-03-17 19:37 ` [PATCH v4 2/5] spi: Make of_find_spi_controller_by_node() available Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-19 8:16 ` Markus Elfring 2024-03-19 8:16 ` Markus Elfring 2024-03-17 19:37 ` [PATCH v4 3/5] greybus: Add mikroBUS manifest types Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-19 8:26 ` Vaishnav Achath 2024-03-19 8:26 ` Vaishnav Achath 2024-03-17 19:37 ` [PATCH v4 4/5] mikrobus: Add mikroBUS driver Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-17 19:59 ` Randy Dunlap 2024-03-17 19:59 ` Randy Dunlap 2024-03-18 17:34 ` Markus Elfring 2024-03-18 17:34 ` Markus Elfring 2024-03-18 17:58 ` Markus Elfring [this message] 2024-03-18 17:58 ` Markus Elfring 2024-03-18 18:41 ` Alex Elder 2024-03-18 18:41 ` Alex Elder 2024-03-18 18:55 ` Greg Kroah-Hartman 2024-03-18 18:55 ` Greg Kroah-Hartman 2024-03-18 18:12 ` Markus Elfring 2024-03-18 18:12 ` Markus Elfring 2024-03-19 6:04 ` Krzysztof Kozlowski 2024-03-19 6:04 ` Krzysztof Kozlowski 2024-03-19 6:47 ` Ayush Singh 2024-03-19 6:47 ` Ayush Singh 2024-03-19 8:00 ` Vaishnav Achath 2024-03-19 8:00 ` Vaishnav Achath 2024-03-20 7:33 ` Krzysztof Kozlowski 2024-03-20 7:33 ` Krzysztof Kozlowski 2024-03-19 8:49 ` Vaishnav Achath 2024-03-19 8:49 ` Vaishnav Achath 2024-03-17 19:37 ` [PATCH v4 5/5] dts: ti: k3-am625-beagleplay: Add mikroBUS Ayush Singh 2024-03-17 19:37 ` Ayush Singh 2024-03-19 5:59 ` Krzysztof Kozlowski 2024-03-19 5:59 ` Krzysztof Kozlowski 2024-03-19 6:34 ` Ayush Singh 2024-03-19 6:34 ` Ayush Singh 2024-03-20 7:31 ` Krzysztof Kozlowski 2024-03-20 7:31 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4fe6f68a-786c-4e3d-b97d-847d6965d1d3@web.de \ --to=markus.elfring@web.de \ --cc=arnd@arndb.de \ --cc=ayushdevel1325@gmail.com \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=derek.kiernan@amd.com \ --cc=devicetree@vger.kernel.org \ --cc=dragan.cvetic@amd.com \ --cc=elder@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=greybus-dev@lists.linaro.org \ --cc=jkridner@beagleboard.org \ --cc=johan@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=lorforlinux@beagleboard.org \ --cc=nm@ti.com \ --cc=robertcnelson@beagleboard.org \ --cc=robh@kernel.org \ --cc=vaishnav.a@ti.com \ --cc=vaishnav@beagleboard.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.