From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Cc: "Vinod Koul" <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "Rob Herring" <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "Dan Williams" <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers Date: Fri, 13 Jul 2012 15:54:27 +0200 [thread overview] Message-ID: <50002893.6030700@atmel.com> (raw) In-Reply-To: <1342182734-321-9-git-send-email-y> On 07/13/2012 02:32 PM, y@pengutronix.de : > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > This prepares of_device_id.data becoming const. Without this change > the following warning would occur: > > drivers/dma/at_hdmac.c: In function 'at_dma_get_driver_data': > drivers/dma/at_hdmac.c:1228: warning: return discards qualifiers from pointer target type > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > --- > drivers/dma/at_hdmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 7292aa8..7e9d265 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -1217,7 +1217,7 @@ static const struct platform_device_id atdma_devtypes[] = { > } > }; > > -static inline struct at_dma_platform_data * __init at_dma_get_driver_data( > +static inline const struct at_dma_platform_data * __init at_dma_get_driver_data( > struct platform_device *pdev) > { > if (pdev->dev.of_node) { > @@ -1255,7 +1255,7 @@ static int __init at_dma_probe(struct platform_device *pdev) > int irq; > int err; > int i; > - struct at_dma_platform_data *plat_dat; > + const struct at_dma_platform_data *plat_dat; > > /* setup platform data for each SoC */ > dma_cap_set(DMA_MEMCPY, at91sam9rl_config.cap_mask); > -- Nicolas Ferre _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers Date: Fri, 13 Jul 2012 15:54:27 +0200 [thread overview] Message-ID: <50002893.6030700@atmel.com> (raw) In-Reply-To: <1342182734-321-9-git-send-email-y> On 07/13/2012 02:32 PM, y at pengutronix.de : > From: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> > > This prepares of_device_id.data becoming const. Without this change > the following warning would occur: > > drivers/dma/at_hdmac.c: In function 'at_dma_get_driver_data': > drivers/dma/at_hdmac.c:1228: warning: return discards qualifiers from pointer target type > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > --- > drivers/dma/at_hdmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index 7292aa8..7e9d265 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -1217,7 +1217,7 @@ static const struct platform_device_id atdma_devtypes[] = { > } > }; > > -static inline struct at_dma_platform_data * __init at_dma_get_driver_data( > +static inline const struct at_dma_platform_data * __init at_dma_get_driver_data( > struct platform_device *pdev) > { > if (pdev->dev.of_node) { > @@ -1255,7 +1255,7 @@ static int __init at_dma_probe(struct platform_device *pdev) > int irq; > int err; > int i; > - struct at_dma_platform_data *plat_dat; > + const struct at_dma_platform_data *plat_dat; > > /* setup platform data for each SoC */ > dma_cap_set(DMA_MEMCPY, at91sam9rl_config.cap_mask); > -- Nicolas Ferre
next prev parent reply other threads:[~2012-07-13 13:54 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-13 12:32 [PATCH 00/11] make struct of_device_id.data const y at pengutronix.de 2012-07-13 12:32 ` [PATCH 0/9] " y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 01/11] spi/imx: make spi_imx_data.devtype_data member point to const data y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y at pengutronix.de 2012-07-13 12:32 ` [PATCH 02/11] serial/imx: make imx_port.devdata " y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y at pengutronix.de 2012-07-13 12:32 ` [PATCH 03/11] ARM: cache-l2x0: add a const qualifier y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 04/11] misc/atmel_tc: make atmel_tc.tcb_config member point to const data y 2012-07-13 12:32 ` y at pengutronix.de 2012-07-13 13:40 ` Nicolas Ferre 2012-07-13 13:40 ` Nicolas Ferre 2012-07-13 12:32 ` [PATCH 05/11] gpio/gpio-omap.c: add a const qualifier y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 06/11] i2c/i2c-omap: " y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y at pengutronix.de 2012-07-13 12:32 ` [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers y at pengutronix.de 2012-07-13 13:54 ` Nicolas Ferre [this message] 2012-07-13 13:54 ` Nicolas Ferre 2012-07-16 6:38 ` Vinod Koul 2012-07-16 6:38 ` Vinod Koul 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 08/11] spi/spi-omap2-mcspi: add a const qualifier y 2012-07-13 12:32 ` y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 09/11] mmc/omap_hsmmc: " y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 10/11] of: add const to struct of_device_id.data y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:32 ` [PATCH 11/11] gpio/gpio-omap: make platformdata used as of_device_id.data const y at pengutronix.de 2012-07-13 12:32 ` y 2012-07-13 12:39 ` [PATCH 00/11] make struct " Uwe Kleine-König 2012-07-13 12:39 ` Uwe Kleine-König 2012-07-13 12:41 ` Rob Herring 2012-07-13 12:41 ` Rob Herring [not found] ` <5000175E.4070702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2012-07-13 13:46 ` Uwe Kleine-König 2012-07-13 13:46 ` Uwe Kleine-König [not found] ` <20120713134638.GH592-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 16:24 ` Arnd Bergmann 2012-07-13 16:24 ` Arnd Bergmann [not found] ` <201207131624.27266.arnd-r2nGTMty4D4@public.gmane.org> 2012-07-13 17:49 ` Uwe Kleine-König 2012-07-13 17:49 ` Uwe Kleine-König [not found] ` <20120713174935.GN592-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-07-13 18:56 ` Arnd Bergmann 2012-07-13 18:56 ` Arnd Bergmann 2012-07-13 19:48 ` Rob Herring 2012-07-13 19:48 ` Rob Herring 2012-07-13 19:36 ` Grant Likely 2012-07-13 19:36 ` Grant Likely [not found] ` <CACxGe6tXvz+rt2yrHHaD=j94-=JQEh06sHW0FWGiHb2=9GS2pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2012-07-14 18:31 ` Uwe Kleine-König 2012-07-14 18:31 ` Uwe Kleine-König
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50002893.6030700@atmel.com \ --to=nicolas.ferre-aife0yeh4naavxtiumwx3w@public.gmane.org \ --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \ --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.