From: Shubhrajyoti <shubhrajyoti@ti.com>
To: "ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, linux@arm.linux.org.uk,
gregkh@linuxfoundation.org, b-cousson@ti.com, rnayak@ti.com,
tony@atomide.com, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, balbi@ti.com,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy
Date: Mon, 30 Jul 2012 15:34:23 +0530 [thread overview]
Message-ID: <50165C27.3010107@ti.com> (raw)
In-Reply-To: <CAAe_U6LWEiAE8TVVEQ5LcKy0_+J7Er2vP71MrQVrg=ZteyAeCw@mail.gmail.com>
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti <shubhrajyoti@ti.com> wrote:
>> On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote:
>>> + writel(~PHY_PD, phy->control_dev);
>>> + /* XXX: add proper documentation for this delay */
>>> + mdelay(200);
>> Do you need this to be busy?
> This might be called from interrupt context. This delay was initially
> added in omap_phy_internal.c and I just inherited it.
Thanks for the explanation.
> Thanks
> Kishon
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy
Date: Mon, 30 Jul 2012 15:34:23 +0530 [thread overview]
Message-ID: <50165C27.3010107@ti.com> (raw)
In-Reply-To: <CAAe_U6LWEiAE8TVVEQ5LcKy0_+J7Er2vP71MrQVrg=ZteyAeCw@mail.gmail.com>
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti <shubhrajyoti@ti.com> wrote:
>> On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote:
>>> + writel(~PHY_PD, phy->control_dev);
>>> + /* XXX: add proper documentation for this delay */
>>> + mdelay(200);
>> Do you need this to be busy?
> This might be called from interrupt context. This delay was initially
> added in omap_phy_internal.c and I just inherited it.
Thanks for the explanation.
> Thanks
> Kishon
next prev parent reply other threads:[~2012-07-30 10:04 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 9:09 [PATCH v6 00/11] omap: musb: Add device tree support Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:37 ` Shubhrajyoti
2012-07-30 9:37 ` Shubhrajyoti
2012-07-30 9:46 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:46 ` ABRAHAM, KISHON VIJAY
2012-07-30 10:04 ` Shubhrajyoti [this message]
2012-07-30 10:04 ` Shubhrajyoti
2012-08-03 13:27 ` Felipe Balbi
2012-08-03 13:27 ` Felipe Balbi
2012-08-03 14:31 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:31 ` ABRAHAM, KISHON VIJAY
2012-08-06 8:49 ` Felipe Balbi
2012-08-06 8:49 ` Felipe Balbi
2012-08-06 8:49 ` Felipe Balbi
2012-08-06 9:44 ` ABRAHAM, KISHON VIJAY
2012-08-06 9:44 ` ABRAHAM, KISHON VIJAY
2012-08-06 9:44 ` ABRAHAM, KISHON VIJAY
2012-08-06 9:44 ` Felipe Balbi
2012-08-06 9:44 ` Felipe Balbi
2012-08-06 9:44 ` Felipe Balbi
2012-07-30 9:09 ` [PATCH v6 02/11] arm/dts: omap: Add omap-usb2 dt data Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:27 ` Felipe Balbi
2012-08-03 13:27 ` Felipe Balbi
2012-07-30 9:09 ` [PATCH v6 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2 Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:28 ` Felipe Balbi
2012-08-03 13:28 ` Felipe Balbi
2012-08-03 14:33 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:33 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:09 ` [PATCH v6 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:29 ` Felipe Balbi
2012-08-03 13:29 ` Felipe Balbi
2012-08-03 14:37 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:37 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:09 ` [PATCH v6 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:31 ` Felipe Balbi
2012-08-03 13:31 ` Felipe Balbi
2012-08-03 14:39 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:39 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:09 ` [PATCH v6 06/11] arm/dts: Add twl6030-usb data Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:31 ` Felipe Balbi
2012-08-03 13:31 ` Felipe Balbi
2012-08-03 13:31 ` Felipe Balbi
2012-07-30 9:09 ` [PATCH v6 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:32 ` Felipe Balbi
2012-08-03 13:32 ` Felipe Balbi
2012-08-03 13:32 ` Felipe Balbi
2012-08-03 14:40 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:40 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:09 ` [PATCH v6 08/11] arm/dts: Add twl4030-usb data Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:32 ` Felipe Balbi
2012-08-03 13:32 ` Felipe Balbi
2012-07-30 9:09 ` [PATCH v6 09/11] drivers: usb: musb: Add device tree support for omap musb glue Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:34 ` Felipe Balbi
2012-08-03 13:34 ` Felipe Balbi
2012-08-03 13:34 ` Felipe Balbi
2012-08-03 14:42 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:42 ` ABRAHAM, KISHON VIJAY
2012-07-30 9:09 ` [PATCH v6 10/11] arm/dts: omap: Add usb_otg and glue data Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-07-30 9:09 ` Kishon Vijay Abraham I
2012-08-03 13:35 ` Felipe Balbi
2012-08-03 13:35 ` Felipe Balbi
2012-07-30 9:10 ` [PATCH v6 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c Kishon Vijay Abraham I
2012-07-30 9:10 ` Kishon Vijay Abraham I
2012-07-30 9:10 ` Kishon Vijay Abraham I
2012-08-03 13:36 ` Felipe Balbi
2012-08-03 13:36 ` Felipe Balbi
2012-08-03 14:41 ` ABRAHAM, KISHON VIJAY
2012-08-03 14:41 ` ABRAHAM, KISHON VIJAY
2012-08-06 8:52 ` [PATCH v6 00/11] omap: musb: Add device tree support Felipe Balbi
2012-08-06 8:52 ` Felipe Balbi
2012-08-06 9:25 ` ABRAHAM, KISHON VIJAY
2012-08-06 9:25 ` ABRAHAM, KISHON VIJAY
2012-08-06 9:25 ` ABRAHAM, KISHON VIJAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50165C27.3010107@ti.com \
--to=shubhrajyoti@ti.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.