From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: alsa-devel@alsa-project.org, Tony Lindgren <tony@atomide.com>,
devicetree-discuss@lists.ozlabs.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Anuj Aggarwal <anuj.aggarwal@ti.com>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org,
Steve Sakoman <steve@sakoman.com>
Subject: Re: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
Date: Wed, 08 Aug 2012 15:29:41 +0300 [thread overview]
Message-ID: <50225BB5.3000407@ti.com> (raw)
In-Reply-To: <50225A84.5010008@compulab.co.il>
Hi Igor,
On 08/08/2012 03:24 PM, Igor Grinberg wrote:
>> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
>> index 97d7190..b73fa5c 100644
>> --- a/arch/arm/mach-omap2/board-cm-t35.c
>> +++ b/arch/arm/mach-omap2/board-cm-t35.c
>> @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void)
>> cm_t35_init_ethernet();
>> cm_t35_init_led();
>> cm_t35_init_display();
>> + omap_twl4030_audio_init("overo", 26000000);
>
> Can the card_name here be "cm-t3x" ?
I have used the "overo" as card name here since what I gathered is that cm-t35
used the sound/soc/omap/overo.c machine driver for audio support.
If the card name is changing your existing user space might get confused by
the card name change.
But sure, I can change the card name to "cm-t3x" if it is better for you.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards
Date: Wed, 08 Aug 2012 15:29:41 +0300 [thread overview]
Message-ID: <50225BB5.3000407@ti.com> (raw)
In-Reply-To: <50225A84.5010008@compulab.co.il>
Hi Igor,
On 08/08/2012 03:24 PM, Igor Grinberg wrote:
>> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
>> index 97d7190..b73fa5c 100644
>> --- a/arch/arm/mach-omap2/board-cm-t35.c
>> +++ b/arch/arm/mach-omap2/board-cm-t35.c
>> @@ -731,6 +731,7 @@ static void __init cm_t3x_common_init(void)
>> cm_t35_init_ethernet();
>> cm_t35_init_led();
>> cm_t35_init_display();
>> + omap_twl4030_audio_init("overo", 26000000);
>
> Can the card_name here be "cm-t3x" ?
I have used the "overo" as card name here since what I gathered is that cm-t35
used the sound/soc/omap/overo.c machine driver for audio support.
If the card name is changing your existing user space might get confused by
the card name change.
But sure, I can change the card name to "cm-t3x" if it is better for you.
--
P?ter
next prev parent reply other threads:[~2012-08-08 12:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 9:54 [PATCH 0/4] ASoC/OMAP: ASoC machine driver for simple SoC with twl4030 Peter Ujfalusi
2012-08-08 9:54 ` Peter Ujfalusi
2012-08-08 9:54 ` [PATCH 1/4] ASoC: omap-twl4030: Simple machine driver for TI SoC with twl4030 codec Peter Ujfalusi
2012-08-08 9:54 ` Peter Ujfalusi
2012-08-08 9:54 ` [PATCH 2/4] ARM: OMAP: twl-common: Add helper function to register the omap-twl4030 audio driver Peter Ujfalusi
2012-08-08 9:54 ` Peter Ujfalusi
2012-08-10 6:29 ` Tony Lindgren
2012-08-10 6:29 ` Tony Lindgren
2012-08-08 9:54 ` [PATCH 3/4] ARM: OMAP3: Switch to use the unified audio driver (omap-twl4030) for selected boards Peter Ujfalusi
2012-08-08 9:54 ` Peter Ujfalusi
2012-08-08 12:24 ` Igor Grinberg
2012-08-08 12:24 ` Igor Grinberg
2012-08-08 12:29 ` Peter Ujfalusi [this message]
2012-08-08 12:29 ` Peter Ujfalusi
2012-08-08 13:06 ` Igor Grinberg
2012-08-08 13:06 ` Igor Grinberg
2012-08-09 10:21 ` Peter Ujfalusi
2012-08-09 10:21 ` Peter Ujfalusi
2012-08-09 13:12 ` Igor Grinberg
2012-08-09 13:12 ` Igor Grinberg
2012-08-10 6:31 ` Tony Lindgren
2012-08-10 6:31 ` Tony Lindgren
2012-08-08 9:54 ` [PATCH 4/4] ASoC: Remove obsolete OMAP3 machine drivers Peter Ujfalusi
2012-08-08 9:54 ` Peter Ujfalusi
2012-08-08 13:27 ` [PATCH 0/4] ASoC/OMAP: ASoC machine driver for simple SoC with twl4030 Mark Brown
2012-08-08 13:27 ` Mark Brown
2012-08-10 6:32 ` Tony Lindgren
2012-08-10 6:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50225BB5.3000407@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grinberg@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=steve@sakoman.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.