All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <b-cousson@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: <balbi@ti.com>, <grant.likely@secretlab.ca>,
	<rob.herring@calxeda.com>, <rob@landley.net>,
	<linux@arm.linux.org.uk>, <gregkh@linuxfoundation.org>,
	<rnayak@ti.com>, <tony@atomide.com>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module
Date: Tue, 11 Sep 2012 11:13:01 +0200	[thread overview]
Message-ID: <504F009D.3050208@ti.com> (raw)
In-Reply-To: <1347354580-5895-2-git-send-email-kishon@ti.com>

On 09/11/2012 11:09 AM, Kishon Vijay Abraham I wrote:
> The mailbox register for usb otg in omap is present in control module.
> On detection of any events VBUS or ID, this register should be written
> to send the notification to musb core.
> 
> Till we have a separate control module driver to write to control module,
> omap2430 will handle the register writes to control module by itself. So
> a new address space to represent this control module register is added
> to usb_otg_hs.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Acked-by: Benoit Cousson <b-cousson@ti.com>

> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 242aee4..3c19120 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -5890,6 +5890,12 @@ static struct omap_hwmod_addr_space omap44xx_usb_otg_hs_addrs[] = {
>  		.pa_end		= 0x4a0ab003,
>  		.flags		= ADDR_TYPE_RT
>  	},
> +	{
> +		/* XXX: Remove this once control module driver is in place */
> +		.pa_start	= 0x4a00233c,
> +		.pa_end		= 0x4a00233f,
> +		.flags		= ADDR_TYPE_RT
> +	},
>  	{ }
>  };
>  
> 


WARNING: multiple messages have this Message-ID (diff)
From: Benoit Cousson <b-cousson@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: balbi@ti.com, grant.likely@secretlab.ca, rob.herring@calxeda.com,
	rob@landley.net, linux@arm.linux.org.uk,
	gregkh@linuxfoundation.org, rnayak@ti.com, tony@atomide.com,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module
Date: Tue, 11 Sep 2012 11:13:01 +0200	[thread overview]
Message-ID: <504F009D.3050208@ti.com> (raw)
In-Reply-To: <1347354580-5895-2-git-send-email-kishon@ti.com>

On 09/11/2012 11:09 AM, Kishon Vijay Abraham I wrote:
> The mailbox register for usb otg in omap is present in control module.
> On detection of any events VBUS or ID, this register should be written
> to send the notification to musb core.
> 
> Till we have a separate control module driver to write to control module,
> omap2430 will handle the register writes to control module by itself. So
> a new address space to represent this control module register is added
> to usb_otg_hs.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Acked-by: Benoit Cousson <b-cousson@ti.com>

> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 242aee4..3c19120 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -5890,6 +5890,12 @@ static struct omap_hwmod_addr_space omap44xx_usb_otg_hs_addrs[] = {
>  		.pa_end		= 0x4a0ab003,
>  		.flags		= ADDR_TYPE_RT
>  	},
> +	{
> +		/* XXX: Remove this once control module driver is in place */
> +		.pa_start	= 0x4a00233c,
> +		.pa_end		= 0x4a00233f,
> +		.flags		= ADDR_TYPE_RT
> +	},
>  	{ }
>  };
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module
Date: Tue, 11 Sep 2012 11:13:01 +0200	[thread overview]
Message-ID: <504F009D.3050208@ti.com> (raw)
In-Reply-To: <1347354580-5895-2-git-send-email-kishon@ti.com>

On 09/11/2012 11:09 AM, Kishon Vijay Abraham I wrote:
> The mailbox register for usb otg in omap is present in control module.
> On detection of any events VBUS or ID, this register should be written
> to send the notification to musb core.
> 
> Till we have a separate control module driver to write to control module,
> omap2430 will handle the register writes to control module by itself. So
> a new address space to represent this control module register is added
> to usb_otg_hs.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Acked-by: Benoit Cousson <b-cousson@ti.com>

> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 242aee4..3c19120 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -5890,6 +5890,12 @@ static struct omap_hwmod_addr_space omap44xx_usb_otg_hs_addrs[] = {
>  		.pa_end		= 0x4a0ab003,
>  		.flags		= ADDR_TYPE_RT
>  	},
> +	{
> +		/* XXX: Remove this once control module driver is in place */
> +		.pa_start	= 0x4a00233c,
> +		.pa_end		= 0x4a00233f,
> +		.flags		= ADDR_TYPE_RT
> +	},
>  	{ }
>  };
>  
> 

  reply	other threads:[~2012-09-11  9:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11  9:09 [PATCH v2 0/3] omap: musb: Add device tree support Kishon Vijay Abraham I
2012-09-11  9:09 ` Kishon Vijay Abraham I
2012-09-11  9:09 ` Kishon Vijay Abraham I
2012-09-11  9:09 ` [PATCH v2 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:13   ` Benoit Cousson [this message]
2012-09-11  9:13     ` Benoit Cousson
2012-09-11  9:13     ` Benoit Cousson
2012-09-11  9:09 ` [PATCH v2 2/3] usb: musb: omap: write directly to mailbox instead of using phy Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:09 ` [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:09   ` Kishon Vijay Abraham I
2012-09-11  9:53   ` Vaibhav Hiremath
2012-09-11  9:53     ` Vaibhav Hiremath
2012-09-11  9:53     ` Vaibhav Hiremath
2012-09-11 11:24     ` ABRAHAM, KISHON VIJAY
2012-09-11 11:24       ` ABRAHAM, KISHON VIJAY
2012-09-11 11:34       ` Hiremath, Vaibhav
2012-09-11 11:34         ` Hiremath, Vaibhav
2012-09-11 11:34         ` Hiremath, Vaibhav
2013-01-08 19:32   ` Sergei Shtylyov
2013-01-08 19:32     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504F009D.3050208@ti.com \
    --to=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.