All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <mail@conchuod.ie>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Conor Dooley <conor.dooley@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	Daire McNamara <daire.mcnamara@microchip.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Lewis Hanly <lewis.hanly@microchip.com>,
	linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: microchip-core: Fix the error handling path in mchp_corespi_probe()
Date: Sat, 11 Jun 2022 10:20:14 +0100	[thread overview]
Message-ID: <50540bda-ffaa-1141-b077-197ac64fcdd1@conchuod.ie> (raw)
In-Reply-To: <a90bec10dec43719b12afdb967e87526c4bc849a.1654933052.git.christophe.jaillet@wanadoo.fr>



On 11/06/2022 08:37, Christophe JAILLET wrote:
> clk_prepare_enable() is called instead of clk_disable_unprepare() in the
> error handling path of the probe function.
> 
> Change the function that is called so that resources are released
> correctly.
> 
> Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Hey Christophe,
Peng Wu already sent a patch for this, but thanks for trying
to clean up after me anyway.
Thanks,
Conor.

> ---
>  drivers/spi/spi-microchip-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index 5b2aee30fa04..bf6847d95fe3 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
>  
>  error_release_hardware:
>  	mchp_corespi_disable(spi);
> -	clk_prepare_enable(spi->clk);
> +	clk_disable_unprepare(spi->clk);
>  error_release_master:
>  	spi_master_put(master);
>  

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <mail@conchuod.ie>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Conor Dooley <conor.dooley@microchip.com>,
	Mark Brown <broonie@kernel.org>,
	Daire McNamara <daire.mcnamara@microchip.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Lewis Hanly <lewis.hanly@microchip.com>,
	linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: microchip-core: Fix the error handling path in mchp_corespi_probe()
Date: Sat, 11 Jun 2022 10:20:14 +0100	[thread overview]
Message-ID: <50540bda-ffaa-1141-b077-197ac64fcdd1@conchuod.ie> (raw)
In-Reply-To: <a90bec10dec43719b12afdb967e87526c4bc849a.1654933052.git.christophe.jaillet@wanadoo.fr>



On 11/06/2022 08:37, Christophe JAILLET wrote:
> clk_prepare_enable() is called instead of clk_disable_unprepare() in the
> error handling path of the probe function.
> 
> Change the function that is called so that resources are released
> correctly.
> 
> Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Hey Christophe,
Peng Wu already sent a patch for this, but thanks for trying
to clean up after me anyway.
Thanks,
Conor.

> ---
>  drivers/spi/spi-microchip-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index 5b2aee30fa04..bf6847d95fe3 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
>  
>  error_release_hardware:
>  	mchp_corespi_disable(spi);
> -	clk_prepare_enable(spi->clk);
> +	clk_disable_unprepare(spi->clk);
>  error_release_master:
>  	spi_master_put(master);
>  

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-06-11  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-11  7:37 [PATCH] spi: microchip-core: Fix the error handling path in mchp_corespi_probe() Christophe JAILLET
2022-06-11  7:37 ` Christophe JAILLET
2022-06-11  9:20 ` Conor Dooley [this message]
2022-06-11  9:20   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50540bda-ffaa-1141-b077-197ac64fcdd1@conchuod.ie \
    --to=mail@conchuod.ie \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lewis.hanly@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.