From: Heiko Stuebner <heiko@sntech.de> To: Elaine Zhang <zhangqing@rock-chips.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, rjw@rjwysocki.net, khilman@kernel.org, ulf.hansson@linaro.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, wxt@rock-chips.com, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com, Finley Xiao <finley.xiao@rock-chips.com> Subject: Re: [PATCH v1 11/13] dt-bindings: power: add PX30 SoCs header for power-domain Date: Sat, 12 May 2018 00:11:24 +0200 [thread overview] Message-ID: <508694354.7btLQf7nsA@phil> (raw) In-Reply-To: <1526009672-2097-1-git-send-email-zhangqing@rock-chips.com> Hi Elaine, Am Freitag, 11. Mai 2018, 05:34:32 CEST schrieb Elaine Zhang: > According to a description from TRM, add all the power domains. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> that's a bit ambigous, having the Signed-offs like above. Either you are the author+sender of the patch, then Finley's Signed-off should go away ... or Finley is the author and you are the sender, then the author of the patch should be set correctly (--author option for git) and the Signed-offs should switch places (= Finley first, then yours). Please fix. This seems to be true for most patches in this series. > --- > include/dt-bindings/power/px30-power.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 include/dt-bindings/power/px30-power.h > > diff --git a/include/dt-bindings/power/px30-power.h b/include/dt-bindings/power/px30-power.h > new file mode 100644 > index 000000000000..4ed482e80950 > --- /dev/null > +++ b/include/dt-bindings/power/px30-power.h Here I have a naming question. When looking at the vendor kernel it looks like the px30 is largely related to the rk3326. (rk3326.dtsi includeing the px30.dtsi) What is the reason for basing the naming on the px30 this time? And could we possibly keep to rkXXXX names for the basic things in the kernel, thus keeping the pxXX as second name, like with the other px-variants before? Thanks Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 11/13] dt-bindings: power: add PX30 SoCs header for power-domain Date: Sat, 12 May 2018 00:11:24 +0200 [thread overview] Message-ID: <508694354.7btLQf7nsA@phil> (raw) In-Reply-To: <1526009672-2097-1-git-send-email-zhangqing@rock-chips.com> Hi Elaine, Am Freitag, 11. Mai 2018, 05:34:32 CEST schrieb Elaine Zhang: > According to a description from TRM, add all the power domains. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> that's a bit ambigous, having the Signed-offs like above. Either you are the author+sender of the patch, then Finley's Signed-off should go away ... or Finley is the author and you are the sender, then the author of the patch should be set correctly (--author option for git) and the Signed-offs should switch places (= Finley first, then yours). Please fix. This seems to be true for most patches in this series. > --- > include/dt-bindings/power/px30-power.h | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 include/dt-bindings/power/px30-power.h > > diff --git a/include/dt-bindings/power/px30-power.h b/include/dt-bindings/power/px30-power.h > new file mode 100644 > index 000000000000..4ed482e80950 > --- /dev/null > +++ b/include/dt-bindings/power/px30-power.h Here I have a naming question. When looking at the vendor kernel it looks like the px30 is largely related to the rk3326. (rk3326.dtsi includeing the px30.dtsi) What is the reason for basing the naming on the px30 this time? And could we possibly keep to rkXXXX names for the basic things in the kernel, thus keeping the pxXX as second name, like with the other px-variants before? Thanks Heiko
next prev parent reply other threads:[~2018-05-11 22:11 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-11 3:30 [PATCH v1 00/13] add power domain support for Rockchip Socs Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-11 3:30 ` [PATCH v1 01/13] dt-bindings: power: add RK3036 SoCs header for power-domain Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-11 3:30 ` [PATCH v1 02/13] dt-bindings: add binding for rk3036 power domains Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-11 3:30 ` [PATCH v1 03/13] Soc: rockchip: power-domain: add power domain support for rk3036 Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-11 3:30 ` [PATCH v1 04/13] soc: rockchip: power-domain: Fix wrong value when power up pd Elaine Zhang 2018-05-11 3:30 ` Elaine Zhang 2018-05-12 14:11 ` Heiko Stuebner 2018-05-12 14:11 ` Heiko Stuebner 2018-05-11 3:32 ` [PATCH v1 05/13] dt-bindings: power: add RK3128 SoCs header for power-domain Elaine Zhang 2018-05-11 3:32 ` Elaine Zhang 2018-05-11 3:32 ` [PATCH v1 06/13] dt-bindings: add binding for rk3128 power domains Elaine Zhang 2018-05-11 3:32 ` Elaine Zhang 2018-05-11 3:33 ` [PATCH v1 07/13] soc: rockchip: power-domain: add power domain support for rk3128 Elaine Zhang 2018-05-11 3:33 ` Elaine Zhang 2018-05-11 3:33 ` [PATCH v1 08/13] dt-bindings: power: add RK3228 SoCs header for power-domain Elaine Zhang 2018-05-11 3:33 ` Elaine Zhang 2018-05-11 3:33 ` Elaine Zhang 2018-05-11 3:33 ` [PATCH v1 09/13] dt-bindings: add binding for rk3228 power domains Elaine Zhang 2018-05-11 3:33 ` Elaine Zhang 2018-05-11 3:34 ` [PATCH v1 10/13] soc: rockchip: power-domain: add power domain support for rk3228 Elaine Zhang 2018-05-11 3:34 ` Elaine Zhang 2018-05-11 3:34 ` [PATCH v1 11/13] dt-bindings: power: add PX30 SoCs header for power-domain Elaine Zhang 2018-05-11 3:34 ` Elaine Zhang 2018-05-11 22:11 ` Heiko Stuebner [this message] 2018-05-11 22:11 ` Heiko Stuebner 2018-05-13 15:18 ` Tao Huang 2018-05-13 15:18 ` Tao Huang 2018-05-13 20:53 ` Heiko Stübner 2018-05-13 20:53 ` Heiko Stübner 2018-05-11 3:34 ` [PATCH v1 12/13] dt-bindings: add binding for px30 power domains Elaine Zhang 2018-05-11 3:34 ` Elaine Zhang 2018-05-11 3:35 ` [PATCH v1 13/13] soc: rockchip: power-domain: add power domain support for px30 Elaine Zhang 2018-05-11 3:35 ` Elaine Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=508694354.7btLQf7nsA@phil \ --to=heiko@sntech.de \ --cc=devicetree@vger.kernel.org \ --cc=finley.xiao@rock-chips.com \ --cc=huangtao@rock-chips.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=rjw@rjwysocki.net \ --cc=robh+dt@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=wxt@rock-chips.com \ --cc=xf@rock-chips.com \ --cc=xxx@rock-chips.com \ --cc=zhangqing@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.