From: Jason Wang <jasowang@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: mst@redhat.com, davem@davemloft.net,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
krkumar2@in.ibm.com, kvm@vger.kernel.org
Subject: Re: [rfc net-next v6 3/3] virtio-net: change the number of queues through ethtool
Date: Mon, 19 Nov 2012 14:22:40 +0800 [thread overview]
Message-ID: <50A9D030.7070100@redhat.com> (raw)
In-Reply-To: <871ug9yls5.fsf@rustcorp.com.au>
On 11/05/2012 07:46 AM, Rusty Russell wrote:
> Jason Wang <jasowang@redhat.com> writes:
>> This patch implement the {set|get}_channels method of ethool to allow user to
>> change the number of queues dymaically when the device is running. This would
>> let the user to tune the device for specific applications.
> ...
>> + /* Only two modes were support currently */
>> + if (queue_pairs == 0)
>> + return -EINVAL;
>> + if (queue_pairs != vi->total_queue_pairs - 1 && queue_pairs != 1)
>> + return -EINVAL;
> OK, so you let them do all or nothing, but this three-way test is
> pretty unclear.
True, looks like the first check could be removed.
>
> In fact, the whole total_queue_pairs/num_queue_pairs thing is weird (and
> uncommented). I think for "total" you mean "max"; the maximum possible
> queue pair number.
Yes, "total" means "max", will add a comment or change the name to
max_queue_pairs/current_queue_pairs.
>
> Let me go back and review the previous patch again...
>
> Cheers,
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [rfc net-next v6 3/3] virtio-net: change the number of queues through ethtool
Date: Mon, 19 Nov 2012 14:22:40 +0800 [thread overview]
Message-ID: <50A9D030.7070100@redhat.com> (raw)
In-Reply-To: <871ug9yls5.fsf@rustcorp.com.au>
On 11/05/2012 07:46 AM, Rusty Russell wrote:
> Jason Wang <jasowang@redhat.com> writes:
>> This patch implement the {set|get}_channels method of ethool to allow user to
>> change the number of queues dymaically when the device is running. This would
>> let the user to tune the device for specific applications.
> ...
>> + /* Only two modes were support currently */
>> + if (queue_pairs == 0)
>> + return -EINVAL;
>> + if (queue_pairs != vi->total_queue_pairs - 1 && queue_pairs != 1)
>> + return -EINVAL;
> OK, so you let them do all or nothing, but this three-way test is
> pretty unclear.
True, looks like the first check could be removed.
>
> In fact, the whole total_queue_pairs/num_queue_pairs thing is weird (and
> uncommented). I think for "total" you mean "max"; the maximum possible
> queue pair number.
Yes, "total" means "max", will add a comment or change the name to
max_queue_pairs/current_queue_pairs.
>
> Let me go back and review the previous patch again...
>
> Cheers,
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-11-19 6:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 10:03 [rfc net-next v6 0/3] Multiqueue virtio-net Jason Wang
2012-10-30 10:03 ` Jason Wang
2012-10-30 10:03 ` [rfc net-next v6 1/3] virtio_net: Introduce VIRTIO_NET_F_MULTIQUEUE Jason Wang
2012-10-30 10:03 ` Jason Wang
2012-10-30 10:03 ` [rfc net-next v6 2/3] virtio_net: multiqueue support Jason Wang
2012-10-30 10:03 ` Jason Wang
2012-11-04 23:16 ` Rusty Russell
2012-11-04 23:16 ` Rusty Russell
2012-11-19 6:18 ` Jason Wang
2012-11-19 6:18 ` Jason Wang
2012-11-05 1:08 ` Rusty Russell
2012-11-05 1:08 ` Rusty Russell
2012-11-13 6:40 ` Michael S. Tsirkin
2012-11-13 6:40 ` Michael S. Tsirkin
2012-11-17 0:35 ` Ben Hutchings
2012-11-17 0:35 ` Ben Hutchings
2012-11-18 9:13 ` Michael S. Tsirkin
2012-11-18 9:13 ` Michael S. Tsirkin
2012-11-19 18:44 ` Ben Hutchings
2012-11-19 18:44 ` Ben Hutchings
2012-11-19 7:40 ` Jason Wang
2012-11-19 7:40 ` Jason Wang
2012-10-30 10:03 ` [rfc net-next v6 3/3] virtio-net: change the number of queues through ethtool Jason Wang
2012-10-30 10:03 ` Jason Wang
2012-11-04 23:46 ` Rusty Russell
2012-11-04 23:46 ` Rusty Russell
2012-11-19 6:22 ` Jason Wang [this message]
2012-11-19 6:22 ` Jason Wang
2012-11-08 21:13 ` Ben Hutchings
2012-11-08 21:13 ` Ben Hutchings
2012-10-30 19:05 ` [rfc net-next v6 0/3] Multiqueue virtio-net Rick Jones
2012-10-30 19:05 ` Rick Jones
2012-10-31 10:33 ` Jason Wang
2012-10-31 10:33 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A9D030.7070100@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.