Re: [PATCH v2 0/6] qcow2: advanced compression options

From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	"fam@euphon.net" <fam@euphon.net>,
	Denis Lunev <den@virtuozzo.com>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
	"patchew-devel@redhat.com" <patchew-devel@redhat.com>,
	"armbru@redhat.com" <armbru@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"jsnow@redhat.com" <jsnow@redhat.com>
Subject: Re: [PATCH v2 0/6] qcow2: advanced compression options
Date: Wed, 2 Oct 2019 17:58:57 +0200	[thread overview]
Message-ID: <5106e252-43d4-0ed5-ee65-a71a5e569bf7@redhat.com> (raw)
In-Reply-To: <75c7393b-5ad0-66d5-9592-388f0260a0de@virtuozzo.com>

[-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --]

On 02.10.19 17:35, Vladimir Sementsov-Ogievskiy wrote:
> Hi,
> 
> 02.10.2019 18:07, no-reply@patchew.org wrote:
>> Patchew URL: https://patchew.org/QEMU/1570026166-748566-1-git-send-email-andrey.shinkevich@virtuozzo.com/
>>
>>
>>
>> Hi,
>>
>> This series failed the docker-quick@centos7 build test. Please find the testing commands and
>> their output below. If you have Docker installed, you can probably reproduce it
>> locally.
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>> make docker-image-centos7 V=1 NETWORK=1
>> time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
>> === TEST SCRIPT END ===
>>
>>    CC      block/parallels.o
>>    CC      block/blklogwrites.o
>>    CC      block/block-backend.o
>> /tmp/qemu-test/src/block/qcow2.c:4077:64: error: unknown type name 'AioTask'
>>   static coroutine_fn int qcow2_co_pwritev_compressed_task_entry(AioTask *task)
>>                                                                  ^
>> /tmp/qemu-test/src/block/qcow2.c: In function 'qcow2_co_pwritev_compressed_part':
>> /tmp/qemu-test/src/block/qcow2.c:4098:5: error: unknown type name 'AioTaskPool'
>>       AioTaskPool *aio = NULL;
>>       ^
> 
> 
> Who knows, what is wrong with it? Seems patchew ignores Based-on: tag in cover-letter,
> which is written as "Based-on: https://github.com/XanClic/qemu.git block"...
> These new types and functions are defined in Max's block branch.

It would be news to me if Patchew supported such URLs.  I just put it
into my cover letter for human reviewers...

(Actually, it would be news to me if Patchew supported Based-on at all
reliably...)

Max

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]