Re: [PATCH v2 2/6] tests/qemu-iotests: add case of writing compressed data to multiple clusters - Vladimir Sementsov-Ogievskiy

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	"fam@euphon.net" <fam@euphon.net>,
	Denis Lunev <den@virtuozzo.com>,
	"jsnow@redhat.com" <jsnow@redhat.com>,
	"armbru@redhat.com" <armbru@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [PATCH v2 2/6] tests/qemu-iotests: add case of writing compressed data to multiple clusters
Date: Thu, 3 Oct 2019 14:21:37 +0000	[thread overview]
Message-ID: <58007c37-a8b1-ecfb-7b4a-3b65ee3a32df@virtuozzo.com> (raw)
In-Reply-To: <1570026166-748566-3-git-send-email-andrey.shinkevich@virtuozzo.com>

02.10.2019 17:22, Andrey Shinkevich wrote:
> Add the test case to the iotest #214 that checks possibility of writing
> compressed data to more than one cluster.
> 
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
>   tests/qemu-iotests/214     | 9 +++++++++
>   tests/qemu-iotests/214.out | 6 ++++++
>   2 files changed, 15 insertions(+)
> 
> diff --git a/tests/qemu-iotests/214 b/tests/qemu-iotests/214
> index 21ec8a2..5f437e4 100755
> --- a/tests/qemu-iotests/214
> +++ b/tests/qemu-iotests/214
> @@ -89,6 +89,15 @@ _check_test_img -r all
>   $QEMU_IO -c "read  -P 0x11  0 4M" "$TEST_IMG" 2>&1 | _filter_qemu_io | _filter_testdir
>   $QEMU_IO -c "read  -P 0x22 4M 4M" "$TEST_IMG" 2>&1 | _filter_qemu_io | _filter_testdir
>   
> +echo
> +echo "=== Write compressed data to multiple clusters ==="
> +echo
> +# Create an empty image and fill three and half clusters with compressed data.

Hmm, but we support only aligned to cluster writes, isn't it? With the only exception for
last cluster of the image?

> +_make_test_img 2M -o cluster_size=0x10000
> +data_size=3*0x10000+0x8000

data_size is unused.

> +$QEMU_IO -c "write -c -P 0x11 0 256k" "$TEST_IMG" \
> +         2>&1 | _filter_qemu_io | _filter_testdir
> +

will be good to check img and print qemu img map (or something like this) to see these
compressed clusters.

>   # success, all done
>   echo '*** done'
>   rm -f $seq.full
> diff --git a/tests/qemu-iotests/214.out b/tests/qemu-iotests/214.out
> index 0fcd8dc..2b908f6 100644
> --- a/tests/qemu-iotests/214.out
> +++ b/tests/qemu-iotests/214.out
> @@ -32,4 +32,10 @@ read 4194304/4194304 bytes at offset 0
>   4 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>   read 4194304/4194304 bytes at offset 4194304
>   4 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +
> +=== Write compressed data to multiple clusters ===
> +
> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2097152
> +wrote 262144/262144 bytes at offset 0
> +256 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>   *** done
> 

-- 
Best regards,
Vladimir