From: Sekhar Nori <nsekhar@ti.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Philip Avinash <avinashphilip@ti.com>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-doc@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>, <prakash.pm@ti.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
Date: Fri, 15 Mar 2013 09:55:57 +0530 [thread overview]
Message-ID: <5142A2D5.5090009@ti.com> (raw)
In-Reply-To: <87txoe56lk.fsf@dell.be.48ers.dk>
On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
>>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:
>
> >> Required properties:
> >> -- compatible: Must be "ti,am33xx-ecap"
> >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
> >> First cell specifies the per-chip index of the PWM to use, the second
> >> cell is the period in nanoseconds and bit 0 in the third cell is used to
> >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> >> index 22e96e2..e0d96c8 100644
> >> --- a/drivers/pwm/pwm-tiecap.c
> >> +++ b/drivers/pwm/pwm-tiecap.c
> >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >>
> >> static const struct of_device_id ecap_of_match[] = {
> >> { .compatible = "ti,am33xx-ecap" },
> >> + { .compatible = "ti,da850-ecap" },
> >> {},
>
> Sekhar> You add a new compatible, but don't really show any changes in
> Sekhar> driver in this series. So why can't we simply use
> Sekhar> ti,am33xx-ecap on DA850 too?
>
> Indeed, if the hardware block is identical the dts should simply list:
>
> compatible = "ti,da850-ecap", "ti,am33xx-ecap"
>
> And the driver only bind to ti,am33xx-ecap (unless there ever needs to
> be a da850 specific workarounde.
Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!
~Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Philip Avinash <avinashphilip@ti.com>,
davinci-linux-open-source@linux.davincidsp.com,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
prakash.pm@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
Date: Fri, 15 Mar 2013 09:55:57 +0530 [thread overview]
Message-ID: <5142A2D5.5090009@ti.com> (raw)
In-Reply-To: <87txoe56lk.fsf@dell.be.48ers.dk>
On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
>>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:
>
> >> Required properties:
> >> -- compatible: Must be "ti,am33xx-ecap"
> >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
> >> First cell specifies the per-chip index of the PWM to use, the second
> >> cell is the period in nanoseconds and bit 0 in the third cell is used to
> >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> >> index 22e96e2..e0d96c8 100644
> >> --- a/drivers/pwm/pwm-tiecap.c
> >> +++ b/drivers/pwm/pwm-tiecap.c
> >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >>
> >> static const struct of_device_id ecap_of_match[] = {
> >> { .compatible = "ti,am33xx-ecap" },
> >> + { .compatible = "ti,da850-ecap" },
> >> {},
>
> Sekhar> You add a new compatible, but don't really show any changes in
> Sekhar> driver in this series. So why can't we simply use
> Sekhar> ti,am33xx-ecap on DA850 too?
>
> Indeed, if the hardware block is identical the dts should simply list:
>
> compatible = "ti,da850-ecap", "ti,am33xx-ecap"
>
> And the driver only bind to ti,am33xx-ecap (unless there ever needs to
> be a da850 specific workarounde.
Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!
~Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC
Date: Fri, 15 Mar 2013 09:55:57 +0530 [thread overview]
Message-ID: <5142A2D5.5090009@ti.com> (raw)
In-Reply-To: <87txoe56lk.fsf@dell.be.48ers.dk>
On 3/14/2013 9:14 PM, Peter Korsgaard wrote:
>>>>>> "Sekhar" == Sekhar Nori <nsekhar@ti.com> writes:
>
> >> Required properties:
> >> -- compatible: Must be "ti,am33xx-ecap"
> >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
> >> First cell specifies the per-chip index of the PWM to use, the second
> >> cell is the period in nanoseconds and bit 0 in the third cell is used to
> >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> >> index 22e96e2..e0d96c8 100644
> >> --- a/drivers/pwm/pwm-tiecap.c
> >> +++ b/drivers/pwm/pwm-tiecap.c
> >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >>
> >> static const struct of_device_id ecap_of_match[] = {
> >> { .compatible = "ti,am33xx-ecap" },
> >> + { .compatible = "ti,da850-ecap" },
> >> {},
>
> Sekhar> You add a new compatible, but don't really show any changes in
> Sekhar> driver in this series. So why can't we simply use
> Sekhar> ti,am33xx-ecap on DA850 too?
>
> Indeed, if the hardware block is identical the dts should simply list:
>
> compatible = "ti,da850-ecap", "ti,am33xx-ecap"
>
> And the driver only bind to ti,am33xx-ecap (unless there ever needs to
> be a da850 specific workarounde.
Okay, so this is to future proof the DA850 DT blob. Makes sense. Thanks!
~Sekhar
next prev parent reply other threads:[~2013-03-15 4:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 10:32 [PATCH 0/3] Davinci support for EHRPWM & ECAP Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 10:32 ` [PATCH 1/3] pwm: davinci: Add Kconfig support for ECAP & EHRPWM devices Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 11:39 ` Sekhar Nori
2013-03-14 11:39 ` Sekhar Nori
2013-03-14 11:39 ` Sekhar Nori
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 15:11 ` Thierry Reding
2013-03-14 15:11 ` Thierry Reding
2013-03-14 15:11 ` Thierry Reding
2013-03-14 10:32 ` [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 11:43 ` Sekhar Nori
2013-03-14 11:43 ` Sekhar Nori
2013-03-14 11:43 ` Sekhar Nori
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 12:54 ` Philip, Avinash
2013-03-14 15:44 ` Peter Korsgaard
2013-03-14 15:44 ` Peter Korsgaard
2013-03-15 4:25 ` Sekhar Nori [this message]
2013-03-15 4:25 ` Sekhar Nori
2013-03-15 4:25 ` Sekhar Nori
2013-03-14 10:32 ` [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree " Philip Avinash
2013-03-14 10:32 ` Philip Avinash
2013-03-14 10:32 ` Philip Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5142A2D5.5090009@ti.com \
--to=nsekhar@ti.com \
--cc=avinashphilip@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakash.pm@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.