From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
devicetree@vger.kernel.org,
Alexandru M Stan <amstan@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties
Date: Tue, 18 Aug 2015 21:17:06 +0200 [thread overview]
Message-ID: <51457775.D3ds00ymOJ@phil> (raw)
In-Reply-To: <1439923455-109818-2-git-send-email-briannorris@chromium.org>
Hi Brian,
thanks for catching these oversights, but see below
Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris:
> This DTS file was submitted with non-upstream bindings. I happened
> across this while reviewing the jaq DTS.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> ---
> Tested on jaq, not minnie
>
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index
> 0e30bd6bf92b..6f619c154dc6 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> @@ -128,12 +128,16 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> regulator-name = "vcc33_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> };
>
> vcc5v_touch: SWITCH_REG2 {
> regulator-name = "vcc5v_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
wouldn't regulator-suspend-mem-disabled translate to regulator-off-in-suspend?
At least looks like it according to https://lkml.org/lkml/2013/7/25/592
Heiko
> };
> };
> };
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties
Date: Tue, 18 Aug 2015 21:17:06 +0200 [thread overview]
Message-ID: <51457775.D3ds00ymOJ@phil> (raw)
In-Reply-To: <1439923455-109818-2-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Hi Brian,
thanks for catching these oversights, but see below
Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris:
> This DTS file was submitted with non-upstream bindings. I happened
> across this while reviewing the jaq DTS.
>
> Signed-off-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Cc: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Cc: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> Tested on jaq, not minnie
>
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index
> 0e30bd6bf92b..6f619c154dc6 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> @@ -128,12 +128,16 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> regulator-name = "vcc33_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> };
>
> vcc5v_touch: SWITCH_REG2 {
> regulator-name = "vcc5v_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
wouldn't regulator-suspend-mem-disabled translate to regulator-off-in-suspend?
At least looks like it according to https://lkml.org/lkml/2013/7/25/592
Heiko
> };
> };
> };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties
Date: Tue, 18 Aug 2015 21:17:06 +0200 [thread overview]
Message-ID: <51457775.D3ds00ymOJ@phil> (raw)
In-Reply-To: <1439923455-109818-2-git-send-email-briannorris@chromium.org>
Hi Brian,
thanks for catching these oversights, but see below
Am Dienstag, 18. August 2015, 11:44:15 schrieb Brian Norris:
> This DTS file was submitted with non-upstream bindings. I happened
> across this while reviewing the jaq DTS.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> ---
> Tested on jaq, not minnie
>
> arch/arm/boot/dts/rk3288-veyron-minnie.dts | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index
> 0e30bd6bf92b..6f619c154dc6 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts
> @@ -128,12 +128,16 @@
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> regulator-name = "vcc33_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
> };
>
> vcc5v_touch: SWITCH_REG2 {
> regulator-name = "vcc5v_touch";
> - regulator-suspend-mem-disabled;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + };
wouldn't regulator-suspend-mem-disabled translate to regulator-off-in-suspend?
At least looks like it according to https://lkml.org/lkml/2013/7/25/592
Heiko
> };
> };
> };
next prev parent reply other threads:[~2015-08-18 19:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 18:44 [PATCH 1/2] ARM: dts: rockchip: add veyron-jaq board Brian Norris
2015-08-18 18:44 ` Brian Norris
2015-08-18 18:44 ` Brian Norris
2015-08-18 18:44 ` [PATCH 2/2] ARM: dts: rockchip: correct regulator PM properties Brian Norris
2015-08-18 18:44 ` Brian Norris
2015-08-18 18:44 ` Brian Norris
2015-08-18 19:17 ` Heiko Stuebner [this message]
2015-08-18 19:17 ` Heiko Stuebner
2015-08-18 19:17 ` Heiko Stuebner
2015-08-18 20:30 ` Javier Martinez Canillas
2015-08-18 20:30 ` Javier Martinez Canillas
2015-08-18 20:30 ` Javier Martinez Canillas
2015-08-18 20:38 ` Javier Martinez Canillas
2015-08-18 20:38 ` Javier Martinez Canillas
2015-08-18 20:38 ` Javier Martinez Canillas
2015-08-18 22:48 ` Brian Norris
2015-08-18 22:48 ` Brian Norris
2015-08-18 22:48 ` Brian Norris
2015-08-18 23:28 ` Brian Norris
2015-08-18 23:28 ` Brian Norris
2015-08-19 6:19 ` Heiko Stuebner
2015-08-19 6:19 ` Heiko Stuebner
2015-08-19 6:19 ` Heiko Stuebner
2015-08-27 19:30 ` Doug Anderson
2015-08-27 19:30 ` Doug Anderson
2015-08-27 19:30 ` Doug Anderson
2015-08-27 20:51 ` Heiko Stuebner
2015-08-27 20:51 ` Heiko Stuebner
2015-08-27 20:51 ` Heiko Stuebner
2015-08-27 20:51 ` Heiko Stuebner
2015-08-27 20:56 ` Brian Norris
2015-08-27 20:56 ` Brian Norris
2015-08-27 20:56 ` Brian Norris
2015-08-18 19:19 ` [PATCH 1/2] ARM: dts: rockchip: add veyron-jaq board Heiko Stuebner
2015-08-18 19:19 ` Heiko Stuebner
2015-08-18 23:01 ` Brian Norris
2015-08-18 23:01 ` Brian Norris
2015-08-18 23:01 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51457775.D3ds00ymOJ@phil \
--to=heiko@sntech.de \
--cc=amstan@chromium.org \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.