From: Jeff Liu <jeff.liu@oracle.com> To: ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [patch 1/2 v2] Ocfs2/move_extents: fix error handling in ioctl Date: Tue, 09 Apr 2013 03:13:57 +0000 [thread overview] Message-ID: <51638775.1040201@oracle.com> (raw) In-Reply-To: <20130408170409.b16252fc16e9cdc8abfc91eb@linux-foundation.org> On 04/09/2013 08:04 AM, Andrew Morton wrote: > On Thu, 04 Apr 2013 19:52:36 +0800 Jeff Liu <jeff.liu@oracle.com> wrote: > >> On 04/04/2013 07:40 PM, Dan Carpenter wrote: >>> Smatch complains that if we hit an error (for example if the file is >>> immutable) then "range" has uninitialized stack data and we copy it to >>> the user. >>> >>> I've re-written the error handling to avoid this problem and make it a >>> little cleaner as well. >>> >>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> Reviewed-by: Jie Liu <jeff.liu@oracle.com> > > I can't find either of Dan's emails anywhere. Confused. > > Resend both, please? Looks they were eaten by the mailing list somehow, I'll resent both of them on behalf of Dan in a minute. Thanks, -Jeff > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com> To: ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [patch 1/2 v2] Ocfs2/move_extents: fix error handling in ioctl Date: Tue, 09 Apr 2013 11:13:57 +0800 [thread overview] Message-ID: <51638775.1040201@oracle.com> (raw) In-Reply-To: <20130408170409.b16252fc16e9cdc8abfc91eb@linux-foundation.org> On 04/09/2013 08:04 AM, Andrew Morton wrote: > On Thu, 04 Apr 2013 19:52:36 +0800 Jeff Liu <jeff.liu@oracle.com> wrote: > >> On 04/04/2013 07:40 PM, Dan Carpenter wrote: >>> Smatch complains that if we hit an error (for example if the file is >>> immutable) then "range" has uninitialized stack data and we copy it to >>> the user. >>> >>> I've re-written the error handling to avoid this problem and make it a >>> little cleaner as well. >>> >>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> Reviewed-by: Jie Liu <jeff.liu@oracle.com> > > I can't find either of Dan's emails anywhere. Confused. > > Resend both, please? Looks they were eaten by the mailing list somehow, I'll resent both of them on behalf of Dan in a minute. Thanks, -Jeff > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2013-04-09 3:13 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-04 6:37 [patch 1/2] Ocfs2/move_extents: fix error handling in ioctl Dan Carpenter 2013-04-04 6:39 ` [Ocfs2-devel] " Dan Carpenter 2013-04-04 9:21 ` Jeff Liu 2013-04-04 9:21 ` [Ocfs2-devel] " Jeff Liu 2013-04-04 11:40 ` [patch 1/2 v2] " Dan Carpenter 2013-04-04 11:42 ` [Ocfs2-devel] " Dan Carpenter 2013-04-04 11:52 ` Jeff Liu 2013-04-04 11:52 ` [Ocfs2-devel] " Jeff Liu 2013-04-09 0:04 ` Andrew Morton 2013-04-09 0:04 ` Andrew Morton 2013-04-09 3:13 ` Jeff Liu [this message] 2013-04-09 3:13 ` Jeff Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51638775.1040201@oracle.com \ --to=jeff.liu@oracle.com \ --cc=ocfs2-devel@oss.oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.