From: Eduardo Valentin <eduardo.valentin@ti.com> To: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <eduardo.valentin@ti.com>, <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get Date: Wed, 17 Apr 2013 15:18:57 -0400 [thread overview] Message-ID: <516EF5A1.9030306@ti.com> (raw) In-Reply-To: <1366211375.2091.52.camel@rzhang1-mobl4> On 17-04-2013 11:09, Zhang Rui wrote: > On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: >> To follow the prefix names used by the thermal exported functions, >> this patch renames get_thermal_instance to thermal_instance_get. >> >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > > NACK. > > with the change of building all thermal governors into thermal_sys > module, get_thermal_instance becomes an internally helper function, > rather than external API. > thus I think it is okay to use the current name get_thermal_instance. > But you remind me a need a cleanup patch to remove these APIs. :) How about keeping this patch and resending with a better description? Something like: To follow the prefix names used by the thermal functions, this patch renames get_thermal_instance to thermal_instance_get. > > thanks, > rui >> --- >> Documentation/thermal/sysfs-api.txt | 2 +- >> drivers/thermal/fair_share.c | 2 +- >> drivers/thermal/thermal_sys.c | 4 ++-- >> include/linux/thermal.h | 2 +- >> 4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt >> index 4b23190..059b3bf 100644 >> --- a/Documentation/thermal/sysfs-api.txt >> +++ b/Documentation/thermal/sysfs-api.txt >> @@ -358,7 +358,7 @@ are supposed to implement the callback. If they don't, the thermal >> framework calculated the trend by comparing the previous and the current >> temperature values. >> >> -5.2:get_thermal_instance: >> +5.2:thermal_instance_get: >> This function returns the thermal_instance corresponding to a given >> {thermal_zone, cooling_device, trip_point} combination. Returns NULL >> if such an instance does not exist. >> diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c >> index 792479f..f629446 100644 >> --- a/drivers/thermal/fair_share.c >> +++ b/drivers/thermal/fair_share.c >> @@ -95,7 +95,7 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip) >> continue; >> >> cdev = tzp->tbp[i].cdev; >> - instance = get_thermal_instance(tz, cdev, trip); >> + instance = thermal_instance_get(tz, cdev, trip); >> if (!instance) >> continue; >> >> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c >> index ffaf6d3..44e89c0 100644 >> --- a/drivers/thermal/thermal_sys.c >> +++ b/drivers/thermal/thermal_sys.c >> @@ -170,7 +170,7 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip) >> } >> EXPORT_SYMBOL(get_tz_trend); >> >> -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *tz, >> +struct thermal_instance *thermal_instance_get(struct thermal_zone_device *tz, >> struct thermal_cooling_device *cdev, int trip) >> { >> struct thermal_instance *pos = NULL; >> @@ -191,7 +191,7 @@ struct thermal_instance *get_thermal_instance(struct thermal_zone_device *tz, >> >> return target_instance; >> } >> -EXPORT_SYMBOL(get_thermal_instance); >> +EXPORT_SYMBOL(thermal_instance_get); >> >> static void print_bind_err_msg(struct thermal_zone_device *tz, >> struct thermal_cooling_device *cdev, int ret) >> diff --git a/include/linux/thermal.h b/include/linux/thermal.h >> index e8ec9d8..e2a49e1 100644 >> --- a/include/linux/thermal.h >> +++ b/include/linux/thermal.h >> @@ -239,7 +239,7 @@ struct thermal_cooling_device *thermal_cooling_device_register(char *, void *, >> void thermal_cooling_device_unregister(struct thermal_cooling_device *); >> >> int get_tz_trend(struct thermal_zone_device *, int); >> -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *, >> +struct thermal_instance *thermal_instance_get(struct thermal_zone_device *, >> struct thermal_cooling_device *, int); >> void thermal_cdev_update(struct thermal_cooling_device *); >> void thermal_notify_framework(struct thermal_zone_device *, int); > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Valentin <eduardo.valentin@ti.com> To: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <eduardo.valentin@ti.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get Date: Wed, 17 Apr 2013 15:18:57 -0400 [thread overview] Message-ID: <516EF5A1.9030306@ti.com> (raw) In-Reply-To: <1366211375.2091.52.camel@rzhang1-mobl4> On 17-04-2013 11:09, Zhang Rui wrote: > On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: >> To follow the prefix names used by the thermal exported functions, >> this patch renames get_thermal_instance to thermal_instance_get. >> >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > > NACK. > > with the change of building all thermal governors into thermal_sys > module, get_thermal_instance becomes an internally helper function, > rather than external API. > thus I think it is okay to use the current name get_thermal_instance. > But you remind me a need a cleanup patch to remove these APIs. :) How about keeping this patch and resending with a better description? Something like: To follow the prefix names used by the thermal functions, this patch renames get_thermal_instance to thermal_instance_get. > > thanks, > rui >> --- >> Documentation/thermal/sysfs-api.txt | 2 +- >> drivers/thermal/fair_share.c | 2 +- >> drivers/thermal/thermal_sys.c | 4 ++-- >> include/linux/thermal.h | 2 +- >> 4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt >> index 4b23190..059b3bf 100644 >> --- a/Documentation/thermal/sysfs-api.txt >> +++ b/Documentation/thermal/sysfs-api.txt >> @@ -358,7 +358,7 @@ are supposed to implement the callback. If they don't, the thermal >> framework calculated the trend by comparing the previous and the current >> temperature values. >> >> -5.2:get_thermal_instance: >> +5.2:thermal_instance_get: >> This function returns the thermal_instance corresponding to a given >> {thermal_zone, cooling_device, trip_point} combination. Returns NULL >> if such an instance does not exist. >> diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c >> index 792479f..f629446 100644 >> --- a/drivers/thermal/fair_share.c >> +++ b/drivers/thermal/fair_share.c >> @@ -95,7 +95,7 @@ static int fair_share_throttle(struct thermal_zone_device *tz, int trip) >> continue; >> >> cdev = tzp->tbp[i].cdev; >> - instance = get_thermal_instance(tz, cdev, trip); >> + instance = thermal_instance_get(tz, cdev, trip); >> if (!instance) >> continue; >> >> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c >> index ffaf6d3..44e89c0 100644 >> --- a/drivers/thermal/thermal_sys.c >> +++ b/drivers/thermal/thermal_sys.c >> @@ -170,7 +170,7 @@ int get_tz_trend(struct thermal_zone_device *tz, int trip) >> } >> EXPORT_SYMBOL(get_tz_trend); >> >> -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *tz, >> +struct thermal_instance *thermal_instance_get(struct thermal_zone_device *tz, >> struct thermal_cooling_device *cdev, int trip) >> { >> struct thermal_instance *pos = NULL; >> @@ -191,7 +191,7 @@ struct thermal_instance *get_thermal_instance(struct thermal_zone_device *tz, >> >> return target_instance; >> } >> -EXPORT_SYMBOL(get_thermal_instance); >> +EXPORT_SYMBOL(thermal_instance_get); >> >> static void print_bind_err_msg(struct thermal_zone_device *tz, >> struct thermal_cooling_device *cdev, int ret) >> diff --git a/include/linux/thermal.h b/include/linux/thermal.h >> index e8ec9d8..e2a49e1 100644 >> --- a/include/linux/thermal.h >> +++ b/include/linux/thermal.h >> @@ -239,7 +239,7 @@ struct thermal_cooling_device *thermal_cooling_device_register(char *, void *, >> void thermal_cooling_device_unregister(struct thermal_cooling_device *); >> >> int get_tz_trend(struct thermal_zone_device *, int); >> -struct thermal_instance *get_thermal_instance(struct thermal_zone_device *, >> +struct thermal_instance *thermal_instance_get(struct thermal_zone_device *, >> struct thermal_cooling_device *, int); >> void thermal_cdev_update(struct thermal_cooling_device *); >> void thermal_notify_framework(struct thermal_zone_device *, int); > > > >
next prev parent reply other threads:[~2013-04-17 19:25 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-08 16:07 From: Eduardo Valentin <eduardo.valentin@ti.com> Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 01/11] thermal: use strlcpy instead of strcpy Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:36 ` Zhang Rui 2013-04-08 16:07 ` [PATCH RESEND 02/11] thermal: update driver license Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 03/11] thermal: rename notify_thermal_framework to thermal_notify_framework Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:37 ` Zhang Rui 2013-04-08 16:07 ` [PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:09 ` Zhang Rui 2013-04-17 19:18 ` Eduardo Valentin [this message] 2013-04-17 19:18 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend_get Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:10 ` Zhang Rui 2013-04-17 19:20 ` Eduardo Valentin 2013-04-17 19:20 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 06/11] thermal: use EXPORT_SYMBOL_GPL Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:20 ` Zhang Rui 2013-04-17 19:22 ` Eduardo Valentin 2013-04-17 19:22 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 07/11] thermal: update kernel-doc for thermal_zone_bind_cooling_device Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:26 ` Zhang Rui 2013-04-17 15:28 ` Zhang Rui 2013-04-17 19:24 ` Eduardo Valentin 2013-04-17 19:24 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 08/11] thermal: update kernel-doc for thermal_zone_unbind_cooling_device Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:29 ` Zhang Rui 2013-04-08 16:07 ` [PATCH RESEND 09/11] thermal: update kernel-doc for thermal_cooling_device_register Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:31 ` Zhang Rui 2013-04-17 19:25 ` Eduardo Valentin 2013-04-17 19:25 ` Eduardo Valentin 2013-04-08 16:07 ` [PATCH RESEND 10/11] thermal: update kernel-doc for create_trip_attrs Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:31 ` Zhang Rui 2013-04-08 16:07 ` [PATCH RESEND 11/11] thermal: update kernel-doc for thermal_zone_device_register Eduardo Valentin 2013-04-08 16:07 ` Eduardo Valentin 2013-04-17 15:24 ` Zhang Rui 2013-04-17 19:30 ` Eduardo Valentin 2013-04-17 19:30 ` Eduardo Valentin 2013-04-24 16:50 ` Zhang, Rui 2013-04-24 16:50 ` Zhang, Rui 2013-04-17 17:15 ` From: Eduardo Valentin <eduardo.valentin@ti.com> Eduardo Valentin 2013-04-17 17:15 ` Eduardo Valentin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=516EF5A1.9030306@ti.com \ --to=eduardo.valentin@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.