From: "J, KEERTHY" <j-keerthy@ti.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Eduardo Valentin <edubezval@gmail.com> Cc: Zhang Rui <rui.zhang@intel.com>, <linux-pm@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 04/14] thermal: ti-soc-thermal: cleanup COUNTER feature handling for OMAP5 Date: Wed, 11 Jul 2018 09:08:29 +0530 [thread overview] Message-ID: <51799355-1a39-7f2f-6a20-a1718b9e0a64@ti.com> (raw) In-Reply-To: <1526298141-14045-5-git-send-email-b.zolnierkie@samsung.com> On 5/14/2018 5:12 PM, Bartlomiej Zolnierkiewicz wrote: > OMAP5 sensors don't claim COUNTER feature support (they use > COUNTER_DELAY feature instead) so there is no need to set fields > of struct temp_sensor_registers which are only used for COUNTER > feature. > > There should be no functional changes caused by this patch. Acked-by: Keerthy <j-keerthy@ti.com> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 9 --------- > drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h | 3 --- > 2 files changed, 12 deletions(-) > > diff --git a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > index 8191bae..e384be1 100644 > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > @@ -41,9 +41,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_MPU_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_MPU_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > @@ -77,9 +74,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_GPU_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_GPU_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > @@ -114,9 +108,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_CORE_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_CORE_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > diff --git a/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h b/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > index dcbf903..223c7a8 100644 > --- a/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > +++ b/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > @@ -93,9 +93,6 @@ > #define OMAP5430_MASK_HOT_MPU_MASK BIT(1) > #define OMAP5430_MASK_COLD_MPU_MASK BIT(0) > > -/* OMAP5430.BANDGAP_COUNTER */ > -#define OMAP5430_COUNTER_MASK (0xffffff << 0) > - > /* OMAP5430.BANDGAP_THRESHOLD */ > #define OMAP5430_T_HOT_MASK (0x3ff << 16) > #define OMAP5430_T_COLD_MASK (0x3ff << 0) >
WARNING: multiple messages have this Message-ID (diff)
From: "J, KEERTHY" <j-keerthy@ti.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Eduardo Valentin <edubezval@gmail.com> Cc: Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/14] thermal: ti-soc-thermal: cleanup COUNTER feature handling for OMAP5 Date: Wed, 11 Jul 2018 09:08:29 +0530 [thread overview] Message-ID: <51799355-1a39-7f2f-6a20-a1718b9e0a64@ti.com> (raw) In-Reply-To: <1526298141-14045-5-git-send-email-b.zolnierkie@samsung.com> On 5/14/2018 5:12 PM, Bartlomiej Zolnierkiewicz wrote: > OMAP5 sensors don't claim COUNTER feature support (they use > COUNTER_DELAY feature instead) so there is no need to set fields > of struct temp_sensor_registers which are only used for COUNTER > feature. > > There should be no functional changes caused by this patch. Acked-by: Keerthy <j-keerthy@ti.com> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > drivers/thermal/ti-soc-thermal/omap5-thermal-data.c | 9 --------- > drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h | 3 --- > 2 files changed, 12 deletions(-) > > diff --git a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > index 8191bae..e384be1 100644 > --- a/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > +++ b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c > @@ -41,9 +41,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_MPU_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_MPU_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > @@ -77,9 +74,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_GPU_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_GPU_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > @@ -114,9 +108,6 @@ > .mask_counter_delay_mask = OMAP5430_MASK_COUNTER_DELAY_MASK, > .mask_freeze_mask = OMAP5430_MASK_FREEZE_CORE_MASK, > > - .bgap_counter = OMAP5430_BGAP_CTRL_OFFSET, > - .counter_mask = OMAP5430_COUNTER_MASK, > - > .bgap_threshold = OMAP5430_BGAP_THRESHOLD_CORE_OFFSET, > .threshold_thot_mask = OMAP5430_T_HOT_MASK, > .threshold_tcold_mask = OMAP5430_T_COLD_MASK, > diff --git a/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h b/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > index dcbf903..223c7a8 100644 > --- a/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > +++ b/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h > @@ -93,9 +93,6 @@ > #define OMAP5430_MASK_HOT_MPU_MASK BIT(1) > #define OMAP5430_MASK_COLD_MPU_MASK BIT(0) > > -/* OMAP5430.BANDGAP_COUNTER */ > -#define OMAP5430_COUNTER_MASK (0xffffff << 0) > - > /* OMAP5430.BANDGAP_THRESHOLD */ > #define OMAP5430_T_HOT_MASK (0x3ff << 16) > #define OMAP5430_T_COLD_MASK (0x3ff << 0) >
next prev parent reply other threads:[~2018-07-11 3:38 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20180514114255epcas1p438ea8d32c2b7fd40b86afb25c9c8f2cf@epcas1p4.samsung.com> 2018-05-14 11:42 ` [PATCH 00/14] thermal: ti-soc-thermal: simplify the driver a bit Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114302epcas1p1890ad3296302900a736262b5d67aa10e@epcas1p1.samsung.com> 2018-05-14 11:42 ` [PATCH 01/14] thermal: ti-soc-thermal: fix TALERT IRQ handling for DRA752 Bartlomiej Zolnierkiewicz 2018-07-11 2:19 ` J, KEERTHY 2018-07-11 2:19 ` J, KEERTHY [not found] ` <CGME20180725142707eucas1p25bf4bc7b63babc0732db13ae9a79d983@eucas1p2.samsung.com> 2018-07-25 14:27 ` Bartlomiej Zolnierkiewicz 2018-07-27 4:43 ` Keerthy 2018-07-27 4:43 ` Keerthy [not found] ` <CGME20180727143023eucas1p1adfe1860327829e7cf39bcdd3290d11c@eucas1p1.samsung.com> 2018-07-27 14:30 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114308epcas2p3bba580c5500889f22d50549994b227db@epcas2p3.samsung.com> 2018-05-14 11:42 ` [PATCH 02/14] thermal: ti-soc-thermal: fix comment in omap5xxx-bandgap.h Bartlomiej Zolnierkiewicz 2018-07-11 2:21 ` J, KEERTHY 2018-07-11 2:21 ` J, KEERTHY [not found] ` <CGME20180514114312epcas1p19fffd35baae3018f47df0fe31ca1b1b0@epcas1p1.samsung.com> 2018-05-14 11:42 ` [PATCH 03/14] thermal: ti-soc-thermal: fix comments in omap4-thermal-data.c Bartlomiej Zolnierkiewicz 2018-07-11 2:27 ` J, KEERTHY 2018-07-11 2:27 ` J, KEERTHY [not found] ` <CGME20180514114319epcas1p1921a83c1baaaf1e6f94283f462022dc5@epcas1p1.samsung.com> 2018-05-14 11:42 ` [PATCH 04/14] thermal: ti-soc-thermal: cleanup COUNTER feature handling for OMAP5 Bartlomiej Zolnierkiewicz 2018-07-11 3:38 ` J, KEERTHY [this message] 2018-07-11 3:38 ` J, KEERTHY [not found] ` <CGME20180725142832eucas1p26a8b5a1226b1043d57332b70ba5caaa0@eucas1p2.samsung.com> 2018-07-25 14:28 ` Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114326epcas2p2e27987b5be7a1fe614114466c6cf30f8@epcas2p2.samsung.com> 2018-05-14 11:42 ` [PATCH 05/14] thermal: ti-soc-thermal: remove redundant methods from struct ti_bandgap_data Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114331epcas2p3d52dea1f2feda21ff2cce1548f3f5bd4@epcas2p3.samsung.com> 2018-05-14 11:42 ` [PATCH 06/14] thermal: ti-soc-thermal: remove ->threshold_[thot,tcold]_mask fields Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114334epcas1p4c1b268d8253cda369826e67b06b4c28b@epcas1p4.samsung.com> 2018-05-14 11:42 ` [PATCH 07/14] thermal: ti-soc-thermal: remove ->tshut_[hot,cold]_mask fields Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114337epcas1p1ba67790ed771ab09c0be25712c8b385f@epcas1p1.samsung.com> 2018-05-14 11:42 ` [PATCH 08/14] thermal: ti-soc-thermal: use common struct temp_sensor_data for OMAP5 Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114340epcas2p10a9a4aad3064ad752cd2bea456581a98@epcas2p1.samsung.com> 2018-05-14 11:42 ` [PATCH 09/14] thermal: ti-soc-thermal: use common struct temp_sensor_data for DRA752 Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114343epcas2p4280b4ff50611a223a1b3ae37dbe743ee@epcas2p4.samsung.com> 2018-05-14 11:42 ` [PATCH 10/14] thermal: ti-soc-thermal: use OMAP5 defines " Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114346epcas1p4a59f6760861791ae53eac48975c9172a@epcas1p4.samsung.com> 2018-05-14 11:42 ` [PATCH 11/14] thermal: ti-soc-thermal: use OMAP5 register tables " Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114350epcas1p2d29cfa8de6b19096d91362c91feb2dc5@epcas1p2.samsung.com> 2018-05-14 11:42 ` [PATCH 12/14] thermal: ti-soc-thermal: add ->adc_to_mcelsius method Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114355epcas2p4c24f87c5a76ff3d3e9ed319ddc2e78ad@epcas2p4.samsung.com> 2018-05-14 11:42 ` [PATCH 13/14] thermal: ti-soc-thermal: use short int for *_adc_to_temp[] conversion tables Bartlomiej Zolnierkiewicz [not found] ` <CGME20180514114400epcas2p193e6f6643171575aab079329bed79c2c@epcas2p1.samsung.com> 2018-05-14 11:42 ` [PATCH 14/14] thermal: ti-soc-thermal: remove SoC family config options Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51799355-1a39-7f2f-6a20-a1718b9e0a64@ti.com \ --to=j-keerthy@ti.com \ --cc=b.zolnierkie@samsung.com \ --cc=edubezval@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.